* [PATCH] Fix divide by 0 in echoaudio driver
@ 2010-06-03 21:43 Giuliano Pochini
0 siblings, 0 replies; only message in thread
From: Giuliano Pochini @ 2010-06-03 21:43 UTC (permalink / raw)
To: linux-kernel
This patch has already been merged in 2.6.34:
http://git.kernel.org/?p=linux/kernel/git/stable/linux-2.6.34.y.git;a=commitdiff;h=b721e68bdc5b39c51bf6a1469f8d3663fbe03243
Since it fixes a /0 in the irq handler, please consider including it also
in the next maintenance release of 2.6.33.
This patch is against 2.6.33.5.
Signed-off-by: Giuliano Pochini <pochini@shiny.it>
--- a/sound/pci/echoaudio/echoaudio.c 2010-06-03 22:23:21.000000000 +0100
+++ b/sound/pci/echoaudio/echoaudio.c 2010-06-03 22:48:33.000000000 +0100
@@ -1821,7 +1821,9 @@ static irqreturn_t snd_echo_interrupt(in
/* The hardware doesn't tell us which substream caused the irq,
thus we have to check all running substreams. */
for (ss = 0; ss < DSP_MAXPIPES; ss++) {
- if ((substream = chip->substream[ss])) {
+ substream = chip->substream[ss];
+ if (substream && ((struct audiopipe *)substream->runtime->
+ private_data)->state == PIPE_STATE_STARTED) {
period = pcm_pointer(substream) /
substream->runtime->period_size;
if (period != chip->last_period[ss]) {
--
Giuliano.
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2010-06-03 21:44 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-06-03 21:43 [PATCH] Fix divide by 0 in echoaudio driver Giuliano Pochini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.