From: Paul Mundt <lethal@linux-sh.org>
To: David Miller <davem@davemloft.net>
Cc: peterz@infradead.org, linux-kernel@vger.kernel.org,
linux-arch@vger.kernel.org, sparclinux@vger.kernel.org
Subject: Re: [PATCH 1/4] kernel: local_irq_{save,restore}_nmi()
Date: Fri, 4 Jun 2010 14:03:47 +0900 [thread overview]
Message-ID: <20100604050347.GE31868@linux-sh.org> (raw)
In-Reply-To: <20100409.160135.35854399.davem@davemloft.net>
On Fri, Apr 09, 2010 at 04:01:35PM -0700, David Miller wrote:
>
> Provide local_irq_{save,restore}_nmi() which will allow us to help
> architectures that implement NMIs using IRQ priorities like SPARC64
> does.
>
> Sparc uses IRQ prio 15 for NMIs and implements local_irq_disable() as
> disable <= 14. However if you do that while inside an NMI you re-
> enable the NMI priority again, causing all kinds of fun.
>
> A more solid implementation would first check the disable level and
> never lower it, however that is more costly and would slow down the
> rest of the kernel for no particular reason.
>
> Therefore introduce local_irq_save_nmi() which can implement this
> slower but more solid scheme and dis-allow local_irq_save() from NMI
> context.
>
> Suggested-by: David Miller <davem@davemloft.net>
> Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
> Signed-off-by: David S. Miller <davem@davemloft.net>
Are there any updates for this patch series? I would like to make use of
this on SH as well, but it seems these haven't hit upstream yet.
WARNING: multiple messages have this Message-ID (diff)
From: Paul Mundt <lethal@linux-sh.org>
To: David Miller <davem@davemloft.net>
Cc: peterz@infradead.org, linux-kernel@vger.kernel.org,
linux-arch@vger.kernel.org, sparclinux@vger.kernel.org
Subject: Re: [PATCH 1/4] kernel: local_irq_{save,restore}_nmi()
Date: Fri, 04 Jun 2010 05:03:47 +0000 [thread overview]
Message-ID: <20100604050347.GE31868@linux-sh.org> (raw)
In-Reply-To: <20100409.160135.35854399.davem@davemloft.net>
On Fri, Apr 09, 2010 at 04:01:35PM -0700, David Miller wrote:
>
> Provide local_irq_{save,restore}_nmi() which will allow us to help
> architectures that implement NMIs using IRQ priorities like SPARC64
> does.
>
> Sparc uses IRQ prio 15 for NMIs and implements local_irq_disable() as
> disable <= 14. However if you do that while inside an NMI you re-
> enable the NMI priority again, causing all kinds of fun.
>
> A more solid implementation would first check the disable level and
> never lower it, however that is more costly and would slow down the
> rest of the kernel for no particular reason.
>
> Therefore introduce local_irq_save_nmi() which can implement this
> slower but more solid scheme and dis-allow local_irq_save() from NMI
> context.
>
> Suggested-by: David Miller <davem@davemloft.net>
> Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
> Signed-off-by: David S. Miller <davem@davemloft.net>
Are there any updates for this patch series? I would like to make use of
this on SH as well, but it seems these haven't hit upstream yet.
next prev parent reply other threads:[~2010-06-04 5:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-09 23:01 [PATCH 1/4] kernel: local_irq_{save,restore}_nmi() David Miller
2010-04-09 23:01 ` David Miller
2010-06-04 5:03 ` Paul Mundt [this message]
2010-06-04 5:03 ` Paul Mundt
2010-06-04 7:35 ` Peter Zijlstra
2010-06-04 7:35 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100604050347.GE31868@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=davem@davemloft.net \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.