All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: linux-fsdevel@vger.kernel.org, akpm@linux-foundation.org,
	linux-kernel@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: [PATCH 3/6] writeback: Add tracing to write_cache_pages
Date: Fri, 4 Jun 2010 03:51:27 -0400	[thread overview]
Message-ID: <20100604075127.GA7317@infradead.org> (raw)
In-Reply-To: <1275609328-12514-4-git-send-email-david@fromorbit.com>

On Fri, Jun 04, 2010 at 09:55:25AM +1000, Dave Chinner wrote:
> Add a trace event to the ->writepage loop in write_cache_pages to give
> visibility into how the ->writepage call is changing variables within the
> writeback control structure. Of most interest is how wbc->nr_to_write changes
> from call to call, especially with filesystems that write multiple pages
> in ->writepage.

Looks good, it might be worth to add another tracepoint for ->writepage
from reclaim context so that we can start investigating the cases where
that happens far too often.

Reviewed-by: Christoph Hellwig <hch@lst.de>

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	xfs@oss.sgi.com, akpm@linux-foundation.org
Subject: Re: [PATCH 3/6] writeback: Add tracing to write_cache_pages
Date: Fri, 4 Jun 2010 03:51:27 -0400	[thread overview]
Message-ID: <20100604075127.GA7317@infradead.org> (raw)
In-Reply-To: <1275609328-12514-4-git-send-email-david@fromorbit.com>

On Fri, Jun 04, 2010 at 09:55:25AM +1000, Dave Chinner wrote:
> Add a trace event to the ->writepage loop in write_cache_pages to give
> visibility into how the ->writepage call is changing variables within the
> writeback control structure. Of most interest is how wbc->nr_to_write changes
> from call to call, especially with filesystems that write multiple pages
> in ->writepage.

Looks good, it might be worth to add another tracepoint for ->writepage
from reclaim context so that we can start investigating the cases where
that happens far too often.

Reviewed-by: Christoph Hellwig <hch@lst.de>

  reply	other threads:[~2010-06-04  7:48 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-03 23:55 [PATCH 0/6] writeback: tracing and fixes V3 Dave Chinner
2010-06-03 23:55 ` Dave Chinner
2010-06-03 23:55 ` [PATCH 1/6] writeback: initial tracing support Dave Chinner
2010-06-03 23:55   ` Dave Chinner
2010-06-04  1:10   ` Li Zefan
2010-06-04  1:10     ` Li Zefan
2010-06-04  1:24     ` Dave Chinner
2010-06-04  1:24       ` Dave Chinner
2010-06-03 23:55 ` [PATCH 2/6] writeback: Add tracing to balance_dirty_pages Dave Chinner
2010-06-03 23:55   ` Dave Chinner
2010-06-03 23:55 ` [PATCH 3/6] writeback: Add tracing to write_cache_pages Dave Chinner
2010-06-03 23:55   ` Dave Chinner
2010-06-04  7:51   ` Christoph Hellwig [this message]
2010-06-04  7:51     ` Christoph Hellwig
2010-06-03 23:55 ` [PATCH 4/6] writeback: pay attention to wbc->nr_to_write in write_cache_pages Dave Chinner
2010-06-03 23:55   ` Dave Chinner
2010-06-04  7:48   ` Christoph Hellwig
2010-06-04  7:48     ` Christoph Hellwig
2010-06-03 23:55 ` [PATCH 5/6] xfs: remove nr_to_write writeback windup Dave Chinner
2010-06-03 23:55   ` Dave Chinner
2010-06-03 23:55 ` [PATCH 6/6] writeback: limit write_cache_pages integrity scanning to current EOF Dave Chinner
2010-06-03 23:55   ` Dave Chinner
2010-06-04  7:52   ` Christoph Hellwig
2010-06-04  7:52     ` Christoph Hellwig
2010-06-04  7:56     ` Nick Piggin
2010-06-04  7:56       ` Nick Piggin
2010-06-04  7:49 ` [PATCH 0/6] writeback: tracing and fixes V3 Christoph Hellwig
2010-06-04  7:49   ` Christoph Hellwig
2010-06-08  0:11   ` Dave Chinner
2010-06-08  0:11     ` Dave Chinner
2010-06-08  8:03     ` Christoph Hellwig
2010-06-08  8:03       ` Christoph Hellwig
  -- strict thread matches above, loose matches on Subject: below --
2010-06-08  0:38 [PATCH 0/6] writeback: tracing and fixes V4 Dave Chinner
2010-06-08  0:38 ` [PATCH 3/6] writeback: Add tracing to write_cache_pages Dave Chinner
2010-06-08  0:38   ` Dave Chinner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100604075127.GA7317@infradead.org \
    --to=hch@infradead.org \
    --cc=akpm@linux-foundation.org \
    --cc=david@fromorbit.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.