All of lore.kernel.org
 help / color / mirror / Atom feed
From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [RFC PATCH 1/6] Change in at_cds_notify for status report.
Date: Fri, 04 Jun 2010 11:52:13 -0500	[thread overview]
Message-ID: <201006041152.14627.denkenz@gmail.com> (raw)
In-Reply-To: <1275650257-30593-2-git-send-email-pasi.miettinen@ixonos.com>

[-- Attachment #1: Type: text/plain, Size: 528 bytes --]

Hi Pasi,

> ---
>  drivers/atmodem/sms.c |   19 +++++++++++++++----
>  1 files changed, 15 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/atmodem/sms.c b/drivers/atmodem/sms.c
> index 439beea..3dafbc9 100644
> -	DBG("Got new Status-Report PDU via CDS: %s, %d", pdu, pdulen);
> +	if (strlen(hexpdu) > sizeof(pdu) * 2) {
> +		ofono_error("Bad PDU length in CMT notification");
> +		return;
> +	}

Watch out for copy-paste mistakes.  Fixed it for you.

Patch has been applied, thanks.

Regards,
-Denis

  parent reply	other threads:[~2010-06-04 16:52 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-04 11:17 Next series of delivery report patches Pasi Miettinen
2010-06-04 11:17 ` [RFC PATCH 1/6] Change in at_cds_notify for status report Pasi Miettinen
2010-06-04 11:17   ` [RFC PATCH 2/6] Add IncomingStatusReport a{sv} signal Pasi Miettinen
2010-06-04 11:17     ` [RFC PATCH 3/6] Support for basic SMS Status Report Pasi Miettinen
2010-06-04 11:17       ` [RFC PATCH 4/6] SetProperty for UseDeliveryReports Pasi Miettinen
2010-06-04 11:17         ` [RFC PATCH 5/6] Support for concatenated SMS status report Pasi Miettinen
2010-06-04 11:17           ` [RFC PATCH 6/6] Save pending SMS Status Reports to disk Pasi Miettinen
2010-06-04 22:04           ` [RFC PATCH 5/6] Support for concatenated SMS status report Denis Kenzior
2010-06-05  5:57             ` VS: " Miettinen Pasi
2010-06-07 12:22             ` Miettinen Pasi
2010-06-07 13:02               ` Miettinen Pasi
2010-06-07 17:45               ` Denis Kenzior
2010-06-04 17:08         ` [RFC PATCH 4/6] SetProperty for UseDeliveryReports Denis Kenzior
2010-06-04 17:01       ` [RFC PATCH 3/6] Support for basic SMS Status Report Denis Kenzior
2010-06-04 16:58     ` [RFC PATCH 2/6] Add IncomingStatusReport a{sv} signal Denis Kenzior
2010-06-04 16:52   ` Denis Kenzior [this message]
2010-06-04 11:28 ` VS: Next series of delivery report patches Miettinen Pasi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201006041152.14627.denkenz@gmail.com \
    --to=denkenz@gmail.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.