Re: [RFC PATCH 2/6] Add IncomingStatusReport a{sv} signal.

[Denis Kenzior <denkenz@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1072 bytes --]

Hi Pasi,

> ---
>  src/sms.c |    7 ++++---
>  1 files changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/src/sms.c b/src/sms.c
> index c0e9fc4..618e035 100644
> --- a/src/sms.c
> +++ b/src/sms.c
> @@ -472,9 +472,10 @@ static GDBusMethodTable sms_manager_methods[] = {
>  };
> 
>  static GDBusSignalTable sms_manager_signals[] = {
> -	{ "PropertyChanged",	"sv"		},
> -	{ "IncomingMessage",	"sa{sv}"	},
> -	{ "ImmediateMessage",	"sa{sv}"	},
> +	{ "PropertyChanged",		"sv"		},
> +	{ "IncomingMessage",		"sa{sv}"	},
> +	{ "ImmediateMessage",		"sa{sv}"	},
> +	{ "IncomingStatusReport",	"a{sv}"		},
>  	{ }
>  };
> 

IncomingStatusReport signal is the wrong approach, we need to actually 
associate a status report with a message.  This will be done in two ways:
	- Via sms history
	- Via sms message D-Bus interface.  See the "See / Cancel pending..." task in 
TODO

Until that task is done, I would only go through the history plugin.  Feel 
free to modify the example history to simply print the delivery status.

Regards,
-Denis