All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] libvpx: disabled explicitly the generation of docs
@ 2010-06-04 17:39 Enrico Scholz
  2010-06-04 22:08 ` Khem Raj
  0 siblings, 1 reply; 3+ messages in thread
From: Enrico Scholz @ 2010-06-04 17:39 UTC (permalink / raw)
  To: openembedded-devel; +Cc: Enrico Scholz, Koen Kooi

When buildsystem has 'doxygen' and 'php' the documentation will be
created and the path in do_install (vpx-vp8-nopost-nodocs) won't be
found anymore:

| make[2]: Leaving directory `.../libvpx-0.9.0-r2/libvpx-0.9.0'
| + cp -r '.../libvpx-0.9.0/vpx-vp8-nopost-nodocs*0.9.0/*' .../image/usr/
| cp: cannot stat `.../libvpx-0.9.0/vpx-vp8-nopost-nodocs*0.9.0/*': No such file or directory
| ERROR: Function do_install failed NOTE: package libvpx-0.9.0-r2: task do_install: Failed

This patch makes the build more deterministic.

Signed-off-by: Enrico Scholz <enrico.scholz@sigma-chemnitz.de>
Cc: Koen Kooi <koen@openembedded.org>
---
 recipes/webm/libvpx_0.9.0.bb |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/recipes/webm/libvpx_0.9.0.bb b/recipes/webm/libvpx_0.9.0.bb
index a59d94d..b55604b 100644
--- a/recipes/webm/libvpx_0.9.0.bb
+++ b/recipes/webm/libvpx_0.9.0.bb
@@ -1,7 +1,7 @@
 DESCRIPTION = "vpx Multi-Format Codec SDK"
 LICENSE = "VP8"
 
-PR = "r2"
+PR = "r3"
 
 SRC_URI = "http://webm.googlecode.com/files/libvpx-${PV}.tar.bz2"
 
@@ -20,6 +20,7 @@ VPXTARGET ?= "generic-gnu"
 
 CONFIGUREOPTS = " \
           --target=${VPXTARGET} \
+          --disable-install_docs \
           --enable-vp8 \
           --enable-libs \
 "
-- 
1.7.0.1




^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] libvpx: disabled explicitly the generation of docs
  2010-06-04 17:39 [PATCH] libvpx: disabled explicitly the generation of docs Enrico Scholz
@ 2010-06-04 22:08 ` Khem Raj
  2010-06-04 23:34   ` Enrico Scholz
  0 siblings, 1 reply; 3+ messages in thread
From: Khem Raj @ 2010-06-04 22:08 UTC (permalink / raw)
  To: openembedded-devel; +Cc: Enrico Scholz, Koen Kooi

On (04/06/10 19:39), Enrico Scholz wrote:
> When buildsystem has 'doxygen' and 'php' the documentation will be
> created and the path in do_install (vpx-vp8-nopost-nodocs) won't be
> found anymore:

where do they get put when doxygen and php are found. You may also
put doxygen-native and php-native in DEPENDS and generate the documentation
always but that may be overkill if we already have documentation prebuilt
which can be installed. is that the case?

> 
> | make[2]: Leaving directory `.../libvpx-0.9.0-r2/libvpx-0.9.0'
> | + cp -r '.../libvpx-0.9.0/vpx-vp8-nopost-nodocs*0.9.0/*' .../image/usr/
> | cp: cannot stat `.../libvpx-0.9.0/vpx-vp8-nopost-nodocs*0.9.0/*': No such file or directory
> | ERROR: Function do_install failed NOTE: package libvpx-0.9.0-r2: task do_install: Failed
> 
> This patch makes the build more deterministic.
> 
> Signed-off-by: Enrico Scholz <enrico.scholz@sigma-chemnitz.de>
> Cc: Koen Kooi <koen@openembedded.org>
> ---
>  recipes/webm/libvpx_0.9.0.bb |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/recipes/webm/libvpx_0.9.0.bb b/recipes/webm/libvpx_0.9.0.bb
> index a59d94d..b55604b 100644
> --- a/recipes/webm/libvpx_0.9.0.bb
> +++ b/recipes/webm/libvpx_0.9.0.bb
> @@ -1,7 +1,7 @@
>  DESCRIPTION = "vpx Multi-Format Codec SDK"
>  LICENSE = "VP8"
>  
> -PR = "r2"
> +PR = "r3"
>  
>  SRC_URI = "http://webm.googlecode.com/files/libvpx-${PV}.tar.bz2"
>  
> @@ -20,6 +20,7 @@ VPXTARGET ?= "generic-gnu"
>  
>  CONFIGUREOPTS = " \
>            --target=${VPXTARGET} \
> +          --disable-install_docs \

Does it disable the doc generation completely ?

>            --enable-vp8 \
>            --enable-libs \
>  "
> -- 
> 1.7.0.1
> 
> 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] libvpx: disabled explicitly the generation of docs
  2010-06-04 22:08 ` Khem Raj
@ 2010-06-04 23:34   ` Enrico Scholz
  0 siblings, 0 replies; 3+ messages in thread
From: Enrico Scholz @ 2010-06-04 23:34 UTC (permalink / raw)
  To: Khem Raj; +Cc: Koen Kooi, openembedded-devel

Khem Raj <raj.khem@gmail.com> writes:

>> When buildsystem has 'doxygen' and 'php' the documentation will be
>> created and the path in do_install (vpx-vp8-nopost-nodocs) won't be
>> found anymore:
>
> Where do they get put when doxygen and php are found.

logic in configure is

| enabled doxygen && php -v >/dev/null 2>&1 && enable install_docs
| ...
| enabled debug_libs && DIST_DIR="${DIST_DIR}-debug"
| enabled codec_srcs && DIST_DIR="${DIST_DIR}-src"
| ! enabled postproc && DIST_DIR="${DIST_DIR}-nopost"
| ! enabled multithread && DIST_DIR="${DIST_DIR}-nomt"
| enabled eval_limit && DIST_DIR="${DIST_DIR}-eval"
| ! enabled install_docs && DIST_DIR="${DIST_DIR}-nodocs"

and build of documentation depends on 'install_docs'.

Current package assumes that DIST_DIR is -nodocs.


> You may also put doxygen-native and php-native in DEPENDS and generate
> the documentation always but that may be overkill if we already have
> documentation prebuilt which can be installed. is that the case?

There is no prebuilt documentation. doxygen in DEPENDS would be ok, but
adding a dependency on php seems to be overkill imho.


>> +          --disable-install_docs \
>
> Does it disable the doc generation completely ?

yes



Enrico



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2010-06-04 23:39 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-06-04 17:39 [PATCH] libvpx: disabled explicitly the generation of docs Enrico Scholz
2010-06-04 22:08 ` Khem Raj
2010-06-04 23:34   ` Enrico Scholz

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.