* [PATCH] SDHCI: add no hi-speed bit quirk support
@ 2010-06-05 4:50 Kyungmin Park
0 siblings, 0 replies; 3+ messages in thread
From: Kyungmin Park @ 2010-06-05 4:50 UTC (permalink / raw)
To: linux-mmc, akpm
Some SDHCI controllr like s5pc110 doesn't have HISPD bit at HOSTCTL register.
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
index c6d1bd8..cba08ce 100644
--- a/drivers/mmc/host/sdhci.c
+++ b/drivers/mmc/host/sdhci.c
@@ -1164,7 +1164,8 @@ static void sdhci_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
else
ctrl &= ~SDHCI_CTRL_4BITBUS;
- if (ios->timing == MMC_TIMING_SD_HS)
+ if (ios->timing == MMC_TIMING_SD_HS &&
+ !(host->quirks & SDHCI_QUIRK_NO_HISPD_BIT))
ctrl |= SDHCI_CTRL_HISPD;
else
ctrl &= ~SDHCI_CTRL_HISPD;
diff --git a/drivers/mmc/host/sdhci.h b/drivers/mmc/host/sdhci.h
index c846813..a78152d 100644
--- a/drivers/mmc/host/sdhci.h
+++ b/drivers/mmc/host/sdhci.h
@@ -240,6 +240,8 @@ struct sdhci_host {
#define SDHCI_QUIRK_CAP_CLOCK_BASE_BROKEN (1<<25)
/* Controller cannot support End Attribute in NOP ADMA descriptor */
#define SDHCI_QUIRK_NO_ENDATTR_IN_NOPDESC (1<<26)
+/* Controller doesn't have HISPD bit field in HI-SPEED SD card */
+#define SDHCI_QUIRK_NO_HISPD_BIT (1<<27)
int irq; /* Device IRQ */
void __iomem * ioaddr; /* Mapped address */
^ permalink raw reply related [flat|nested] 3+ messages in thread* RE: [PATCH] SDHCI: add no hi-speed bit quirk support
@ 2010-06-07 8:02 Kukjin Kim
0 siblings, 0 replies; 3+ messages in thread
From: Kukjin Kim @ 2010-06-07 8:02 UTC (permalink / raw)
To: kyungmin.park; +Cc: linux-mmc
Kyungmin Park wrote:
>
> Some SDHCI controllr like s5pc110 doesn't have HISPD bit at HOSTCTL
register.
>
typo
> Signed-off-by: Kyungmin Park <kyungmin.park <at> samsung.com>
> ---
> diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
> index c6d1bd8..cba08ce 100644
> --- a/drivers/mmc/host/sdhci.c
> +++ b/drivers/mmc/host/sdhci.c
> @@ -1164,7 +1164,8 @@ static void sdhci_set_ios(struct mmc_host *mmc,
struct mmc_ios *ios)
> else
> ctrl &= ~SDHCI_CTRL_4BITBUS;
>
> - if (ios->timing == MMC_TIMING_SD_HS)
> + if (ios->timing == MMC_TIMING_SD_HS &&
> + !(host->quirks & SDHCI_QUIRK_NO_HISPD_BIT))
host->quirks |= SDHCI_QURIK_NO_HISPD_BIT missed in
drivers/mmc/host/sdhci-s3c.c
> ctrl |= SDHCI_CTRL_HISPD;
> else
> ctrl &= ~SDHCI_CTRL_HISPD;
> diff --git a/drivers/mmc/host/sdhci.h b/drivers/mmc/host/sdhci.h
> index c846813..a78152d 100644
> --- a/drivers/mmc/host/sdhci.h
> +++ b/drivers/mmc/host/sdhci.h
> @@ -240,6 +240,8 @@ struct sdhci_host {
> #define SDHCI_QUIRK_CAP_CLOCK_BASE_BROKEN (1<<25)
> /* Controller cannot support End Attribute in NOP ADMA descriptor */
> #define SDHCI_QUIRK_NO_ENDATTR_IN_NOPDESC (1<<26)
> +/* Controller doesn't have HISPD bit field in HI-SPEED SD card */
> +#define SDHCI_QUIRK_NO_HISPD_BIT (1<<27)
>
> int irq; /* Device IRQ */
> void __iomem * ioaddr; /* Mapped address */
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH 1/2] MAINTAINERS: update files for SAMSUNG ARM ARCHITECTURES
@ 2010-06-04 10:36 Kukjin Kim
2010-06-04 10:36 ` [PATCH 2/2] MAINTAINERS: add maintainer " Kukjin Kim
0 siblings, 1 reply; 3+ messages in thread
From: Kukjin Kim @ 2010-06-04 10:36 UTC (permalink / raw)
To: linux-arm-kernel
Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
---
MAINTAINERS | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index a73dd80..1d41149 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -899,7 +899,7 @@ M: Ben Dooks <ben-linux@fluff.org>
L: linux-arm-kernel at lists.infradead.org (moderated for non-subscribers)
W: http://www.fluff.org/ben/linux/
S: Maintained
-F: arch/arm/plat-s3c/
+F: arch/arm/plat-samsung/
F: arch/arm/plat-s3c24xx/
ARM/S3C2410 ARM ARCHITECTURE
--
1.6.2.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 2/2] MAINTAINERS: add maintainer for SAMSUNG ARM ARCHITECTURES
2010-06-04 10:36 [PATCH 1/2] MAINTAINERS: update files for SAMSUNG ARM ARCHITECTURES Kukjin Kim
@ 2010-06-04 10:36 ` Kukjin Kim
2010-06-05 2:24 ` Kyungmin Park
0 siblings, 1 reply; 3+ messages in thread
From: Kukjin Kim @ 2010-06-04 10:36 UTC (permalink / raw)
To: linux-arm-kernel
Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
---
MAINTAINERS | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 1d41149..f4e4c61 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -896,11 +896,13 @@ S: Maintained
ARM/SAMSUNG ARM ARCHITECTURES
M: Ben Dooks <ben-linux@fluff.org>
+M: Kukjin Kim <kgene.kim@samsung.com>
L: linux-arm-kernel at lists.infradead.org (moderated for non-subscribers)
W: http://www.fluff.org/ben/linux/
S: Maintained
F: arch/arm/plat-samsung/
F: arch/arm/plat-s3c24xx/
+F: arch/arm/plat-s5p/
ARM/S3C2410 ARM ARCHITECTURE
M: Ben Dooks <ben-linux@fluff.org>
--
1.6.2.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 2/2] MAINTAINERS: add maintainer for SAMSUNG ARM ARCHITECTURES
2010-06-04 10:36 ` [PATCH 2/2] MAINTAINERS: add maintainer " Kukjin Kim
@ 2010-06-05 2:24 ` Kyungmin Park
2010-06-07 7:58 ` [PATCH] SDHCI: add no hi-speed bit quirk support Kukjin Kim
0 siblings, 1 reply; 3+ messages in thread
From: Kyungmin Park @ 2010-06-05 2:24 UTC (permalink / raw)
To: linux-arm-kernel
Hi Ben,
I'm waiting your comments.
Thank you,
Kyungmin Park
On Fri, Jun 4, 2010 at 7:36 PM, Kukjin Kim <kgene.kim@samsung.com> wrote:
> Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
> ---
> ?MAINTAINERS | ? ?2 ++
> ?1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 1d41149..f4e4c61 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -896,11 +896,13 @@ S: ? ? ? ?Maintained
>
> ?ARM/SAMSUNG ARM ARCHITECTURES
> ?M: ? ? Ben Dooks <ben-linux@fluff.org>
> +M: ? ? Kukjin Kim <kgene.kim@samsung.com>
> ?L: ? ? linux-arm-kernel at lists.infradead.org (moderated for non-subscribers)
> ?W: ? ? http://www.fluff.org/ben/linux/
> ?S: ? ? Maintained
> ?F: ? ? arch/arm/plat-samsung/
> ?F: ? ? arch/arm/plat-s3c24xx/
> +F: ? ? arch/arm/plat-s5p/
>
> ?ARM/S3C2410 ARM ARCHITECTURE
> ?M: ? ? Ben Dooks <ben-linux@fluff.org>
> --
> 1.6.2.5
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] SDHCI: add no hi-speed bit quirk support
2010-06-05 2:24 ` Kyungmin Park
@ 2010-06-07 7:58 ` Kukjin Kim
0 siblings, 0 replies; 3+ messages in thread
From: Kukjin Kim @ 2010-06-07 7:58 UTC (permalink / raw)
To: 'Kyungmin Park'; +Cc: linux-mmc
Kyungmin Park wrote:
>
> Some SDHCI controllr like s5pc110 doesn't have HISPD bit at HOSTCTL
register.
>
> Signed-off-by: Kyungmin Park <kyungmin.park <at> samsung.com>
> ---
> diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
> index c6d1bd8..cba08ce 100644
> --- a/drivers/mmc/host/sdhci.c
> +++ b/drivers/mmc/host/sdhci.c
> @@ -1164,7 +1164,8 @@ static void sdhci_set_ios(struct mmc_host *mmc,
struct mmc_ios *ios)
> else
> ctrl &= ~SDHCI_CTRL_4BITBUS;
>
> - if (ios->timing == MMC_TIMING_SD_HS)
> + if (ios->timing == MMC_TIMING_SD_HS &&
> + !(host->quirks & SDHCI_QUIRK_NO_HISPD_BIT))
host->quirks |= SDHCI_QURIK_NO_HISPD_BIT missed in
drivers/mmc/host/sdhci-s3c.c
> ctrl |= SDHCI_CTRL_HISPD;
> else
> ctrl &= ~SDHCI_CTRL_HISPD;
> diff --git a/drivers/mmc/host/sdhci.h b/drivers/mmc/host/sdhci.h
> index c846813..a78152d 100644
> --- a/drivers/mmc/host/sdhci.h
> +++ b/drivers/mmc/host/sdhci.h
> @@ -240,6 +240,8 @@ struct sdhci_host {
> #define SDHCI_QUIRK_CAP_CLOCK_BASE_BROKEN (1<<25)
> /* Controller cannot support End Attribute in NOP ADMA descriptor */
> #define SDHCI_QUIRK_NO_ENDATTR_IN_NOPDESC (1<<26)
> +/* Controller doesn't have HISPD bit field in HI-SPEED SD card */
> +#define SDHCI_QUIRK_NO_HISPD_BIT (1<<27)
>
> int irq; /* Device IRQ */
> void __iomem * ioaddr; /* Mapped address */
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-06-07 8:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-06-05 4:50 [PATCH] SDHCI: add no hi-speed bit quirk support Kyungmin Park
-- strict thread matches above, loose matches on Subject: below --
2010-06-07 8:02 Kukjin Kim
2010-06-04 10:36 [PATCH 1/2] MAINTAINERS: update files for SAMSUNG ARM ARCHITECTURES Kukjin Kim
2010-06-04 10:36 ` [PATCH 2/2] MAINTAINERS: add maintainer " Kukjin Kim
2010-06-05 2:24 ` Kyungmin Park
2010-06-07 7:58 ` [PATCH] SDHCI: add no hi-speed bit quirk support Kukjin Kim
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.