All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marc Enthus <cxzdes@gmail.com>
To: lmr@redhat.com, mgoldish@redhat.com, autotest@test.kernel.org
Cc: kvm@vger.kernel.org
Subject: [PATCH] KVM-test: kvm.py: Code style fix
Date: Tue, 8 Jun 2010 16:02:24 +0800	[thread overview]
Message-ID: <20100608080224.GA20396@t4.rh> (raw)

From: Marc Enthus <cxzdes@gmail.com>

According to autotest coding style
and http://www.python.org/dev/peps/pep-0008/

use
	if pa_type is not None:
instead of
	if pa_type:

Signed-off-by: Marc Enthus <cxzdes@gmail.com>
---
 client/tests/kvm/kvm_vm.py |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/client/tests/kvm/kvm_vm.py b/client/tests/kvm/kvm_vm.py
index f3ce4d6..0080b15 100755
--- a/client/tests/kvm/kvm_vm.py
+++ b/client/tests/kvm/kvm_vm.py
@@ -516,7 +516,7 @@ class VM:
                                   pa_type)
                     return False
 
-            elif pa_type and pa_type != "no":
+            elif pa_type is not None and pa_type != "no":
                 logging.warn("Unsupported pci_assignable type: %s", pa_type)
 
             # Make qemu command



             reply	other threads:[~2010-06-08  8:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-08  8:02 Marc Enthus [this message]
2010-06-08 17:50 ` [PATCH] KVM-test: kvm.py: Code style fix Michael Goldish
2010-06-08 18:22   ` Lucas Meneghel Rodrigues

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100608080224.GA20396@t4.rh \
    --to=cxzdes@gmail.com \
    --cc=autotest@test.kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=lmr@redhat.com \
    --cc=mgoldish@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.