Re: [PATCH] KVM-test: kvm.py: Code style fix

[Michael Goldish <mgoldish@redhat.com>]

On 06/08/2010 11:02 AM, Marc Enthus wrote:
> From: Marc Enthus <cxzdes@gmail.com>
> 
> According to autotest coding style
> and http://www.python.org/dev/peps/pep-0008/
> 
> use
> 	if pa_type is not None:
> instead of
> 	if pa_type:
> 
> Signed-off-by: Marc Enthus <cxzdes@gmail.com>
> ---
>  client/tests/kvm/kvm_vm.py |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/client/tests/kvm/kvm_vm.py b/client/tests/kvm/kvm_vm.py
> index f3ce4d6..0080b15 100755
> --- a/client/tests/kvm/kvm_vm.py
> +++ b/client/tests/kvm/kvm_vm.py
> @@ -516,7 +516,7 @@ class VM:
>                                    pa_type)
>                      return False
>  
> -            elif pa_type and pa_type != "no":
> +            elif pa_type is not None and pa_type != "no":
>                  logging.warn("Unsupported pci_assignable type: %s", pa_type)
>  
>              # Make qemu command
> 
> 

The condition 'if pa_type' is meant to exclude both None and "".  Both
are possible and both indicate that the user isn't interested in pa_type
at all.  In that case 'if pa_type' conforms to PEP 8 AFAIK.  I'm not
sure about the autotest coding style though.