From: Joel Becker <Joel.Becker@oracle.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Nick Piggin <npiggin@suse.de>, Tao Ma <tao.ma@oracle.com>,
ocfs2-devel@oss.oracle.com, linux-fsdevel@vger.kernel.org
Subject: [Ocfs2-devel] [PATCH] ocfs2: Remove the deprecated inode_setattr.
Date: Wed, 9 Jun 2010 12:53:58 -0700 [thread overview]
Message-ID: <20100609195357.GD21239@mail.oracle.com> (raw)
In-Reply-To: <20100609101434.GA17108@lst.de>
On Wed, Jun 09, 2010 at 12:14:34PM +0200, Christoph Hellwig wrote:
> On Wed, Jun 09, 2010 at 03:12:07AM -0700, Joel Becker wrote:
> > > OK, can you comment that or just open-code the truncate part of
> > > simple_setsize? It should be helpful for example with Christoph's
> > > truncate cleanup work.
> >
> > Just open-code it. The void calls are much nicer than useless
> > return code boilerplate.
>
> Note that if you rebase against vfs.git #for_next simple_setsize is
> replaced with a truncate_setsize that does all the work but the
> inode_newsize_ok check. As I mentioned before please do the work ontop
> of that branch, it does make the ->setattr ATTR_SIZE implementation much
> nicer for the filesystems.
Works for me.
Joel
--
"Glory is fleeting, but obscurity is forever."
- Napoleon Bonaparte
Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127
WARNING: multiple messages have this Message-ID (diff)
From: Joel Becker <Joel.Becker@oracle.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Nick Piggin <npiggin@suse.de>, Tao Ma <tao.ma@oracle.com>,
ocfs2-devel@oss.oracle.com, linux-fsdevel@vger.kernel.org
Subject: Re: [Ocfs2-devel] [PATCH] ocfs2: Remove the deprecated inode_setattr.
Date: Wed, 9 Jun 2010 12:53:58 -0700 [thread overview]
Message-ID: <20100609195357.GD21239@mail.oracle.com> (raw)
In-Reply-To: <20100609101434.GA17108@lst.de>
On Wed, Jun 09, 2010 at 12:14:34PM +0200, Christoph Hellwig wrote:
> On Wed, Jun 09, 2010 at 03:12:07AM -0700, Joel Becker wrote:
> > > OK, can you comment that or just open-code the truncate part of
> > > simple_setsize? It should be helpful for example with Christoph's
> > > truncate cleanup work.
> >
> > Just open-code it. The void calls are much nicer than useless
> > return code boilerplate.
>
> Note that if you rebase against vfs.git #for_next simple_setsize is
> replaced with a truncate_setsize that does all the work but the
> inode_newsize_ok check. As I mentioned before please do the work ontop
> of that branch, it does make the ->setattr ATTR_SIZE implementation much
> nicer for the filesystems.
Works for me.
Joel
--
"Glory is fleeting, but obscurity is forever."
- Napoleon Bonaparte
Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker@oracle.com
Phone: (650) 506-8127
next prev parent reply other threads:[~2010-06-09 19:53 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-09 8:48 [Ocfs2-devel] [PATCH] ocfs2: Remove the deprecated inode_setattr Tao Ma
2010-06-09 9:16 ` Nick Piggin
2010-06-09 9:16 ` [Ocfs2-devel] " Nick Piggin
2010-06-09 9:29 ` Tao Ma
2010-06-09 9:29 ` Tao Ma
2010-06-09 9:38 ` Nick Piggin
2010-06-09 9:38 ` [Ocfs2-devel] " Nick Piggin
2010-06-09 10:12 ` Joel Becker
2010-06-09 10:12 ` Joel Becker
2010-06-09 10:14 ` [Ocfs2-devel] " Christoph Hellwig
2010-06-09 10:14 ` Christoph Hellwig
2010-06-09 19:53 ` Joel Becker [this message]
2010-06-09 19:53 ` [Ocfs2-devel] " Joel Becker
2010-06-09 10:01 ` Christoph Hellwig
2010-06-09 10:01 ` Christoph Hellwig
2010-06-09 13:43 ` [Ocfs2-devel] " Tao Ma
2010-06-09 13:43 ` Tao Ma
2010-06-09 10:08 ` [Ocfs2-devel] " Joel Becker
2010-06-09 10:43 ` Nick Piggin
2010-06-09 10:43 ` [Ocfs2-devel] " Nick Piggin
2010-06-09 13:54 ` Tao Ma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100609195357.GD21239@mail.oracle.com \
--to=joel.becker@oracle.com \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=npiggin@suse.de \
--cc=ocfs2-devel@oss.oracle.com \
--cc=tao.ma@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.