All of lore.kernel.org
 help / color / mirror / Atom feed
From: alex@digriz.org.uk (Alexander Clouter)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] Marvell OpenRD-Ultimate machine support
Date: Wed, 9 Jun 2010 21:39:29 +0100	[thread overview]
Message-ID: <20100609203929.GL7660@chipmunk> (raw)
In-Reply-To: <20100609203720.GK7660@chipmunk>

Hi,

* Alexander Clouter <alex@digriz.org.uk> [2010-06-09 21:37:20+0100]:
>
> >  	kirkwood_ge00_init(&openrd_ge00_data);
> > -	if (machine_is_openrd_client())
> > +	if (machine_is_openrd_client() ||      \__same line
> > +		machine_is_openrd_ultimate())  /
> >  		kirkwood_ge01_init(&openrd_ge01_data);
> > +  <------- REMOVE
> >  	kirkwood_sata_init(&openrd_sata_data);
> >  	kirkwood_sdio_init(&openrd_mvsdio_data);
> >  
> As that 'if()' clause is still less than 77 chars wide:
> ----
> kirkwood_ge00_init(&openrd_ge00_data);
> if (machine_is_openrd_client() || machine_is_openrd_ultimate())
> 	kirkwood_ge01_init(&openrd_ge01_data);
> kirkwood_sata_init(&openrd_sata_data);
> kirkwood_sdio_init(&openrd_mvsdio_data);
> ----
> 
Better still, just make this 'if(!machine_is_openrd_base())'.

Cheers

-- 
Alexander Clouter
.sigmonster says: What this country needs is a good five cent microcomputer.

WARNING: multiple messages have this Message-ID (diff)
From: Alexander Clouter <alex@digriz.org.uk>
To: Dmytro Milinevskyy <milinevskyy@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org,
	Russell King <linux@arm.linux.org.uk>,
	Dhaval Vasa <dhaval.vasa@einfochips.com>,
	Lennert Buytenhek <kernel@wantstofly.org>,
	Nicolas Pitre <nico@fluxnic.net>,
	Simon Guinot <sguinot@lacie.com>,
	Martin Michlmayr <tbm@cyrius.com>,
	Simon Kagstrom <simon.kagstrom@netinsight.net>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Marvell OpenRD-Ultimate machine support
Date: Wed, 9 Jun 2010 21:39:29 +0100	[thread overview]
Message-ID: <20100609203929.GL7660@chipmunk> (raw)
In-Reply-To: <20100609203720.GK7660@chipmunk>

Hi,

* Alexander Clouter <alex@digriz.org.uk> [2010-06-09 21:37:20+0100]:
>
> >  	kirkwood_ge00_init(&openrd_ge00_data);
> > -	if (machine_is_openrd_client())
> > +	if (machine_is_openrd_client() ||      \__same line
> > +		machine_is_openrd_ultimate())  /
> >  		kirkwood_ge01_init(&openrd_ge01_data);
> > +  <------- REMOVE
> >  	kirkwood_sata_init(&openrd_sata_data);
> >  	kirkwood_sdio_init(&openrd_mvsdio_data);
> >  
> As that 'if()' clause is still less than 77 chars wide:
> ----
> kirkwood_ge00_init(&openrd_ge00_data);
> if (machine_is_openrd_client() || machine_is_openrd_ultimate())
> 	kirkwood_ge01_init(&openrd_ge01_data);
> kirkwood_sata_init(&openrd_sata_data);
> kirkwood_sdio_init(&openrd_mvsdio_data);
> ----
> 
Better still, just make this 'if(!machine_is_openrd_base())'.

Cheers

-- 
Alexander Clouter
.sigmonster says: What this country needs is a good five cent microcomputer.

  reply	other threads:[~2010-06-09 20:39 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-09 20:14 [PATCH] Marvell OpenRD-Ultimate machine support Dmytro Milinevskyy
2010-06-09 20:14 ` Dmytro Milinevskyy
2010-06-09 20:37 ` Alexander Clouter
2010-06-09 20:37   ` Alexander Clouter
2010-06-09 20:39   ` Alexander Clouter [this message]
2010-06-09 20:39     ` Alexander Clouter
2010-06-09 20:42     ` Lennert Buytenhek
2010-06-09 20:42       ` Lennert Buytenhek
2010-06-10  1:56       ` Dmytro Milinevskyy
2010-06-10  1:56         ` Dmytro Milinevskyy
  -- strict thread matches above, loose matches on Subject: below --
2010-06-10 19:12 Dmytro Milinevskyy
2010-06-10 19:12 ` Dmytro Milinevskyy
2010-06-12  8:29 ` Lennert Buytenhek
2010-06-12  8:29   ` Lennert Buytenhek
2010-06-10  2:24 Dmytro Milinevskyy
2010-06-10  2:24 ` Dmytro Milinevskyy
2010-06-10  5:50 ` Alexander Clouter
2010-06-10  5:50   ` Alexander Clouter
2010-06-10  6:15   ` Dmytro Milinevskyy
2010-06-10  6:15     ` Dmytro Milinevskyy
2010-06-08 19:47 Dmytro Milinevskyy
2010-06-08 19:47 ` Dmytro Milinevskyy
2010-06-09  7:25 ` Lennert Buytenhek
2010-06-09  7:25   ` Lennert Buytenhek
2010-06-09  7:37   ` Dmytro Milinevskyy
2010-06-09  7:37     ` Dmytro Milinevskyy
2010-06-08 17:24 Dmytro Milinevskyy
2010-06-08 17:24 ` Dmytro Milinevskyy
2010-06-08 17:38 ` Joe Perches
2010-06-08 17:38   ` Joe Perches
2010-06-08 17:45 ` Lennert Buytenhek
2010-06-08 17:45   ` Lennert Buytenhek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100609203929.GL7660@chipmunk \
    --to=alex@digriz.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.