From: ext-phil.2.carmody@nokia.com (Phil Carmody)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/3] ARM: unwind extension
Date: Thu, 10 Jun 2010 17:14:02 +0300 [thread overview]
Message-ID: <20100610141402.GY17639@pcarmody-desktop> (raw)
In-Reply-To: <1275567442-11370-1-git-send-email-ext-phil.2.carmody@nokia.com>
On 03/06/10 14:17 +0200, Carmody Phil.2 (EXT-Ixonos/Helsinki) wrote:
>
> The first two patches are simply preparation for the third, making it
> effectively trivial, even though it's the only one with a concrete
> change in behaviour.
>
> The origins of this patchset are the discovery that unwind and kmemleak
> don't always cooperate well with each other - any allocation within
> an exit or devexit function causes kmemleak to look up symbols that
> aren't in any unwind table. This of course means that all WARN_ONs and
> BUGs will suffer the same fate.
>
> It could certainly be said that with a typical system the linked list
> has grown too large to be practical as a container, and some improvements
> could be made in that direction in the future.
Catalin,
Have you had a chance to look at these yet? The linked-list efficiency
issue I mention in the final paragraph above is a no-brainer; I have a
1-line tweak that improves the real-world efficiency so much that on
average there are only 2 linked list operations rather than (on a 50+
module system) 70. However, that patch is orthogonal to the above set,
so I'll not mix the two.
Phil
WARNING: multiple messages have this Message-ID (diff)
From: Phil Carmody <ext-phil.2.carmody@nokia.com>
To: "linux@arm.linux.org.uk" <linux@arm.linux.org.uk>,
"catalin.marinas@arm.com" <catalin.marinas@arm.com>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/3] ARM: unwind extension
Date: Thu, 10 Jun 2010 17:14:02 +0300 [thread overview]
Message-ID: <20100610141402.GY17639@pcarmody-desktop> (raw)
In-Reply-To: <1275567442-11370-1-git-send-email-ext-phil.2.carmody@nokia.com>
On 03/06/10 14:17 +0200, Carmody Phil.2 (EXT-Ixonos/Helsinki) wrote:
>
> The first two patches are simply preparation for the third, making it
> effectively trivial, even though it's the only one with a concrete
> change in behaviour.
>
> The origins of this patchset are the discovery that unwind and kmemleak
> don't always cooperate well with each other - any allocation within
> an exit or devexit function causes kmemleak to look up symbols that
> aren't in any unwind table. This of course means that all WARN_ONs and
> BUGs will suffer the same fate.
>
> It could certainly be said that with a typical system the linked list
> has grown too large to be practical as a container, and some improvements
> could be made in that direction in the future.
Catalin,
Have you had a chance to look at these yet? The linked-list efficiency
issue I mention in the final paragraph above is a no-brainer; I have a
1-line tweak that improves the real-world efficiency so much that on
average there are only 2 linked list operations rather than (on a 50+
module system) 70. However, that patch is orthogonal to the above set,
so I'll not mix the two.
Phil
next prev parent reply other threads:[~2010-06-10 14:14 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-03 12:17 [PATCH 0/3] ARM: unwind extension Phil Carmody
2010-06-03 12:17 ` Phil Carmody
2010-06-03 12:17 ` [PATCH 1/3] ARM: module - simplify code with temporaries Phil Carmody
2010-06-03 12:17 ` Phil Carmody
2010-06-03 12:17 ` [PATCH 2/3] ARM: module - simplify unwind table handling Phil Carmody
2010-06-03 12:17 ` Phil Carmody
2010-06-03 12:17 ` [PATCH 3/3] ARM: module - additional unwind tables for exit/devexit sections Phil Carmody
2010-06-03 12:17 ` Phil Carmody
2010-06-10 14:48 ` Catalin Marinas
2010-06-10 14:48 ` Catalin Marinas
2010-06-10 14:43 ` [PATCH 2/3] ARM: module - simplify unwind table handling Catalin Marinas
2010-06-10 14:43 ` Catalin Marinas
2010-06-24 9:05 ` Russell King - ARM Linux
2010-06-24 9:05 ` Russell King - ARM Linux
2010-06-24 9:08 ` Catalin Marinas
2010-06-24 9:08 ` Catalin Marinas
2010-06-10 14:42 ` [PATCH 1/3] ARM: module - simplify code with temporaries Catalin Marinas
2010-06-10 14:42 ` Catalin Marinas
2010-06-10 14:14 ` Phil Carmody [this message]
2010-06-10 14:14 ` [PATCH 0/3] ARM: unwind extension Phil Carmody
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100610141402.GY17639@pcarmody-desktop \
--to=ext-phil.2.carmody@nokia.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.