From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Kyungmin Park <kmpark@infradead.org>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>,
Liam Girdwood <lrg@slimlogic.co.uk>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers: regulator: add Maxim 8998 driver
Date: Fri, 11 Jun 2010 14:00:23 +0100 [thread overview]
Message-ID: <20100611130022.GF12436@sirena.org.uk> (raw)
In-Reply-To: <AANLkTikbTtpMe_k97khIS1Mg5m7AaEbX0sa7URrJ2TkS@mail.gmail.com>
On Fri, Jun 11, 2010 at 09:48:58PM +0900, Kyungmin Park wrote:
> On Fri, Jun 11, 2010 at 7:58 PM, Mark Brown
> > On Fri, Jun 11, 2010 at 09:02:45AM +0200, Marek Szyprowski wrote:
> >> +static irqreturn_t max8998_ono_irq(int irq, void *data)
> >> +{
> >> + ? ? return IRQ_HANDLED;
> >> +}
> > This needs at least a comment explaining why you don't need to do
> > anything for the interrupt.
> We just remove it. it's unused function actually.
I suspect it may be required for the wake IRQ functionality you're using
but ICBW.
next prev parent reply other threads:[~2010-06-11 13:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-11 7:02 [PATCH] drivers: regulator: add Maxim 8998 driver Marek Szyprowski
2010-06-11 10:58 ` Mark Brown
2010-06-11 12:48 ` Kyungmin Park
2010-06-11 13:00 ` Mark Brown [this message]
2010-06-11 12:55 ` Marek Szyprowski
2010-06-11 13:02 ` Mark Brown
2010-06-11 13:08 ` Marek Szyprowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100611130022.GF12436@sirena.org.uk \
--to=broonie@opensource.wolfsonmicro.com \
--cc=kmpark@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=m.szyprowski@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.