From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: "'Liam Girdwood'" <lrg@slimlogic.co.uk>,
linux-kernel@vger.kernel.org, kyungmin.park@samsung.com
Subject: Re: [PATCH] drivers: regulator: add Maxim 8998 driver
Date: Fri, 11 Jun 2010 14:02:36 +0100 [thread overview]
Message-ID: <20100611130236.GA4650@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <007201cb0965$542b6cb0$fc824610$%szyprowski@samsung.com>
On Fri, Jun 11, 2010 at 02:55:07PM +0200, Marek Szyprowski wrote:
> On Friday, June 11, 2010 12:58 PM Mark Brown wrote:
> > A few things in the code make it look like the driver should be using
> > the MFD framework - there's references in here for things like a battery
> > charger which should be being supported via the power subsystem, for
> > example.
> You are right, this chip is really complicated and should work with more
> than one kernel subsystem. However in this initial version of the driver
> we tried to make it as simple as possible. It can be converted to MFD
> framework later, but if you want we can prepare this driver as MFD from
> the beginning.
It makes life a lot easier to start off with the MFD, even if you only
add a single function driver initially. Otherwise you end up with cross
tree hassle trying to deal with the transiton later on.
next prev parent reply other threads:[~2010-06-11 13:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-11 7:02 [PATCH] drivers: regulator: add Maxim 8998 driver Marek Szyprowski
2010-06-11 10:58 ` Mark Brown
2010-06-11 12:48 ` Kyungmin Park
2010-06-11 13:00 ` Mark Brown
2010-06-11 12:55 ` Marek Szyprowski
2010-06-11 13:02 ` Mark Brown [this message]
2010-06-11 13:08 ` Marek Szyprowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100611130236.GA4650@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=m.szyprowski@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.