From: Baruch Siach <baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org>
To: Wan ZongShun <mcuos.com-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Ben Dooks <ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>,
linux-arm-kernel
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
"Jean Delvare (PC drivers,
core)" <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
Subject: Re: [PATCH 1/2] NUC900: Add i2c0 driver support for NUC900
Date: Tue, 15 Jun 2010 08:19:05 +0300 [thread overview]
Message-ID: <20100615051905.GD3233@jasper.tkos.co.il> (raw)
In-Reply-To: <4C15143C.1020603-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Hi Wan,
On Mon, Jun 14, 2010 at 01:24:12AM +0800, Wan ZongShun wrote:
> This patch is to add i2c0 driver support for NUC900.
>
> Signed-off-by: Wan ZongShun <mcuos.com-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>
> ---
[snip]
> + pdata->get_clock(NULL, NULL, &apbclk_khz);
Why not use clk_get_rate() for this?
baruch
--
~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org - tel: +972.2.679.5364, http://www.tkos.co.il -
WARNING: multiple messages have this Message-ID (diff)
From: baruch@tkos.co.il (Baruch Siach)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] NUC900: Add i2c0 driver support for NUC900
Date: Tue, 15 Jun 2010 08:19:05 +0300 [thread overview]
Message-ID: <20100615051905.GD3233@jasper.tkos.co.il> (raw)
In-Reply-To: <4C15143C.1020603@gmail.com>
Hi Wan,
On Mon, Jun 14, 2010 at 01:24:12AM +0800, Wan ZongShun wrote:
> This patch is to add i2c0 driver support for NUC900.
>
> Signed-off-by: Wan ZongShun <mcuos.com@gmail.com>
>
> ---
[snip]
> + pdata->get_clock(NULL, NULL, &apbclk_khz);
Why not use clk_get_rate() for this?
baruch
--
~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
next prev parent reply other threads:[~2010-06-15 5:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-13 17:24 [PATCH 1/2] NUC900: Add i2c0 driver support for NUC900 Wan ZongShun
2010-06-13 17:24 ` Wan ZongShun
[not found] ` <4C15143C.1020603-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2010-06-15 5:19 ` Baruch Siach [this message]
2010-06-15 5:19 ` Baruch Siach
[not found] ` <20100615051905.GD3233-X57xyCW21FZ5l4KbKkTfamZHpeb/A1Y/@public.gmane.org>
2010-06-16 0:05 ` Marek Vasut
2010-06-16 0:05 ` Marek Vasut
2010-06-20 22:38 ` Ben Dooks
2010-06-20 22:38 ` Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100615051905.GD3233@jasper.tkos.co.il \
--to=baruch-nswtu9s1w3p6gbpvegmw2w@public.gmane.org \
--cc=ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org \
--cc=khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mcuos.com-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.