From: "John W. Linville" <linville@tuxdriver.com>
To: Vivek Natarajan <vivek.natraj@gmail.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] ath9k: Modify LED blinking pattern during wifi activity.
Date: Wed, 16 Jun 2010 09:38:24 -0400 [thread overview]
Message-ID: <20100616133824.GA2404@tuxdriver.com> (raw)
In-Reply-To: <AANLkTimprPdviZPX26qcH-uM8FyNY09JEH3kRvqwDi-S@mail.gmail.com>
On Wed, Jun 16, 2010 at 11:21:27AM +0530, Vivek Natarajan wrote:
> On Wed, Jun 16, 2010 at 1:21 AM, John W. Linville
> <linville@tuxdriver.com> wrote:
> > On Tue, Jun 15, 2010 at 10:50:17AM +0530, Vivek Natarajan wrote:
> >> Some vendors require the LED to be ON always irrespective of any
> >> radio activity. Introducing a module parameter to enable this,
> >> so that one can choose between always on or led blink during
> >> activity.
> >>
> >> Signed-off-by: Vivek Natarajan <vnatarajan@atheros.com>
> >
> > Any particular reason the always-on behaviour is the default?
>
> There is no specific reason for setting it as default. It is only that
> some customers preferred the led to be always on instead of blinking.
Well it is just that as I read the patch, you are changing the
behaviour for everyone rather than simply giving a new option for
those that don't like it that way it already is.
Look, I don't particular care about the behaviour. Blinking w/
activity makes sense to me. But I also get to read the seemingly
endless, whining complaints about how the blinking is distracting for
laptop users. I just would rather not add another endless stream of
complaints that say "my wifi LED used to blink w/ activity, now it
doesn't -- fix it!"
Perhaps we could standardize this somehow? Anyone care to make
a proposal?
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2010-06-16 13:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-15 5:20 [PATCH] ath9k: Modify LED blinking pattern during wifi activity Vivek Natarajan
2010-06-15 7:32 ` Johannes Berg
2010-06-22 6:38 ` Vasanthakumar Thiagarajan
2010-06-22 7:01 ` Johannes Berg
2010-06-22 9:30 ` Vasanthakumar Thiagarajan
2010-06-15 19:51 ` John W. Linville
2010-06-16 5:51 ` Vivek Natarajan
2010-06-16 13:38 ` John W. Linville [this message]
2010-06-22 5:45 ` Senthil Balasubramanian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100616133824.GA2404@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=linux-wireless@vger.kernel.org \
--cc=vivek.natraj@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.