All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vasanthakumar Thiagarajan <vasanth@atheros.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Vivek Natarajan <Vivek.Natarajan@Atheros.com>,
	"linville@tuxdriver.com" <linville@tuxdriver.com>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] ath9k: Modify LED blinking pattern during wifi activity.
Date: Tue, 22 Jun 2010 12:08:00 +0530	[thread overview]
Message-ID: <20100622063800.GC9292@vasanth-laptop> (raw)
In-Reply-To: <1276587140.3648.6.camel@jlt3.sipsolutions.net>

On Tue, Jun 15, 2010 at 01:02:20PM +0530, Johannes Berg wrote:
> On Tue, 2010-06-15 at 10:50 +0530, Vivek Natarajan wrote:
> 
> >  	case LED_FULL:
> 
> I wonder if you can just use different triggers which may be easier?
> Look at what I suggested earlier for integrating the LEDs with iwlwifi:
> 
> http://thread.gmane.org/gmane.linux.kernel.wireless.general/51218/focus=51520

Sorry for a late reply. LED implementation with ath9k is completely
manual, fully controlled by driver (We have to set/clear a particular
gpio pin to turn on/off the LED every time). on/off period during blink
is based on the number of brightness_set() on tx/rx led trigger. Do
you think your suggested implementation would help in this case too? 

thanks,

Vasanth

  reply	other threads:[~2010-06-22  6:38 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-15  5:20 [PATCH] ath9k: Modify LED blinking pattern during wifi activity Vivek Natarajan
2010-06-15  7:32 ` Johannes Berg
2010-06-22  6:38   ` Vasanthakumar Thiagarajan [this message]
2010-06-22  7:01     ` Johannes Berg
2010-06-22  9:30       ` Vasanthakumar Thiagarajan
2010-06-15 19:51 ` John W. Linville
2010-06-16  5:51   ` Vivek Natarajan
2010-06-16 13:38     ` John W. Linville
2010-06-22  5:45       ` Senthil Balasubramanian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100622063800.GC9292@vasanth-laptop \
    --to=vasanth@atheros.com \
    --cc=Vivek.Natarajan@Atheros.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.