[Qemu-devel] Q35 qemu repository?

[Qemu-devel] Q35 qemu repository?

[Matthew Garrett]

Hi there,

I'm currently doing some work on tidying up Linux's PCIe ASPM support, 
and one thing that would be useful would be to be able to instrument 
reads and writes made by Windows to PCIe space. I noticed that you've 
been working on Q35 support for qemu - is there a public repository 
which contains your patch sets?

Thank you,
-- 
Matthew Garrett | mjg59@srcf.ucam.org

Re: [Qemu-devel] Q35 qemu repository?

[Isaku Yamahata]

Hi, thank you for interested in q35 stuff.
I set up the repository. It contains the snapshot of my local repo.

git clone http://people.valinux.co.jp/~yamahata/qemu/q35/qemu
git clone http://people.valinux.co.jp/~yamahata/qemu/q35/seabios
git clone http://people.valinux.co.jp/~yamahata/qemu/q35/vgabios

Note that modified seabios and vgabios should be used, and
ACPI DSDT for q35 must be used.

Example:
qemu-system-x86_64 ... -M pc_q35 -acpitable 'load_header,data=roms/seabios/src/q35-acpi-dsdt.aml

My interest is mainly pcie aer and native hot plug, so power management
is out of my current scope. So I'm not sure my repo is useful
for your purpose or not.

thanks,

On Mon, Jun 14, 2010 at 02:56:19PM +0100, Matthew Garrett wrote:
> Hi there,
> 
> I'm currently doing some work on tidying up Linux's PCIe ASPM support, 
> and one thing that would be useful would be to be able to instrument 
> reads and writes made by Windows to PCIe space. I noticed that you've 
> been working on Q35 support for qemu - is there a public repository 
> which contains your patch sets?
> 
> Thank you,
> -- 
> Matthew Garrett | mjg59@srcf.ucam.org
> 

-- 
yamahata

Re: [Qemu-devel] Q35 qemu repository?

[Matthew Garrett]

On Wed, Jun 16, 2010 at 11:44:15AM +0900, Isaku Yamahata wrote:
> Hi, thank you for interested in q35 stuff.
> I set up the repository. It contains the snapshot of my local repo.
> 
> git clone http://people.valinux.co.jp/~yamahata/qemu/q35/qemu
> git clone http://people.valinux.co.jp/~yamahata/qemu/q35/seabios
> git clone http://people.valinux.co.jp/~yamahata/qemu/q35/vgabios

Thanks for this - however, Vista gives me an ACPI error on boot (stop 
0x000000a5, 0x0000000d, which indicates that there's a malformed or 
undefined ACPI device). I don't suppose you have any idea what the 
problem here may be? Linux boots without complaint.

I also have a small patch that fixes some build warnings in the qemu 
build. I'll send that separately.

-- 
Matthew Garrett | mjg59@srcf.ucam.org

Re: [Qemu-devel] Q35 qemu repository?

[Matthew Garrett]

On Wed, Jun 16, 2010 at 04:42:10PM +0100, Matthew Garrett wrote:

> Thanks for this - however, Vista gives me an ACPI error on boot (stop 
> 0x000000a5, 0x0000000d, which indicates that there's a malformed or 
> undefined ACPI device). I don't suppose you have any idea what the 
> problem here may be? Linux boots without complaint.

Fixed with the following patch. Any devices with duplicate _HIDs require 
_UIDs.

diff --git a/src/q35-acpi-dsdt.dsl b/src/q35-acpi-dsdt.dsl
index ad05c7a..4697527 100644
--- a/src/q35-acpi-dsdt.dsl
+++ b/src/q35-acpi-dsdt.dsl
@@ -45,6 +45,7 @@ DefinitionBlock (
         Device (DBG0)
         {
             Name(_HID, EISAID("PNP0C02"))
+            Name(_UID, 0)
             Name(_CRS, ResourceTemplate() {
                 IO (Decode16, 0xb080, 0xb080, 0x00, 0x04)
             })
@@ -71,6 +72,7 @@ DefinitionBlock (
         Device(HP0)
         {
             Name(_HID, EISAID("PNP0C02"))
+            Name(_UID, 0x01)
             Name(_CRS, ResourceTemplate() {
                 IO (Decode16, 0xae00, 0xae00, 0x00, 0x0C)
                 IO (Decode16, 0xae0c, 0xae0c, 0x00, 0x01)

-- 
Matthew Garrett | mjg59@srcf.ucam.org

Re: [Qemu-devel] Q35 qemu repository?

[Isaku Yamahata]

Thanks for the patch.
Does vista boot with the patch eventually?

On Wed, Jun 16, 2010 at 06:33:15PM +0100, Matthew Garrett wrote:
> On Wed, Jun 16, 2010 at 04:42:10PM +0100, Matthew Garrett wrote:
> 
> > Thanks for this - however, Vista gives me an ACPI error on boot (stop 
> > 0x000000a5, 0x0000000d, which indicates that there's a malformed or 
> > undefined ACPI device). I don't suppose you have any idea what the 
> > problem here may be? Linux boots without complaint.
> 
> Fixed with the following patch. Any devices with duplicate _HIDs require 
> _UIDs.
> 
> diff --git a/src/q35-acpi-dsdt.dsl b/src/q35-acpi-dsdt.dsl
> index ad05c7a..4697527 100644
> --- a/src/q35-acpi-dsdt.dsl
> +++ b/src/q35-acpi-dsdt.dsl
> @@ -45,6 +45,7 @@ DefinitionBlock (
>          Device (DBG0)
>          {
>              Name(_HID, EISAID("PNP0C02"))
> +            Name(_UID, 0)
>              Name(_CRS, ResourceTemplate() {
>                  IO (Decode16, 0xb080, 0xb080, 0x00, 0x04)
>              })
> @@ -71,6 +72,7 @@ DefinitionBlock (
>          Device(HP0)
>          {
>              Name(_HID, EISAID("PNP0C02"))
> +            Name(_UID, 0x01)
>              Name(_CRS, ResourceTemplate() {
>                  IO (Decode16, 0xae00, 0xae00, 0x00, 0x0C)
>                  IO (Decode16, 0xae0c, 0xae0c, 0x00, 0x01)
> 
> -- 
> Matthew Garrett | mjg59@srcf.ucam.org
> 

-- 
yamahata

Re: [Qemu-devel] Q35 qemu repository?

[Matthew Garrett]

On Thu, Jun 17, 2010 at 04:48:09PM +0900, Isaku Yamahata wrote:
> Thanks for the patch.
> Does vista boot with the patch eventually?

Vista boots, but is unable to allocate resources for the pcie root 
ports. I'm looking into that.

-- 
Matthew Garrett | mjg59@srcf.ucam.org

Re: [Qemu-devel] Q35 qemu repository?

[Matthew Garrett]

On Thu, Jun 17, 2010 at 04:48:09PM +0900, Isaku Yamahata wrote:
> Thanks for the patch.
> Does vista boot with the patch eventually?

As I mentioned before, Windows boots but PCIe root ports fail with a 
resource allocation error. Digging into it, it looks like the issue is 
with IRQ assignment. I'm not sure quite what's going wrong, but I'll 
look further.

-- 
Matthew Garrett | mjg59@srcf.ucam.org