From: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
To: Alan Cox <alan-qBU/x9rampVanCEyBjwyrvXRex20P6io@public.gmane.org>
Cc: Jonathan Cameron <jic23-KWPb1pKIrIJaa/9Udqfwiw@public.gmane.org>,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] hmc6352: Add driver for the HMC6352 compass
Date: Thu, 17 Jun 2010 17:56:50 +0200 [thread overview]
Message-ID: <20100617175650.482e098f@hyperion.delvare> (raw)
In-Reply-To: <20100617161754.39bd116e-qBU/x9rampVanCEyBjwyrvXRex20P6io@public.gmane.org>
On Thu, 17 Jun 2010 16:17:54 +0100, Alan Cox wrote:
> > These functions are supposed to return count on success. Instead, you
> > are returning 1.
>
> Ah yes - I only tested with 1 byte sized I/O.
Good.
> Fixed - do you want this to go via the I2C tree ?
No.
--
Jean Delvare
WARNING: multiple messages have this Message-ID (diff)
From: Jean Delvare <khali@linux-fr.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Jonathan Cameron <jic23@cam.ac.uk>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hmc6352: Add driver for the HMC6352 compass
Date: Thu, 17 Jun 2010 17:56:50 +0200 [thread overview]
Message-ID: <20100617175650.482e098f@hyperion.delvare> (raw)
In-Reply-To: <20100617161754.39bd116e@lxorguk.ukuu.org.uk>
On Thu, 17 Jun 2010 16:17:54 +0100, Alan Cox wrote:
> > These functions are supposed to return count on success. Instead, you
> > are returning 1.
>
> Ah yes - I only tested with 1 byte sized I/O.
Good.
> Fixed - do you want this to go via the I2C tree ?
No.
--
Jean Delvare
next prev parent reply other threads:[~2010-06-17 15:56 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-16 12:16 [PATCH] hmc6352: Add driver for the HMC6352 compass Alan Cox
2010-06-16 12:16 ` Alan Cox
[not found] ` <20100616121534.26294.12540.stgit-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2010-06-16 12:43 ` Oliver Neukum
2010-06-16 12:43 ` Oliver Neukum
[not found] ` <201006161443.45375.oneukum-l3A5Bk7waGM@public.gmane.org>
2010-06-17 11:20 ` Alan Cox
2010-06-17 11:20 ` Alan Cox
[not found] ` <20100617122048.142def43-qBU/x9rampVanCEyBjwyrvXRex20P6io@public.gmane.org>
2010-06-17 12:26 ` Oliver Neukum
2010-06-17 12:26 ` Oliver Neukum
[not found] ` <201006171426.08442.oneukum-l3A5Bk7waGM@public.gmane.org>
2010-06-17 12:46 ` Alan Cox
2010-06-17 12:46 ` Alan Cox
2010-06-16 13:10 ` Jean Delvare
2010-06-16 13:10 ` Jean Delvare
[not found] ` <20100616151056.181234b0-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2010-06-17 11:50 ` Alan Cox
2010-06-17 11:50 ` Alan Cox
[not found] ` <20100617125056.6d648ee7-qBU/x9rampVanCEyBjwyrvXRex20P6io@public.gmane.org>
2010-06-17 12:19 ` Jonathan Cameron
2010-06-17 12:19 ` Jonathan Cameron
[not found] ` <4C1A12C6.6070704-KWPb1pKIrIJaa/9Udqfwiw@public.gmane.org>
2010-06-17 13:14 ` Alan Cox
2010-06-17 13:14 ` Alan Cox
[not found] ` <20100617141440.030f1de9-qBU/x9rampVanCEyBjwyrvXRex20P6io@public.gmane.org>
2010-06-17 14:52 ` Jean Delvare
2010-06-17 14:52 ` Jean Delvare
[not found] ` <20100617165250.5986fbf7-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2010-06-17 15:17 ` Alan Cox
2010-06-17 15:17 ` Alan Cox
[not found] ` <20100617161754.39bd116e-qBU/x9rampVanCEyBjwyrvXRex20P6io@public.gmane.org>
2010-06-17 15:56 ` Jean Delvare [this message]
2010-06-17 15:56 ` Jean Delvare
2010-06-16 14:46 ` Jonathan Cameron
[not found] ` <4C18E3B8.7020308-KWPb1pKIrIJaa/9Udqfwiw@public.gmane.org>
2010-06-17 11:34 ` Alan Cox
2010-06-17 11:34 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100617175650.482e098f@hyperion.delvare \
--to=khali-puyad+kwke1g9huczpvpmw@public.gmane.org \
--cc=alan-qBU/x9rampVanCEyBjwyrvXRex20P6io@public.gmane.org \
--cc=jic23-KWPb1pKIrIJaa/9Udqfwiw@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.