[PATCH] Enabling PDP Context support in atmodem.

[PATCH] Enabling PDP Context support in atmodem.

[Arun Ravindran]

[-- Attachment #1: Type: text/plain, Size: 1397 bytes --]

From d30d8658767de97b0ffb45697616604fb1576741 Mon Sep 17 00:00:00 2001
From: arun <arunlee@gmail.com>
Date: Thu, 17 Jun 2010 21:42:00 +0300
Subject: [PATCH] Enabling PDP Context support in atmodem.

---
 plugins/atgen.c |    9 +++++++++
 1 files changed, 9 insertions(+), 0 deletions(-)

diff --git a/plugins/atgen.c b/plugins/atgen.c
index 4e9c5e7..f3757fb 100644
--- a/plugins/atgen.c
+++ b/plugins/atgen.c
@@ -50,6 +50,8 @@
 #include <ofono/voicecall.h>

 #include <drivers/atmodem/sim-poll.h>
+#include <ofono/gprs.h>
+#include <ofono/gprs-context.h>

 static const char *tty_opts[] = {
     "Baud",
@@ -175,6 +177,8 @@ static void atgen_post_sim(struct ofono_modem *modem)
 {
     GAtChat *chat = ofono_modem_get_data(modem);
     struct ofono_message_waiting *mw;
+    struct ofono_gprs *gprs;
+    struct ofono_gprs_context *gc;

     DBG("%p", modem);

@@ -187,6 +191,11 @@ static void atgen_post_sim(struct ofono_modem *modem)
     ofono_ssn_create(modem, 0, "atmodem", chat);
     ofono_sms_create(modem, 0, "atmodem", chat);
     ofono_phonebook_create(modem, 0, "atmodem", chat);
+    gprs = ofono_gprs_create(modem,0, "atmodem", chat);
+    gc = ofono_gprs_context_create(modem, 0, "atmodem", chat);
+
+    if (gprs && gc)
+        ofono_gprs_add_context(gprs, gc);

     mw = ofono_message_waiting_create(modem);
     if (mw)
-- 
1.6.3.3

[-- Attachment #2: attachment.html --]
[-- Type: text/html, Size: 1660 bytes --]

Re: [PATCH] Enabling PDP Context support in atmodem.

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 1266 bytes --]

Hi Arun,

> From d30d8658767de97b0ffb45697616604fb1576741 Mon Sep 17 00:00:00 2001
> From: arun <arunlee@gmail.com>
> Date: Thu, 17 Jun 2010 21:42:00 +0300
> Subject: [PATCH] Enabling PDP Context support in atmodem.
> 
> ---
>  plugins/atgen.c |    9 +++++++++
>  1 files changed, 9 insertions(+), 0 deletions(-)
> 

Your patch looks good, however it seems there's some extra junk appended at 
the end of the patch.  Git is getting confused and cannot apply it.  Please 
rebase and resubmit:

denkenz(a)localhost ~/ofono-master $ git am ~/merge/\[PATCH\]\ Enabling\ PDP\ 
Context\ support\ in\ atmodem..mbox 
Applying: Enabling PDP Context support in atmodem.
fatal: patch fragment without header at line 46: @@ -50,6 +50,8 
@@<br>�#include &lt;ofono/voicecall.h&gt;<br>�<br>�#include 
&lt;drivers/atmodem/sim-poll.h&gt;<br>+#include 
&lt;ofono/gprs.h&gt;<br>+#include &lt;ofono/gprs-context.h&gt;<br>�<br>�static 
const char *tty_opts[] = {<br>
Patch failed at 0001 Enabling PDP Context support in atmodem.
When you have resolved this problem run "git am --resolved".
If you would prefer to skip this patch, instead run "git am --skip".
To restore the original branch and stop patching run "git am --abort".

Thanks,
-Denis

Re: [PATCH] Enabling PDP Context support in atmodem.

[Arun Ravindran]

[-- Attachment #1: Type: text/plain, Size: 1390 bytes --]

From b3ad9e14d7cfbe3bd7375cfb56bca3d4f3549585 Mon Sep 17 00:00:00 2001
From: Arun Ravindran <arunlee@gmail.com>
Date: Fri, 18 Jun 2010 23:12:12 +0300
Subject: [PATCH] Enabling PDP Context support in atmodem.

---
 plugins/atgen.c |    9 +++++++++
 1 files changed, 9 insertions(+), 0 deletions(-)

diff --git a/plugins/atgen.c b/plugins/atgen.c
index 4e9c5e7..a6eee60 100644
--- a/plugins/atgen.c
+++ b/plugins/atgen.c
@@ -51,6 +51,9 @@

 #include <drivers/atmodem/sim-poll.h>

+#include <ofono/gprs.h>
+#include <ofono/gprs-context.h>
+
 static const char *tty_opts[] = {
     "Baud",
     "Read",
@@ -175,6 +178,8 @@ static void atgen_post_sim(struct ofono_modem *modem)
 {
     GAtChat *chat = ofono_modem_get_data(modem);
     struct ofono_message_waiting *mw;
+    struct ofono_gprs *gprs;
+    struct ofono_gprs_context *gc;

     DBG("%p", modem);

@@ -187,6 +192,10 @@ static void atgen_post_sim(struct ofono_modem *modem)
     ofono_ssn_create(modem, 0, "atmodem", chat);
     ofono_sms_create(modem, 0, "atmodem", chat);
     ofono_phonebook_create(modem, 0, "atmodem", chat);
+    gprs = ofono_gprs_create(modem,0, "atmodem", chat);
+    gc = ofono_gprs_context_create(modem, 0, "atmodem", chat);
+    if (gprs && gc)
+        ofono_gprs_add_context(gprs, gc);

     mw = ofono_message_waiting_create(modem);
     if (mw)
-- 
1.6.3.3

[-- Attachment #2: attachment.html --]
[-- Type: text/html, Size: 1666 bytes --]