From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
To: Gui Jianfeng <guijianfeng@cn.fujitsu.com>
Cc: Adam Schrotenboer <adam@tabris.net>,
mingo@elte.hu,
linux kernel mailing list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] perf: excluding "." and ".." directories when calculating tids.
Date: Fri, 18 Jun 2010 11:40:17 -0300 [thread overview]
Message-ID: <20100618144017.GA4628@ghostprotocols.net> (raw)
In-Reply-To: <4C199267.4070109@cn.fujitsu.com>
Em Thu, Jun 17, 2010 at 11:11:35AM +0800, Gui Jianfeng escreveu:
> Adam Schrotenboer wrote:
> > On 06/15/2010 10:21 PM, Gui Jianfeng wrote:
> >> Introduce a filter function to skip "." and ".." directories when calculating
> >> tid number.
> >>
> >> +/* Skip "." and ".." directories */
> >> +static int filter(const struct dirent *dir)
> >> +{
> >> + if (dir->d_name[0] == '.')
> >> + return 0;
> >> + else
> >> + return 1;
> >
> > Is this safe? Can you _never_ have a d_name with a leading dot, like '
> > .hidden' ??
> > Admittedly I don't think it happens in the current procfs, but I'd want
> > to be careful regardless.
>
> Actually, we only care the numeral directories. So, even if there's a ".hidden",
> it's fine to filter out this directory. Just keep things simple here.
Agreed, applying to perf/core, thanks,
- Arnaldo
next prev parent reply other threads:[~2010-06-18 14:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-15 8:58 [PATCH] perf: excluding "." and ".." directories when calculating tids Gui Jianfeng
2010-06-15 9:33 ` Gui Jianfeng
2010-06-16 5:21 ` Gui Jianfeng
2010-06-16 16:35 ` Adam Schrotenboer
2010-06-17 3:11 ` Gui Jianfeng
2010-06-18 14:40 ` Arnaldo Carvalho de Melo [this message]
2010-07-03 13:57 ` [tip:perf/urgent] perf tools: Fix find tids routine by excluding "." and ".." tip-bot for Gui Jianfeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100618144017.GA4628@ghostprotocols.net \
--to=acme@ghostprotocols.net \
--cc=adam@tabris.net \
--cc=guijianfeng@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.