All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gui Jianfeng <guijianfeng@cn.fujitsu.com>
To: mingo@elte.hu
Cc: linux kernel mailing list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] perf: excluding "." and ".." directories when calculating tids.
Date: Tue, 15 Jun 2010 17:33:10 +0800	[thread overview]
Message-ID: <4C1748D6.1020007@cn.fujitsu.com> (raw)
In-Reply-To: <4C1740B1.9070806@cn.fujitsu.com>

Gui Jianfeng wrote:
> excluding "." and ".." directories when calculating tids.

Please ignore this one, will post an updated version.

Thanks,
Gui

> 
> Signed-off-by: Gui Jianfeng <guijianfeng@cn.fujitsu.com>
> ---
>  tools/perf/util/thread.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/tools/perf/util/thread.c b/tools/perf/util/thread.c
> index 1f7ecd4..4f71d1c 100644
> --- a/tools/perf/util/thread.c
> +++ b/tools/perf/util/thread.c
> @@ -17,6 +17,8 @@ int find_all_tid(int pid, pid_t ** all_tid)
>  
>  	sprintf(name, "/proc/%d/task", pid);
>  	items = scandir(name, &namelist, NULL, NULL);
> +	/* Excluding "." and ".." directories! */
> +	items -= 2;
>  	if (items <= 0)
>                  return -ENOENT;
>  	*all_tid = malloc(sizeof(pid_t) * items);

  reply	other threads:[~2010-06-15  9:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-15  8:58 [PATCH] perf: excluding "." and ".." directories when calculating tids Gui Jianfeng
2010-06-15  9:33 ` Gui Jianfeng [this message]
2010-06-16  5:21   ` Gui Jianfeng
2010-06-16 16:35     ` Adam Schrotenboer
2010-06-17  3:11       ` Gui Jianfeng
2010-06-18 14:40         ` Arnaldo Carvalho de Melo
2010-07-03 13:57     ` [tip:perf/urgent] perf tools: Fix find tids routine by excluding "." and ".." tip-bot for Gui Jianfeng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C1748D6.1020007@cn.fujitsu.com \
    --to=guijianfeng@cn.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.