* [PATCH] ppp: Fix leak in pppcp_send_protocol_reject
@ 2010-06-21 9:25 Zhenhua Zhang
2010-06-21 14:22 ` Denis Kenzior
0 siblings, 1 reply; 2+ messages in thread
From: Zhenhua Zhang @ 2010-06-21 9:25 UTC (permalink / raw)
To: ofono
[-- Attachment #1: Type: text/plain, Size: 493 bytes --]
Free the reject pppcp packet after ppp_transmit.
---
gatchat/ppp_cp.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/gatchat/ppp_cp.c b/gatchat/ppp_cp.c
index bade6bb..b0a18aa 100644
--- a/gatchat/ppp_cp.c
+++ b/gatchat/ppp_cp.c
@@ -938,6 +938,8 @@ void pppcp_send_protocol_reject(struct pppcp_data *data,
ppp_transmit(data->ppp, pppcp_to_ppp_packet(packet),
ntohs(packet->length));
+
+ pppcp_packet_free(packet);
}
/*
--
1.6.3.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ppp: Fix leak in pppcp_send_protocol_reject
2010-06-21 9:25 [PATCH] ppp: Fix leak in pppcp_send_protocol_reject Zhenhua Zhang
@ 2010-06-21 14:22 ` Denis Kenzior
0 siblings, 0 replies; 2+ messages in thread
From: Denis Kenzior @ 2010-06-21 14:22 UTC (permalink / raw)
To: ofono
[-- Attachment #1: Type: text/plain, Size: 230 bytes --]
Hi Zhenhua,
> Free the reject pppcp packet after ppp_transmit.
> ---
> gatchat/ppp_cp.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
Good catch. Patch has been applied, thanks.
Regards,
-Denis
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-06-21 14:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-06-21 9:25 [PATCH] ppp: Fix leak in pppcp_send_protocol_reject Zhenhua Zhang
2010-06-21 14:22 ` Denis Kenzior
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.