All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: "Eduard - Gabriel Munteanu" <eduard.munteanu@linux360.ro>,
	kvm@vger.kernel.org, joro@8bytes.org
Subject: Re: [Qemu-devel] [RFC] Getting specific device from qdev structs
Date: Mon, 21 Jun 2010 15:07:13 +0100	[thread overview]
Message-ID: <201006211507.13975.paul@codesourcery.com> (raw)
In-Reply-To: <20100621134858.GA8275@localhost>

> So I've been looking for a way to obtain things like a PCIDevice from a
> more generic structure (say from hw/qdev.h),

If you're having to figure out what kind of a device you have then I think 
you're already doing something else wrong. I'd expect the bits of code that 
needs to identify devices to be inherently bus specific.

If you've got some sort of on-cpu IOMMU which is asking "did this come from an 
ISA device, or a PCI device?", then I suspect you've got your abstraction 
layers wrong. This should already have been handled by the pci/isa to cpu 
bridge.

Paul

WARNING: multiple messages have this Message-ID (diff)
From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: joro@8bytes.org, kvm@vger.kernel.org,
	Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro>
Subject: Re: [Qemu-devel] [RFC] Getting specific device from qdev structs
Date: Mon, 21 Jun 2010 15:07:13 +0100	[thread overview]
Message-ID: <201006211507.13975.paul@codesourcery.com> (raw)
In-Reply-To: <20100621134858.GA8275@localhost>

> So I've been looking for a way to obtain things like a PCIDevice from a
> more generic structure (say from hw/qdev.h),

If you're having to figure out what kind of a device you have then I think 
you're already doing something else wrong. I'd expect the bits of code that 
needs to identify devices to be inherently bus specific.

If you've got some sort of on-cpu IOMMU which is asking "did this come from an 
ISA device, or a PCI device?", then I suspect you've got your abstraction 
layers wrong. This should already have been handled by the pci/isa to cpu 
bridge.

Paul

  reply	other threads:[~2010-06-21 14:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-21 13:48 [RFC] Getting specific device from qdev structs Eduard - Gabriel Munteanu
2010-06-21 13:48 ` [Qemu-devel] " Eduard - Gabriel Munteanu
2010-06-21 14:07 ` Paul Brook [this message]
2010-06-21 14:07   ` Paul Brook
2010-06-21 14:32   ` Eduard - Gabriel Munteanu
2010-06-21 14:32     ` Eduard - Gabriel Munteanu
2010-06-21 15:08     ` Paul Brook
2010-06-21 15:08       ` Paul Brook

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201006211507.13975.paul@codesourcery.com \
    --to=paul@codesourcery.com \
    --cc=eduard.munteanu@linux360.ro \
    --cc=joro@8bytes.org \
    --cc=kvm@vger.kernel.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.