From: Marcelo Tosatti <mtosatti@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Jan Kiszka <jan.kiszka@siemens.com>,
Glauber Costa <glommer@redhat.com>,
qemu-devel <qemu-devel@nongnu.org>
Subject: [Qemu-devel] [PATCH] fix smp with tcg mode and --enable-io-thread
Date: Mon, 21 Jun 2010 16:31:23 -0300 [thread overview]
Message-ID: <20100621193123.GA14083@amt.cnet> (raw)
In-Reply-To: <4C1BCEB0.6050601@codemonkey.ws>
Clear exit_request when iothread grabs the global lock.
Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
diff --git a/cpu-exec.c b/cpu-exec.c
index 026980a..74cb973 100644
--- a/cpu-exec.c
+++ b/cpu-exec.c
@@ -236,10 +236,8 @@ int cpu_exec(CPUState *env1)
asm("");
env = env1;
- if (exit_request) {
+ if (exit_request)
env->exit_request = 1;
- exit_request = 0;
- }
#if defined(TARGET_I386)
if (!kvm_enabled()) {
diff --git a/cpus.c b/cpus.c
index fcd0f09..ef1ab22 100644
--- a/cpus.c
+++ b/cpus.c
@@ -598,6 +598,7 @@ void qemu_mutex_lock_iothread(void)
}
qemu_mutex_unlock(&qemu_fair_mutex);
}
+ exit_request = 0;
}
void qemu_mutex_unlock_iothread(void)
next prev parent reply other threads:[~2010-06-21 19:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-18 16:37 [Qemu-devel] smp broken in tcg mode with --enable-io-thread? Jan Kiszka
2010-06-18 19:53 ` Anthony Liguori
2010-06-21 19:31 ` Marcelo Tosatti [this message]
2010-06-21 20:25 ` [Qemu-devel] Re: [PATCH] fix smp with tcg mode and --enable-io-thread Jan Kiszka
2010-06-21 20:58 ` Jan Kiszka
2010-06-21 23:06 ` Marcelo Tosatti
2010-06-22 8:06 ` Jan Kiszka
2010-06-23 7:42 ` Jan Kiszka
2010-06-23 16:19 ` Anthony Liguori
2010-06-21 22:13 ` Jan Kiszka
2010-06-21 22:25 ` Alexander Graf
2010-06-22 7:59 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100621193123.GA14083@amt.cnet \
--to=mtosatti@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=glommer@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.