Re: [GIT PATCHES FOR 2.6.36] gspca for_2.6.36

Re: [GIT PATCHES FOR 2.6.36] gspca for_2.6.36

[Jean-Francois Moine]

On Mon, 21 Jun 2010 22:23:21 -0300
Mauro Carvalho Chehab <mchehab@redhat.com> wrote:

> > Jean-François Moine (15):
> >       gspca - JPEG subdrivers: Don't allocate the JPEG header.
> >       gspca - stk014: Change the min and default values of the JPEG
> > quality. gspca - zc3xx: Change the max and default JPEG qualities.
> >       gspca - zc3xx: Don't change the registers 7 and 8 for sensor
> > pas202b. gspca - zc3xx: Add back the brightness control.  
> 
> >       gspca: Remove/move useless inclusions of slab.h.  
> 
> This patch doesn't seem right. The addition of slab.h were done in
> order to allow the removal of the header from some core files. I'm
> not sure if all the upstream changes got applied to 2.6.35, but it
> seems prudent to wait for a while before just removing the headers,
> especially since the slab.h dependency may be different on non-Intel
> architectures.
> 
> I'm applying the remaining patches. If you think that this patch is
> correct, please re-send it to both LMML and LKML, c/c the authors of
> the slab.h removal, in order to get their acks, or, otherwise, please
> re-submit it for 2.6.37 window.

Hi Mauro,

The slab.h dependency was changed in the kernel 2.6.34 and its
inclusion in some gspca source files was needed in case of the usage of
kmalloc/kfree only.

After removing the JPEG header allocation, most gspca subdrivers do not
use alloc/free anymore, so, there is no need to include slab.h anymore.

On the other side, this patch is easily checked because, if wrong, it
raises compilation errors on any architecture.

Then, both patches (removal of JPEG alloc/free and slab.h inclusion)
should go to 2.6.36.

Cheers.

-- 
Ken ar c'hentañ	|	      ** Breizh ha Linux atav! **
Jef		|		http://moinejf.free.fr/

Re: [GIT PATCHES FOR 2.6.36] gspca for_2.6.36

[Mauro Carvalho Chehab]

Em 22-06-2010 05:42, Jean-Francois Moine escreveu:
> On Mon, 21 Jun 2010 22:23:21 -0300

>> I'm applying the remaining patches. If you think that this patch is
>> correct, please re-send it to both LMML and LKML, c/c the authors of
>> the slab.h removal, in order to get their acks, or, otherwise, please
>> re-submit it for 2.6.37 window.
> 
> Hi Mauro,
> 
> The slab.h dependency was changed in the kernel 2.6.34 and its
> inclusion in some gspca source files was needed in case of the usage of
> kmalloc/kfree only.
> 
> After removing the JPEG header allocation, most gspca subdrivers do not
> use alloc/free anymore, so, there is no need to include slab.h anymore.
> 
> On the other side, this patch is easily checked because, if wrong, it
> raises compilation errors on any architecture.
> 
> Then, both patches (removal of JPEG alloc/free and slab.h inclusion)
> should go to 2.6.36.

OK, makes sense. I'll apply the patch at staging/gspca.

Cheers,
Mauro.

[GIT PATCHES FOR 2.6.36] gspca for_2.6.36

[Jean-Francois Moine]

The following changes since commit
d65728875a85ac7c8b7d6eb8d51425bacc188980:

  V4L/DVB: v4l: radio: si470x: fix unneeded free_irq() call (2010-09-30 07:35:12 -0300)

are available in the git repository at:
  git://linuxtv.org/jfrancois/gspca.git for_2.6.36

Jean-François Moine (1):
      gspca - main: Fix a regression with the PS3 Eye webcam

 drivers/media/video/gspca/gspca.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

-- 
Ken ar c'hentañ	|	      ** Breizh ha Linux atav! **
Jef		|		http://moinejf.free.fr/

Re: [GIT PATCHES FOR 2.6.36] gspca for_2.6.36

[Antonio Ospite]

[-- Attachment #1: Type: text/plain, Size: 1210 bytes --]

On Sun, 10 Oct 2010 13:24:47 +0200
Jean-Francois Moine <moinejf@free.fr> wrote:

> The following changes since commit
> d65728875a85ac7c8b7d6eb8d51425bacc188980:
> 
>   V4L/DVB: v4l: radio: si470x: fix unneeded free_irq() call (2010-09-30 07:35:12 -0300)
> 
> are available in the git repository at:
>   git://linuxtv.org/jfrancois/gspca.git for_2.6.36
> 
> Jean-François Moine (1):
>       gspca - main: Fix a regression with the PS3 Eye webcam
> 

Hi, this is not in 2.6.36-rc8, any chance we can make it for 2.6.36?

Thanks,
   Antonio

>  drivers/media/video/gspca/gspca.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> -- 
> Ken ar c'hentañ	|	      ** Breizh ha Linux atav! **
> Jef		|		http://moinejf.free.fr/
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

-- 
Antonio Ospite
http://ao2.it

PGP public key ID: 0x4553B001

A: Because it messes up the order in which people normally read text.
   See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: [GIT PATCHES FOR 2.6.36] gspca for_2.6.36

[Antonio Ospite]

[-- Attachment #1: Type: text/plain, Size: 900 bytes --]

On Fri, 15 Oct 2010 09:41:48 +0200
Antonio Ospite <ospite@studenti.unina.it> wrote:

> On Sun, 10 Oct 2010 13:24:47 +0200
> Jean-Francois Moine <moinejf@free.fr> wrote:
> 
> > The following changes since commit
> > d65728875a85ac7c8b7d6eb8d51425bacc188980:
> > 
> >   V4L/DVB: v4l: radio: si470x: fix unneeded free_irq() call (2010-09-30 07:35:12 -0300)
> > 
> > are available in the git repository at:
> >   git://linuxtv.org/jfrancois/gspca.git for_2.6.36
> > 
> > Jean-François Moine (1):
> >       gspca - main: Fix a regression with the PS3 Eye webcam
> > 
> 
> Hi, this is not in 2.6.36-rc8, any chance we can make it for 2.6.36?

Ping.

-- 
Antonio Ospite
http://ao2.it

PGP public key ID: 0x4553B001

A: Because it messes up the order in which people normally read text.
   See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: [GIT PATCHES FOR 2.6.36] gspca for_2.6.36

[Mauro Carvalho Chehab]

Em 19-10-2010 07:20, Antonio Ospite escreveu:
> On Fri, 15 Oct 2010 09:41:48 +0200
> Antonio Ospite <ospite@studenti.unina.it> wrote:
> 
>> On Sun, 10 Oct 2010 13:24:47 +0200
>> Jean-Francois Moine <moinejf@free.fr> wrote:
>>
>>> The following changes since commit
>>> d65728875a85ac7c8b7d6eb8d51425bacc188980:
>>>
>>>   V4L/DVB: v4l: radio: si470x: fix unneeded free_irq() call (2010-09-30 07:35:12 -0300)
>>>
>>> are available in the git repository at:
>>>   git://linuxtv.org/jfrancois/gspca.git for_2.6.36
>>>
>>> Jean-François Moine (1):
>>>       gspca - main: Fix a regression with the PS3 Eye webcam
>>>
>>
>> Hi, this is not in 2.6.36-rc8, any chance we can make it for 2.6.36?
> 
> Ping.
> 
The patch is in the today's linux-next tree. I added it together with another patch
for 2.6.36 (they are on a separate brancho on my local tree). If everything wents well, 
it is likely that we'll have time to add it for 2.6.36.

Cheers,
Mauro

[GIT PATCHES FOR 2.6.36] gspca for_2.6.36

[Jean-Francois Moine]

Hi Mauro,

I added two fixes of an other regression. They should go to 2.6.36.

The following changes since commit
d65728875a85ac7c8b7d6eb8d51425bacc188980:

  V4L/DVB: v4l: radio: si470x: fix unneeded free_irq() call (2010-09-30 07:35:12 -0300)

are available in the git repository at:
  git://linuxtv.org/jfrancois/gspca.git for_2.6.36

Jean-François Moine (3):
      gspca - main: Fix a regression with the PS3 Eye webcam
      gspca - sonixj: Fix a regression of sensors hv7131r and mi0360
      gspca - sonixj: Fix a regression with sensor hv7131r

 drivers/media/video/gspca/gspca.c  |    4 ++--
 drivers/media/video/gspca/sonixj.c |    6 ++----
 2 files changed, 4 insertions(+), 6 deletions(-)

Cheers.

-- 
Ken ar c'hentañ	|	      ** Breizh ha Linux atav! **
Jef		|		http://moinejf.free.fr/