* [PATCH] RTC/max6900: use rtc_valid_tm to check returning tm for max6900
@ 2010-06-22 9:09 Wan ZongShun
2010-06-22 9:41 ` Wan ZongShun
2010-06-22 12:47 ` Dale Farnsworth
0 siblings, 2 replies; 3+ messages in thread
From: Wan ZongShun @ 2010-06-22 9:09 UTC (permalink / raw)
To: Alessandro Zummo, Andrew Morton, rtc-linux, LKML, dale
Use rtc_valid_tm to check returning tm for max6900,
it can avoid returning wrong tm value.
---
drivers/rtc/rtc-max6900.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/rtc/rtc-max6900.c b/drivers/rtc/rtc-max6900.c
index a4f6665..486142c 100644
--- a/drivers/rtc/rtc-max6900.c
+++ b/drivers/rtc/rtc-max6900.c
@@ -159,7 +159,7 @@ static int max6900_i2c_read_time(struct i2c_client *client, struct rtc_time *tm)
bcd2bin(regs[MAX6900_REG_CENTURY]) * 100 - 1900;
tm->tm_wday = bcd2bin(regs[MAX6900_REG_DW]);
- return 0;
+ return rtc_valid_tm(tm);
}
static int max6900_i2c_clear_write_protect(struct i2c_client *client)
--
1.6.3.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] RTC/max6900: use rtc_valid_tm to check returning tm for max6900
2010-06-22 9:09 [PATCH] RTC/max6900: use rtc_valid_tm to check returning tm for max6900 Wan ZongShun
@ 2010-06-22 9:41 ` Wan ZongShun
2010-06-22 12:47 ` Dale Farnsworth
1 sibling, 0 replies; 3+ messages in thread
From: Wan ZongShun @ 2010-06-22 9:41 UTC (permalink / raw)
To: Alessandro Zummo, Andrew Morton, rtc-linux, LKML, dale
Signed-off-by: Wan ZongShun <mcuos.com@gmail.com>
> Use rtc_valid_tm to check returning tm for max6900,
> it can avoid returning wrong tm value.
> ---
> drivers/rtc/rtc-max6900.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/rtc/rtc-max6900.c b/drivers/rtc/rtc-max6900.c
> index a4f6665..486142c 100644
> --- a/drivers/rtc/rtc-max6900.c
> +++ b/drivers/rtc/rtc-max6900.c
> @@ -159,7 +159,7 @@ static int max6900_i2c_read_time(struct i2c_client *client, struct rtc_time *tm)
> bcd2bin(regs[MAX6900_REG_CENTURY]) * 100 - 1900;
> tm->tm_wday = bcd2bin(regs[MAX6900_REG_DW]);
>
> - return 0;
> + return rtc_valid_tm(tm);
> }
>
> static int max6900_i2c_clear_write_protect(struct i2c_client *client)
> --
> 1.6.3.3
>
--
*linux-arm-kernel mailing list
mail addr:linux-arm-kernel@lists.infradead.org
you can subscribe by:
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
* linux-arm-NUC900 mailing list
mail addr:NUC900@googlegroups.com
main web: https://groups.google.com/group/NUC900
you can subscribe it by sending me mail:
mcuos.com@gmail.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] RTC/max6900: use rtc_valid_tm to check returning tm for max6900
2010-06-22 9:09 [PATCH] RTC/max6900: use rtc_valid_tm to check returning tm for max6900 Wan ZongShun
2010-06-22 9:41 ` Wan ZongShun
@ 2010-06-22 12:47 ` Dale Farnsworth
1 sibling, 0 replies; 3+ messages in thread
From: Dale Farnsworth @ 2010-06-22 12:47 UTC (permalink / raw)
To: Wan ZongShun; +Cc: Alessandro Zummo, Andrew Morton, rtc-linux, LKML
On Tue, Jun 22, 2010 at 05:09:03PM +0800, Wan ZongShun wrote:
> Use rtc_valid_tm to check returning tm for max6900,
> it can avoid returning wrong tm value.
> ---
> drivers/rtc/rtc-max6900.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/rtc/rtc-max6900.c b/drivers/rtc/rtc-max6900.c
> index a4f6665..486142c 100644
> --- a/drivers/rtc/rtc-max6900.c
> +++ b/drivers/rtc/rtc-max6900.c
> @@ -159,7 +159,7 @@ static int max6900_i2c_read_time(struct i2c_client *client, struct rtc_time *tm)
> bcd2bin(regs[MAX6900_REG_CENTURY]) * 100 - 1900;
> tm->tm_wday = bcd2bin(regs[MAX6900_REG_DW]);
>
> - return 0;
> + return rtc_valid_tm(tm);
> }
>
> static int max6900_i2c_clear_write_protect(struct i2c_client *client)
Ack.
Thanks,
-Dale
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-06-22 13:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-06-22 9:09 [PATCH] RTC/max6900: use rtc_valid_tm to check returning tm for max6900 Wan ZongShun
2010-06-22 9:41 ` Wan ZongShun
2010-06-22 12:47 ` Dale Farnsworth
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.