* [patch] i915: remove unneed NULL checks
@ 2010-06-23 17:06 Dan Carpenter
2010-08-23 11:28 ` Dan Carpenter
0 siblings, 1 reply; 3+ messages in thread
From: Dan Carpenter @ 2010-06-23 17:06 UTC (permalink / raw)
To: David Airlie; +Cc: kernel-janitors, dri-devel
We don't need to check the list cursor in a list_for_each_entry(). It's
always non-null.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index cc8131f..8a2bdfc 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -745,7 +745,7 @@ bool intel_pipe_has_type (struct drm_crtc *crtc, int type)
struct drm_encoder *l_entry;
list_for_each_entry(l_entry, &mode_config->encoder_list, head) {
- if (l_entry && l_entry->crtc == crtc) {
+ if (l_entry->crtc == crtc) {
struct intel_encoder *intel_encoder = enc_to_intel_encoder(l_entry);
if (intel_encoder->type == type)
return true;
@@ -3322,7 +3322,7 @@ static int intel_crtc_mode_set(struct drm_crtc *crtc,
list_for_each_entry(encoder, &mode_config->encoder_list, head) {
- if (!encoder || encoder->crtc != crtc)
+ if (encoder->crtc != crtc)
continue;
intel_encoder = enc_to_intel_encoder(encoder);
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [patch] i915: remove unneed NULL checks
2010-06-23 17:06 [patch] i915: remove unneed NULL checks Dan Carpenter
@ 2010-08-23 11:28 ` Dan Carpenter
0 siblings, 0 replies; 3+ messages in thread
From: Dan Carpenter @ 2010-08-23 11:28 UTC (permalink / raw)
To: David Airlie
Cc: Eric Anholt, Jesse Barnes, Zhenyu Wang, Zhao Yakui, dri-devel,
linux-kernel, kernel-janitors
On Wed, Jun 23, 2010 at 07:06:22PM +0200, Dan Carpenter wrote:
> We don't need to check the list cursor in a list_for_each_entry(). It's
> always non-null.
>
Here is another one that never got applied. I has a sad face. :(
regards,
dan carpenter
> Signed-off-by: Dan Carpenter <error27@gmail.com>
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index cc8131f..8a2bdfc 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -745,7 +745,7 @@ bool intel_pipe_has_type (struct drm_crtc *crtc, int type)
> struct drm_encoder *l_entry;
>
> list_for_each_entry(l_entry, &mode_config->encoder_list, head) {
> - if (l_entry && l_entry->crtc = crtc) {
> + if (l_entry->crtc = crtc) {
> struct intel_encoder *intel_encoder = enc_to_intel_encoder(l_entry);
> if (intel_encoder->type = type)
> return true;
> @@ -3322,7 +3322,7 @@ static int intel_crtc_mode_set(struct drm_crtc *crtc,
>
> list_for_each_entry(encoder, &mode_config->encoder_list, head) {
>
> - if (!encoder || encoder->crtc != crtc)
> + if (encoder->crtc != crtc)
> continue;
>
> intel_encoder = enc_to_intel_encoder(encoder);
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [patch] i915: remove unneed NULL checks
@ 2010-08-23 11:28 ` Dan Carpenter
0 siblings, 0 replies; 3+ messages in thread
From: Dan Carpenter @ 2010-08-23 11:28 UTC (permalink / raw)
To: David Airlie
Cc: Eric Anholt, Jesse Barnes, Zhenyu Wang, Zhao Yakui, dri-devel,
linux-kernel, kernel-janitors
On Wed, Jun 23, 2010 at 07:06:22PM +0200, Dan Carpenter wrote:
> We don't need to check the list cursor in a list_for_each_entry(). It's
> always non-null.
>
Here is another one that never got applied. I has a sad face. :(
regards,
dan carpenter
> Signed-off-by: Dan Carpenter <error27@gmail.com>
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index cc8131f..8a2bdfc 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -745,7 +745,7 @@ bool intel_pipe_has_type (struct drm_crtc *crtc, int type)
> struct drm_encoder *l_entry;
>
> list_for_each_entry(l_entry, &mode_config->encoder_list, head) {
> - if (l_entry && l_entry->crtc == crtc) {
> + if (l_entry->crtc == crtc) {
> struct intel_encoder *intel_encoder = enc_to_intel_encoder(l_entry);
> if (intel_encoder->type == type)
> return true;
> @@ -3322,7 +3322,7 @@ static int intel_crtc_mode_set(struct drm_crtc *crtc,
>
> list_for_each_entry(encoder, &mode_config->encoder_list, head) {
>
> - if (!encoder || encoder->crtc != crtc)
> + if (encoder->crtc != crtc)
> continue;
>
> intel_encoder = enc_to_intel_encoder(encoder);
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-08-23 11:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-06-23 17:06 [patch] i915: remove unneed NULL checks Dan Carpenter
2010-08-23 11:28 ` Dan Carpenter
2010-08-23 11:28 ` Dan Carpenter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.