All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
To: Prerna Saxena <prerna@linux.vnet.ibm.com>
Cc: qemu-devel@nongnu.org, Anthony Liguori <aliguori@us.ibm.com>,
	Jan Kiszka <jan.kiszka@siemens.com>,
	Maneesh Soni <maneesh@linux.vnet.ibm.com>,
	Luiz Capitulino <lcapitulino@redhat.com>,
	kvm@vger.kernel.org, Ananth Narayan <ananth@linux.vnet.ibm.com>
Subject: Re: [RFC v4][PATCH 0/3] Monitor support for Qemu tracing
Date: Thu, 24 Jun 2010 16:13:13 +0100	[thread overview]
Message-ID: <20100624151313.GA10152@stefan-thinkpad.transitives.com> (raw)
In-Reply-To: <20100624164930.7859b779@zephyr>

On Thu, Jun 24, 2010 at 04:49:30PM +0530, Prerna Saxena wrote:
> This set of patches enables trace visualization & control 
> via the QEMU monitor. It is based on trace infrastructure posted 
> upstream :
> ( http://lists.gnu.org/archive/html/qemu-devel/2010-05/msg02407.html )
> 
> This patchset adds monitor commands :
> - info trace : to view current contents of the trace buffer
> - info tracepoints : to view all available tracepoints and their state.
> - tracepoint NAME on|off : to enable/disable the logging of dataThis is v3 of a set of patches to enable trace visualization & control 
> via the QEMU monitor. 
> 
> Changelog from v3:
> 1. As suggested, it replaces a hash-based search of tracepoints 
> with a linear search.
> 2. Static initialization of trace event array.
> 3. Cleanups.
> 
> Changelog from v2:
> 1. Clean-ups, particularly relating to export of tdb_hash().
> 
> Changelog from v1:
> 1. Command 'info trace' is used to view current contents of buffer, in 
> place of 'trace'.
> 2. Cleanups

Applied, thanks!

http://repo.or.cz/w/qemu/stefanha.git/shortlog/refs/heads/tracing

I'd like to focus on polishing the current tracing branch into a
patchset that can be merged into QEMU.  Having this working prototype
enables us to try tracing out; we can commit fixes on top and then
squish the commits down for QEMU merge when the basic feature set is
solid.

> Todos :
> 1. Integration with QMP
> 2. More tracepoints need to be added for instrumenting other qemu components
>  such as virtio drivers, etc.

I am copying these to another email thread so we can discuss what needs
to be done to get tracing merged.

Stefan

WARNING: multiple messages have this Message-ID (diff)
From: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
To: Prerna Saxena <prerna@linux.vnet.ibm.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
	kvm@vger.kernel.org, Jan Kiszka <jan.kiszka@siemens.com>,
	qemu-devel@nongnu.org, Luiz Capitulino <lcapitulino@redhat.com>,
	Maneesh Soni <maneesh@linux.vnet.ibm.com>,
	Ananth Narayan <ananth@linux.vnet.ibm.com>
Subject: [Qemu-devel] Re: [RFC v4][PATCH 0/3] Monitor support for Qemu tracing
Date: Thu, 24 Jun 2010 16:13:13 +0100	[thread overview]
Message-ID: <20100624151313.GA10152@stefan-thinkpad.transitives.com> (raw)
In-Reply-To: <20100624164930.7859b779@zephyr>

On Thu, Jun 24, 2010 at 04:49:30PM +0530, Prerna Saxena wrote:
> This set of patches enables trace visualization & control 
> via the QEMU monitor. It is based on trace infrastructure posted 
> upstream :
> ( http://lists.gnu.org/archive/html/qemu-devel/2010-05/msg02407.html )
> 
> This patchset adds monitor commands :
> - info trace : to view current contents of the trace buffer
> - info tracepoints : to view all available tracepoints and their state.
> - tracepoint NAME on|off : to enable/disable the logging of dataThis is v3 of a set of patches to enable trace visualization & control 
> via the QEMU monitor. 
> 
> Changelog from v3:
> 1. As suggested, it replaces a hash-based search of tracepoints 
> with a linear search.
> 2. Static initialization of trace event array.
> 3. Cleanups.
> 
> Changelog from v2:
> 1. Clean-ups, particularly relating to export of tdb_hash().
> 
> Changelog from v1:
> 1. Command 'info trace' is used to view current contents of buffer, in 
> place of 'trace'.
> 2. Cleanups

Applied, thanks!

http://repo.or.cz/w/qemu/stefanha.git/shortlog/refs/heads/tracing

I'd like to focus on polishing the current tracing branch into a
patchset that can be merged into QEMU.  Having this working prototype
enables us to try tracing out; we can commit fixes on top and then
squish the commits down for QEMU merge when the basic feature set is
solid.

> Todos :
> 1. Integration with QMP
> 2. More tracepoints need to be added for instrumenting other qemu components
>  such as virtio drivers, etc.

I am copying these to another email thread so we can discuss what needs
to be done to get tracing merged.

Stefan

  parent reply	other threads:[~2010-06-24 15:13 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-24 11:19 [RFC v4][PATCH 0/3] Monitor support for Qemu tracing Prerna Saxena
2010-06-24 11:19 ` [Qemu-devel] " Prerna Saxena
2010-06-24 11:28 ` [RFC v4][PATCH 1/3] Change type declarations Prerna Saxena
2010-06-24 11:28   ` [Qemu-devel] " Prerna Saxena
2010-06-24 11:31 ` [RFC v4][PATCH 2/3] Monitor command 'info trace' Prerna Saxena
2010-06-24 11:31   ` [Qemu-devel] " Prerna Saxena
2010-06-24 11:34 ` [RFC v4][PATCH 3/3] Support for dynamically enabling/disabling trace events Prerna Saxena
2010-06-24 11:34   ` [Qemu-devel] " Prerna Saxena
2010-06-24 15:13 ` Stefan Hajnoczi [this message]
2010-06-24 15:13   ` [Qemu-devel] Re: [RFC v4][PATCH 0/3] Monitor support for Qemu tracing Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100624151313.GA10152@stefan-thinkpad.transitives.com \
    --to=stefanha@linux.vnet.ibm.com \
    --cc=aliguori@us.ibm.com \
    --cc=ananth@linux.vnet.ibm.com \
    --cc=jan.kiszka@siemens.com \
    --cc=kvm@vger.kernel.org \
    --cc=lcapitulino@redhat.com \
    --cc=maneesh@linux.vnet.ibm.com \
    --cc=prerna@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.