From: Dave Jones <davej@redhat.com>
To: Len Brown <lenb@kernel.org>
Cc: linux-pm@lists.linux-foundation.org
Subject: RFC: Don't enable both cpuidle governors when NO_HZ is enabled.
Date: Thu, 24 Jun 2010 23:52:54 -0400 [thread overview]
Message-ID: <20100625035254.GA25695@redhat.com> (raw)
Does this patch make sense ?
I noticed we setup both governors during boot..
kernel: [ 3.387035] cpuidle: using governor ladder
kernel: [ 3.391541] cpuidle: using governor menu
which seems wasteful.
With this patch, we configure either ladder, or menu, depending on
whether NO_HZ is set.
Signed-off-by: Dave Jones <davej@redhat.com>
--- linux-2.6.34.noarch/drivers/cpuidle/Kconfig~ 2010-06-24 23:48:08.000000000 -0400
+++ linux-2.6.34.noarch/drivers/cpuidle/Kconfig 2010-06-24 23:48:13.000000000 -0400
@@ -11,7 +11,7 @@ config CPU_IDLE
config CPU_IDLE_GOV_LADDER
bool
- depends on CPU_IDLE
+ depends on CPU_IDLE && !NO_HZ
default y
config CPU_IDLE_GOV_MENU
reply other threads:[~2010-06-25 3:52 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100625035254.GA25695@redhat.com \
--to=davej@redhat.com \
--cc=lenb@kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.