All of lore.kernel.org
 help / color / mirror / Atom feed
* RFC: Don't enable both cpuidle governors when NO_HZ is enabled.
@ 2010-06-25  3:52 Dave Jones
  0 siblings, 0 replies; only message in thread
From: Dave Jones @ 2010-06-25  3:52 UTC (permalink / raw)
  To: Len Brown; +Cc: linux-pm

Does this patch make sense ?

I noticed we setup both governors during boot..

 kernel: [    3.387035] cpuidle: using governor ladder
 kernel: [    3.391541] cpuidle: using governor menu

which seems wasteful.

With this patch, we configure either ladder, or menu, depending on
whether NO_HZ is set.

Signed-off-by: Dave Jones <davej@redhat.com>

--- linux-2.6.34.noarch/drivers/cpuidle/Kconfig~	2010-06-24 23:48:08.000000000 -0400
+++ linux-2.6.34.noarch/drivers/cpuidle/Kconfig	2010-06-24 23:48:13.000000000 -0400
@@ -11,7 +11,7 @@ config CPU_IDLE
 
 config CPU_IDLE_GOV_LADDER
 	bool
-	depends on CPU_IDLE
+	depends on CPU_IDLE && !NO_HZ
 	default y
 
 config CPU_IDLE_GOV_MENU

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2010-06-25  3:52 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-06-25  3:52 RFC: Don't enable both cpuidle governors when NO_HZ is enabled Dave Jones

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.