All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: Ryan Harper <ryanh@us.ibm.com>
Cc: virtualization@lists.linux-foundation.org,
	john cooper <john.cooper@redhat.com>,
	kvm@vger.kernel.org, qemu-devel@nongnu.org
Subject: Re: [PATCH 0/2] v2: Add 'serial' attribute to virtio-blk devices
Date: Fri, 25 Jun 2010 12:34:28 +0930	[thread overview]
Message-ID: <201006251234.30808.rusty@rustcorp.com.au> (raw)
In-Reply-To: <1277349598-24559-1-git-send-email-ryanh@us.ibm.com>

On Thu, 24 Jun 2010 12:49:56 pm Ryan Harper wrote:
> Using Rusty's suggestion I've respun the patch removing the special copy
> function.  I've tested this patch in a guest kernel with and without qemu
> supplying serial numbers for the block devices and it's working as expected.
> When qemu supplies serial numbers, the correct value is supplied to
> /sys/block/vdX/serial and can be used by udev for generating disk/by-id paths
> (without separate utility).  When running without serial number support the path
> still exists in sysfs but produces no output.
> 
> Signed-off-by: Ryan Harper <ryanh@us.ibm.com>

Great, both applied.

BTW, a mail without a patch doesn't need a sign off, does it?

Thanks,
Ruty.

WARNING: multiple messages have this Message-ID (diff)
From: Rusty Russell <rusty@rustcorp.com.au>
To: Ryan Harper <ryanh@us.ibm.com>
Cc: john cooper <john.cooper@redhat.com>,
	qemu-devel@nongnu.org, kvm@vger.kernel.org,
	virtualization@lists.linux-foundation.org
Subject: [Qemu-devel] Re: [PATCH 0/2] v2: Add 'serial' attribute to virtio-blk devices
Date: Fri, 25 Jun 2010 12:34:28 +0930	[thread overview]
Message-ID: <201006251234.30808.rusty@rustcorp.com.au> (raw)
In-Reply-To: <1277349598-24559-1-git-send-email-ryanh@us.ibm.com>

On Thu, 24 Jun 2010 12:49:56 pm Ryan Harper wrote:
> Using Rusty's suggestion I've respun the patch removing the special copy
> function.  I've tested this patch in a guest kernel with and without qemu
> supplying serial numbers for the block devices and it's working as expected.
> When qemu supplies serial numbers, the correct value is supplied to
> /sys/block/vdX/serial and can be used by udev for generating disk/by-id paths
> (without separate utility).  When running without serial number support the path
> still exists in sysfs but produces no output.
> 
> Signed-off-by: Ryan Harper <ryanh@us.ibm.com>

Great, both applied.

BTW, a mail without a patch doesn't need a sign off, does it?

Thanks,
Ruty.

  parent reply	other threads:[~2010-06-25  3:04 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-24  3:19 [PATCH 0/2] v2: Add 'serial' attribute to virtio-blk devices Ryan Harper
2010-06-24  3:19 ` [Qemu-devel] " Ryan Harper
2010-06-24  3:19 ` [PATCH 1/2] v2 " Ryan Harper
2010-06-24  3:19   ` [Qemu-devel] " Ryan Harper
2010-06-24  3:19 ` Ryan Harper
2010-06-24  3:19 ` [PATCH 2/2] Remove virtio_blk VBID ioctl Ryan Harper
2010-06-24  3:19 ` Ryan Harper
2010-06-24  3:19   ` [Qemu-devel] " Ryan Harper
2010-06-25  3:04 ` [PATCH 0/2] v2: Add 'serial' attribute to virtio-blk devices Rusty Russell
2010-06-25  3:04 ` Rusty Russell [this message]
2010-06-25  3:04   ` [Qemu-devel] " Rusty Russell
  -- strict thread matches above, loose matches on Subject: below --
2010-06-24  3:19 Ryan Harper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201006251234.30808.rusty@rustcorp.com.au \
    --to=rusty@rustcorp.com.au \
    --cc=john.cooper@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=qemu-devel@nongnu.org \
    --cc=ryanh@us.ibm.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.