All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marek.vasut@gmail.com>
To: Rupjyoti Sarmah <rsarmah@amcc.com>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
	jgarzik@pobox.com, sr@denx.de, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH]460EX on-chip SATA driver<kernel 2.6.33><resubmission>
Date: Tue, 29 Jun 2010 03:33:50 +0200	[thread overview]
Message-ID: <201006290333.50673.marek.vasut@gmail.com> (raw)
In-Reply-To: <201006041226.o54CQH2V017366@amcc.com>

Dne Pá 4. června 2010 14:26:17 Rupjyoti Sarmah napsal(a):
> This patch enables the on-chip DWC SATA controller of the AppliedMicro
> processor 460EX.
> 
> Signed-off-by: Rupjyoti Sarmah <rsarmah@appliedmicro.com>
> Signed-off-by: Mark Miesfeld <mmiesfeld@appliedmicro.com>
> Signed-off-by: Prodyut Hazarika <phazarika@appliedmicro.com>
> 

--SNIP--

> +		dev_err(ap->dev, "%s: Command not pending cmd_issued=%d "
> +			"(tag=%d) DMA NOT started\n", __func__,
> +			hsdevp->cmd_issued[tag], tag);

Just a nitpick, but don't break strings if possible.

WARNING: multiple messages have this Message-ID (diff)
From: Marek Vasut <marek.vasut@gmail.com>
To: Rupjyoti Sarmah <rsarmah@amcc.com>
Cc: linux-ide@vger.kernel.org, sr@denx.de, jgarzik@pobox.com,
	linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH]460EX on-chip SATA driver<kernel 2.6.33><resubmission>
Date: Tue, 29 Jun 2010 03:33:50 +0200	[thread overview]
Message-ID: <201006290333.50673.marek.vasut@gmail.com> (raw)
In-Reply-To: <201006041226.o54CQH2V017366@amcc.com>

Dne P=C3=A1 4. =C4=8Dervna 2010 14:26:17 Rupjyoti Sarmah napsal(a):
> This patch enables the on-chip DWC SATA controller of the AppliedMicro
> processor 460EX.
>=20
> Signed-off-by: Rupjyoti Sarmah <rsarmah@appliedmicro.com>
> Signed-off-by: Mark Miesfeld <mmiesfeld@appliedmicro.com>
> Signed-off-by: Prodyut Hazarika <phazarika@appliedmicro.com>
>=20

=2D-SNIP--

> +		dev_err(ap->dev, "%s: Command not pending cmd_issued=3D%d "
> +			"(tag=3D%d) DMA NOT started\n", __func__,
> +			hsdevp->cmd_issued[tag], tag);

Just a nitpick, but don't break strings if possible.

  parent reply	other threads:[~2010-06-29  1:36 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-04 12:26 [PATCH]460EX on-chip SATA driver<kernel 2.6.33><resubmission> Rupjyoti Sarmah
2010-06-04 12:26 ` Rupjyoti Sarmah
2010-06-06 18:52 ` Josh Boyer
2010-06-06 18:52   ` Josh Boyer
2010-06-06 21:09 ` Wolfgang Denk
2010-06-06 21:09   ` Wolfgang Denk
2010-06-18  4:34 ` Jassi Brar
2010-06-18  4:34   ` Jassi Brar
2010-06-29  1:33 ` Marek Vasut [this message]
2010-06-29  1:33   ` Marek Vasut
2010-06-29 12:20   ` Rupjyoti Sarmah
2010-06-29 12:20     ` Rupjyoti Sarmah
2010-06-29 12:20     ` Rupjyoti Sarmah
2010-06-29 12:44   ` Anton Vorontsov
2010-06-29 12:44     ` Anton Vorontsov
  -- strict thread matches above, loose matches on Subject: below --
2010-05-05 17:57 [PATCH]460EX on-chip SATA driver <Kernel 2.6.33> < resubmission > Rupjyoti Sarmah
2010-05-05 17:57 ` Rupjyoti Sarmah
2010-05-14 17:44 ` Sergei Shtylyov
2010-05-14 17:44   ` Sergei Shtylyov
2010-05-15 23:40   ` Benjamin Herrenschmidt
2010-05-15 23:40     ` Benjamin Herrenschmidt
2010-05-17 10:06     ` Stefan Roese
2010-05-17 10:06       ` Stefan Roese
2010-05-17 10:36       ` Benjamin Herrenschmidt
2010-05-17 10:36         ` Benjamin Herrenschmidt
2010-05-14 21:56 ` Jeff Garzik
2010-05-14 21:56   ` Jeff Garzik
2010-05-19  1:49 ` Jassi Brar
2010-05-19  1:49   ` Jassi Brar
2010-05-19  9:53   ` Alan Cox
2010-05-19  9:53     ` Alan Cox
2010-05-19 11:19     ` Jassi Brar
2010-05-19 11:19       ` Jassi Brar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201006290333.50673.marek.vasut@gmail.com \
    --to=marek.vasut@gmail.com \
    --cc=jgarzik@pobox.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=rsarmah@amcc.com \
    --cc=sr@denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.