All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: "Éric Piel" <E.A.B.Piel@tudelft.nl>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
	"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [Regression 2.6.35-rc1?] Sysrq works too well (no need of alt)
Date: Tue, 29 Jun 2010 00:07:17 -0700	[thread overview]
Message-ID: <20100629070717.GD19712@core.coreip.homeip.net> (raw)
In-Reply-To: <4C1D4FA6.6030607@tudelft.nl>

On Sun, Jun 20, 2010 at 01:15:50AM +0200, Éric Piel wrote:
> Op 19-06-10 23:16, Rafael J. Wysocki schreef:
> > On Tuesday, June 08, 2010, Éric Piel wrote:
> >> Hello,
> >> I haven't investigated much yet, but I have the feeling that since
> >> 2.6.35-rc1 my "Print Screen/SysRq" key works only as SysRq: if I press
> >> it (normally assigned to take screenshot in gnome), nothing happens (no
> >> input event received in userspace) and no key on the keyboard works
> >> afterwards, until I press Alt. Actually the keys work, but behave as if
> >> the sysrq key was kept pressed (can be seen in dmesg, or by pressing "b").
> >>
> >> Looking at the log, a potential culprit is commit
> >> 97f5f0cd8cd0a05449cbb77d1e6f02e026875802 (Input: implement SysRq as a
> >> separate input handler). Probably the logic of "have to press all the
> >> keys at the same time" changed to "have to press the keys one after each
> >> other". So pressing alt and later on pressing PrintScreen leads to a SysRq.
> >>
> >> Does anybody else see this behaviour? Any suggestion on how to solve
> >> this bug? I'll try reverting the commit and report if it fixes the
> >> problem (the git revert fails so I've got to fix the conflict manually).
> > 
> > Is this still a problem with 2.6.35-rc3?
> The bug is still in 2.6.35-rc3. The patch that fixes this regression is
> in the "for-linus" branch of the input tree, but I think Dmitry hasn't
> yet sent a pull request to Linus.
> 

The fix should be in mainline now.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: "Éric Piel" <E.A.B.Piel@tudelft.nl>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
	"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [Regression 2.6.35-rc1?] Sysrq works too well (no need of alt)
Date: Tue, 29 Jun 2010 00:07:17 -0700	[thread overview]
Message-ID: <20100629070717.GD19712@core.coreip.homeip.net> (raw)
In-Reply-To: <4C1D4FA6.6030607@tudelft.nl>

On Sun, Jun 20, 2010 at 01:15:50AM +0200, Éric Piel wrote:
> Op 19-06-10 23:16, Rafael J. Wysocki schreef:
> > On Tuesday, June 08, 2010, Éric Piel wrote:
> >> Hello,
> >> I haven't investigated much yet, but I have the feeling that since
> >> 2.6.35-rc1 my "Print Screen/SysRq" key works only as SysRq: if I press
> >> it (normally assigned to take screenshot in gnome), nothing happens (no
> >> input event received in userspace) and no key on the keyboard works
> >> afterwards, until I press Alt. Actually the keys work, but behave as if
> >> the sysrq key was kept pressed (can be seen in dmesg, or by pressing "b").
> >>
> >> Looking at the log, a potential culprit is commit
> >> 97f5f0cd8cd0a05449cbb77d1e6f02e026875802 (Input: implement SysRq as a
> >> separate input handler). Probably the logic of "have to press all the
> >> keys at the same time" changed to "have to press the keys one after each
> >> other". So pressing alt and later on pressing PrintScreen leads to a SysRq.
> >>
> >> Does anybody else see this behaviour? Any suggestion on how to solve
> >> this bug? I'll try reverting the commit and report if it fixes the
> >> problem (the git revert fails so I've got to fix the conflict manually).
> > 
> > Is this still a problem with 2.6.35-rc3?
> The bug is still in 2.6.35-rc3. The patch that fixes this regression is
> in the "for-linus" branch of the input tree, but I think Dmitry hasn't
> yet sent a pull request to Linus.
> 

The fix should be in mainline now.

-- 
Dmitry

  reply	other threads:[~2010-06-29  7:07 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-08  9:33 [Regression 2.6.35-rc1?] Sysrq works too well (no need of alt) Éric Piel
2010-06-08 22:55 ` Éric Piel
2010-06-09  0:37   ` Dmitry Torokhov
2010-06-09  8:30     ` Dmitry Torokhov
2010-06-09 11:32       ` Éric Piel
2010-06-19 21:16 ` Rafael J. Wysocki
2010-06-19 23:15   ` Éric Piel
2010-06-19 23:15     ` Éric Piel
2010-06-29  7:07     ` Dmitry Torokhov [this message]
2010-06-29  7:07       ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100629070717.GD19712@core.coreip.homeip.net \
    --to=dmitry.torokhov@gmail.com \
    --cc=E.A.B.Piel@tudelft.nl \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rjw@sisk.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.