From: Andrew Morton <akpm@linux-foundation.org>
To: Boaz Harrosh <bharrosh@panasas.com>
Cc: Jeff Dike <jdike@addtoit.com>,
Liu Aleaxander <aleaxander@gmail.com>,
linux-kernel@vger.kernel.org,
user-mode-linux-devel@lists.sourceforge.net, stable@kernel.org
Subject: Re: [uml-devel] [PATCH] um: Include missing header file in os-linux/mem.c
Date: Tue, 29 Jun 2010 11:50:29 -0700 [thread overview]
Message-ID: <20100629115029.4eccea6e.akpm@linux-foundation.org> (raw)
In-Reply-To: <4C29B034.8070208@panasas.com>
On Tue, 29 Jun 2010 11:35:00 +0300
Boaz Harrosh <bharrosh@panasas.com> wrote:
> On 06/15/2010 11:06 AM, Liu Aleaxander wrote:
> > The os-linux/mem.c file calls fchmod function, which is declared in sys/stat.h
> > header file, so include it.
> >
> > Signed-off-by: Liu Aleaxander <Aleaxander@gmail.com>
> > ---
> > arch/um/os-Linux/mem.c | 1 +
> > 1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > diff --git a/arch/um/os-Linux/mem.c b/arch/um/os-Linux/mem.c
> > index 93a11d7..e696144 100644
> > --- a/arch/um/os-Linux/mem.c
> > +++ b/arch/um/os-Linux/mem.c
> > @@ -10,6 +10,7 @@
> > #include <errno.h>
> > #include <fcntl.h>
> > #include <string.h>
> > +#include <sys/stat.h>
> > #include <sys/mman.h>
> > #include <sys/param.h>
> > #include "init.h"
> >
>
> On 06/15/2010 04:06 AM, Liu Aleaxander wrote:
> > On Wed, Jun 16, 2010 at 7:16 AM, Boaz Harrosh <bharrosh@panasas.com> wrote:
> >>
> >> Yes. I have the same patch.
> >>
> >> Apparently it's new for Fedora 13. Previous Fedora's are compiling fine.
> >
> > Same here:)
> >
> >> I guess something has changed with the new gcc headers include sequence
> >
>
> Andrew? Jeff? someone?
I got it.
> I saw that some uml patches where pushed for -rc4. What about this patch?
> could some one push this patch? It's for FC13 compilation?
>
> It might be needed for stable@ as well. I'll try to test with old Kernels.
> Am back on an FC12 in the office so it'll take some time.
Yes, it's needed in -stable. People will want to compile 2.6.34 under
FC13.
------------------------------------------------------------------------------
This SF.net email is sponsored by Sprint
What will you do first with EVO, the first 4G phone?
Visit sprint.com/first -- http://p.sf.net/sfu/sprint-com-first
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Boaz Harrosh <bharrosh@panasas.com>
Cc: Liu Aleaxander <aleaxander@gmail.com>,
Jeff Dike <jdike@addtoit.com>,
user-mode-linux-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, stable@kernel.org
Subject: Re: [uml-devel] [PATCH] um: Include missing header file in os-linux/mem.c
Date: Tue, 29 Jun 2010 11:50:29 -0700 [thread overview]
Message-ID: <20100629115029.4eccea6e.akpm@linux-foundation.org> (raw)
In-Reply-To: <4C29B034.8070208@panasas.com>
On Tue, 29 Jun 2010 11:35:00 +0300
Boaz Harrosh <bharrosh@panasas.com> wrote:
> On 06/15/2010 11:06 AM, Liu Aleaxander wrote:
> > The os-linux/mem.c file calls fchmod function, which is declared in sys/stat.h
> > header file, so include it.
> >
> > Signed-off-by: Liu Aleaxander <Aleaxander@gmail.com>
> > ---
> > arch/um/os-Linux/mem.c | 1 +
> > 1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > diff --git a/arch/um/os-Linux/mem.c b/arch/um/os-Linux/mem.c
> > index 93a11d7..e696144 100644
> > --- a/arch/um/os-Linux/mem.c
> > +++ b/arch/um/os-Linux/mem.c
> > @@ -10,6 +10,7 @@
> > #include <errno.h>
> > #include <fcntl.h>
> > #include <string.h>
> > +#include <sys/stat.h>
> > #include <sys/mman.h>
> > #include <sys/param.h>
> > #include "init.h"
> >
>
> On 06/15/2010 04:06 AM, Liu Aleaxander wrote:
> > On Wed, Jun 16, 2010 at 7:16 AM, Boaz Harrosh <bharrosh@panasas.com> wrote:
> >>
> >> Yes. I have the same patch.
> >>
> >> Apparently it's new for Fedora 13. Previous Fedora's are compiling fine.
> >
> > Same here:)
> >
> >> I guess something has changed with the new gcc headers include sequence
> >
>
> Andrew? Jeff? someone?
I got it.
> I saw that some uml patches where pushed for -rc4. What about this patch?
> could some one push this patch? It's for FC13 compilation?
>
> It might be needed for stable@ as well. I'll try to test with old Kernels.
> Am back on an FC12 in the office so it'll take some time.
Yes, it's needed in -stable. People will want to compile 2.6.34 under
FC13.
next prev parent reply other threads:[~2010-06-29 18:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-15 8:06 [PATCH] um: Include missing header file in os-linux/mem.c Liu Aleaxander
2010-06-15 23:16 ` [uml-devel] " Boaz Harrosh
2010-06-16 5:27 ` Liu Aleaxander
2010-06-29 8:35 ` Boaz Harrosh
2010-06-29 18:50 ` Andrew Morton [this message]
2010-06-29 18:50 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100629115029.4eccea6e.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=aleaxander@gmail.com \
--cc=bharrosh@panasas.com \
--cc=jdike@addtoit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@kernel.org \
--cc=user-mode-linux-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.