From: Dan Carpenter <error27@gmail.com>
To: Kulikov Vasiliy <segooon@gmail.com>
Cc: Kernel Janitors <kernel-janitors@vger.kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 01/25] r852: remove casts from void*
Date: Tue, 29 Jun 2010 12:42:58 +0000 [thread overview]
Message-ID: <20100629123850.GO19184@bicker> (raw)
In-Reply-To: <1277806498-30738-1-git-send-email-segooon@gmail.com>
On Tue, Jun 29, 2010 at 02:14:57PM +0400, Kulikov Vasiliy wrote:
> Remove unnesessary casts from void*.
>
1) The subjects are not helpful. This one should say something about
"mtd" but it doesn't.
2) These haven't been run through checkpatch.pl. In fact, I can't be
certain anyone looked at these patches when I see things like:
- if((( lp = (struct wl_private *)dev->priv ) != NULL ) &&
- !( lp->flags & WVLAN2_UIL_BUSY )) {
+ if((( lp = dev->priv ) != NULL ) &&
+ !( lp->flags & WVLAN2_UIL_BUSY )) {
On the recieving end, someone has to review every patch that gets merged.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <error27@gmail.com>
To: Kulikov Vasiliy <segooon@gmail.com>
Cc: Kernel Janitors <kernel-janitors@vger.kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 01/25] r852: remove casts from void*
Date: Tue, 29 Jun 2010 14:42:58 +0200 [thread overview]
Message-ID: <20100629123850.GO19184@bicker> (raw)
In-Reply-To: <1277806498-30738-1-git-send-email-segooon@gmail.com>
On Tue, Jun 29, 2010 at 02:14:57PM +0400, Kulikov Vasiliy wrote:
> Remove unnesessary casts from void*.
>
1) The subjects are not helpful. This one should say something about
"mtd" but it doesn't.
2) These haven't been run through checkpatch.pl. In fact, I can't be
certain anyone looked at these patches when I see things like:
- if((( lp = (struct wl_private *)dev->priv ) != NULL ) &&
- !( lp->flags & WVLAN2_UIL_BUSY )) {
+ if((( lp = dev->priv ) != NULL ) &&
+ !( lp->flags & WVLAN2_UIL_BUSY )) {
On the recieving end, someone has to review every patch that gets merged.
regards,
dan carpenter
next prev parent reply other threads:[~2010-06-29 12:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-29 10:14 [PATCH 01/25] r852: remove casts from void* Kulikov Vasiliy
2010-06-29 10:14 ` Kulikov Vasiliy
2010-06-29 10:14 ` Kulikov Vasiliy
2010-06-29 12:42 ` Dan Carpenter [this message]
2010-06-29 12:42 ` Dan Carpenter
2010-06-29 12:56 ` walter harms
2010-06-29 12:56 ` walter harms
2010-06-29 15:28 ` Kulikov Vasiliy
2010-06-29 15:28 ` Kulikov Vasiliy
2010-06-29 19:01 ` Dan Carpenter
2010-06-29 19:01 ` Dan Carpenter
2010-07-13 9:57 ` Artem Bityutskiy
2010-07-13 9:57 ` Artem Bityutskiy
2010-07-13 9:57 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100629123850.GO19184@bicker \
--to=error27@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=segooon@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.