All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joel Becker <Joel.Becker-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
To: David Howells <dhowells-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: Ulrich Drepper <drepper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org,
	smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
	mcao-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org,
	aneesh.kumar-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org,
	linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	samba-technical-w/Ol4Ecudpl8XjKLYN78aQ@public.gmane.org,
	sjayaraman-l3A5Bk7waGM@public.gmane.org,
	linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 3/3] Add a pair of system calls to make extended file stats available
Date: Tue, 29 Jun 2010 15:48:44 -0700	[thread overview]
Message-ID: <20100629224844.GF4150@mail.oracle.com> (raw)
In-Reply-To: <26026.1277851016-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>

On Tue, Jun 29, 2010 at 11:36:56PM +0100, David Howells wrote:
> Ulrich Drepper <drepper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> > And while you're at it, maybe some spare fields at the end are nice.
> 
> I made it so that the syscall can return variable length data: the main xstat
> struct, plus extra records yet to be defined.  They could even be variable
> length and assembled/disassembled with something like the control message
> macros for recvmsg().

	The less variable length stuff the better, I think.  At least,
for the stuff stat(2) already returns, you should have a fixed-size
structure.  Even if I only pass the GIVE_ME_UIDS flag, I don't want to
have to deal with the variable size stuff until I've actually asked for
esoteric things.  I'll know that the non-UIDS fields are garbage by the
fact that I didn't ask for them.

Joel

-- 

"Time is an illusion, lunchtime doubly so."
        -Douglas Adams

Joel Becker
Consulting Software Developer
Oracle
E-mail: joel.becker-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org
Phone: (650) 506-8127

WARNING: multiple messages have this Message-ID (diff)
From: Joel Becker <Joel.Becker@oracle.com>
To: David Howells <dhowells@redhat.com>
Cc: Ulrich Drepper <drepper@gmail.com>,
	viro@zeniv.linux.org.uk, smfrench@gmail.com, jlayton@redhat.com,
	mcao@us.ibm.com, aneesh.kumar@linux.vnet.ibm.com,
	linux-cifs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-kernel@vger.kernel.org, samba-technical@lists.samba.org,
	sjayaraman@suse.de, linux-ext4@vger.kernel.org
Subject: Re: [PATCH 3/3] Add a pair of system calls to make extended file stats available
Date: Tue, 29 Jun 2010 15:48:44 -0700	[thread overview]
Message-ID: <20100629224844.GF4150@mail.oracle.com> (raw)
In-Reply-To: <26026.1277851016@redhat.com>

On Tue, Jun 29, 2010 at 11:36:56PM +0100, David Howells wrote:
> Ulrich Drepper <drepper@gmail.com> wrote:
> > And while you're at it, maybe some spare fields at the end are nice.
> 
> I made it so that the syscall can return variable length data: the main xstat
> struct, plus extra records yet to be defined.  They could even be variable
> length and assembled/disassembled with something like the control message
> macros for recvmsg().

	The less variable length stuff the better, I think.  At least,
for the stuff stat(2) already returns, you should have a fixed-size
structure.  Even if I only pass the GIVE_ME_UIDS flag, I don't want to
have to deal with the variable size stuff until I've actually asked for
esoteric things.  I'll know that the non-UIDS fields are garbage by the
fact that I didn't ask for them.

Joel

-- 

"Time is an illusion, lunchtime doubly so."
        -Douglas Adams

Joel Becker
Consulting Software Developer
Oracle
E-mail: joel.becker@oracle.com
Phone: (650) 506-8127

  parent reply	other threads:[~2010-06-29 22:48 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-29 20:02 [PATCH 0/3] Extended file stat functions David Howells
2010-06-29 20:02 ` David Howells
2010-06-29 20:03 ` [PATCH 1/3] Mark arguments to certain syscalls as being const David Howells
2010-06-29 20:03 ` [PATCH 2/3] AFS: Use i_generation not i_version for the vnode uniquifier David Howells
2010-06-29 20:23 ` [PATCH 0/3] Extended file stat functions Steve French
2010-06-29 20:23   ` Steve French
     [not found] ` <20100629200259.23196.81509.stgit-S6HVgzuS8uM4Awkfq6JHfwNdhmdF6hFW@public.gmane.org>
2010-06-29 20:03   ` [PATCH 3/3] Add a pair of system calls to make extended file stats available David Howells
2010-06-29 20:03     ` David Howells
     [not found]     ` <20100629200315.23196.68742.stgit-S6HVgzuS8uM4Awkfq6JHfwNdhmdF6hFW@public.gmane.org>
2010-06-29 22:13       ` Ulrich Drepper
2010-06-29 22:13         ` Ulrich Drepper
     [not found]         ` <AANLkTimSU_pCXW5zR8__Q3-fzgxwEUX8rPqLeZtPD_hX-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-06-29 22:33           ` Steve French
2010-06-29 22:33             ` Steve French
2010-06-29 22:36         ` David Howells
     [not found]           ` <26026.1277851016-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2010-06-29 22:48             ` Joel Becker [this message]
2010-06-29 22:48               ` Joel Becker
2010-06-29 22:48           ` Sage Weil
     [not found]           ` <20100629224844.GF4150-0Ol/1UON5C7fiIqoQl7HmA@public.gmane.org>
2010-06-29 23:29             ` David Howells
2010-06-29 23:29               ` David Howells
     [not found]               ` <32322.1277854192-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2010-07-01  1:12                 ` Joel Becker
2010-07-01  1:12                   ` Joel Becker
2010-06-30  8:20       ` Arnd Bergmann
2010-06-30  8:20         ` Arnd Bergmann
2010-06-30  8:59         ` David Howells
2010-06-29 20:28   ` [PATCH 0/3] Extended file stat functions Trond Myklebust
2010-06-29 20:28     ` Trond Myklebust
2010-06-29 20:50     ` David Howells
     [not found] ` <AANLkTimIh9ZAasPnN5xxGxbupwkct7UihHcMe26r-MD7-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-06-29 20:41   ` David Howells
2010-06-29 20:41     ` David Howells
2010-06-29 21:07 ` Bernd Schubert
     [not found] ` <201006292307.42440.bernd.schubert-97jfqw80gc6171pxa8y+qA@public.gmane.org>
2010-06-29 21:11   ` David Howells
2010-06-29 21:11     ` David Howells
     [not found]     ` <24517.1277845879-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2010-06-29 21:24       ` Bernd Schubert
2010-06-29 21:24         ` Bernd Schubert
2010-06-29 21:28         ` David Howells
2010-06-29 21:53           ` Bernd Schubert
2010-06-29 22:59           ` Maciej W. Rozycki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100629224844.GF4150@mail.oracle.com \
    --to=joel.becker-qhclzuegtsvqt0dzr+alfa@public.gmane.org \
    --cc=aneesh.kumar-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org \
    --cc=dhowells-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=drepper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mcao-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org \
    --cc=samba-technical-w/Ol4Ecudpl8XjKLYN78aQ@public.gmane.org \
    --cc=sjayaraman-l3A5Bk7waGM@public.gmane.org \
    --cc=smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.