All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Snitzer <snitzer@redhat.com>
To: James Bottomley <James.Bottomley@suse.de>
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
	FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>,
	linux-scsi <linux-scsi@vger.kernel.org>,
	dm-devel@redhat.com
Subject: Re: [RFC 1/2] block: implement an unprep function corresponding directly to prep
Date: Wed, 30 Jun 2010 13:23:09 -0400	[thread overview]
Message-ID: <20100630172308.GA14409@redhat.com> (raw)
In-Reply-To: <1277917264.2839.153.camel@mulgrave.site>

On Wed, Jun 30 2010 at  1:01pm -0400,
James Bottomley <James.Bottomley@suse.de> wrote:

> So this is more directly what I'm thinking.  It gives us an exactly
> correct place to hang the discard allocation in SCSI.  The next patch
> shows a potential implementation in sd.
> 
> I think it should avoid all the leaks people have been seeing trying to
> move the discard allocation/free into scsi.  I also think it should
> facilitate sending discard through SCSI as a REQ_TYPE_FS.

Thanks james!

I'll look to take this template and layer in Christoph's approach to
pushing the page allocation down into SCSI.

I'll also look at Tomo's REQ_TYPE_FS changes for discard.

I'll report back as soon as I have something.

Mike

  parent reply	other threads:[~2010-06-30 17:23 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-30 17:01 [RFC 1/2] block: implement an unprep function corresponding directly to prep James Bottomley
2010-06-30 17:10 ` [RFC 2/2] sd: free discard page in unprep function James Bottomley
2010-06-30 17:23 ` Mike Snitzer [this message]
2010-06-30 17:51 ` [RFC 1/2] block: implement an unprep function corresponding directly to prep Jens Axboe
2010-06-30 17:54   ` Martin K. Petersen
2010-07-01  1:47 ` FUJITA Tomonori
2010-07-01  3:47   ` Mike Snitzer
2010-07-01  4:44     ` [dm-devel] " FUJITA Tomonori
2010-07-02 11:03   ` Christoph Hellwig
2010-07-05  7:00     ` FUJITA Tomonori
2010-07-05 19:24       ` Christoph Hellwig
2010-07-05 21:50         ` Mark Lord
2010-07-05 21:54           ` Mark Lord
2010-07-05 22:00             ` Jeff Garzik
2010-08-03  3:01             ` Mark Lord
2010-07-06  7:04         ` FUJITA Tomonori
  -- strict thread matches above, loose matches on Subject: below --
2010-06-30 17:01 James Bottomley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100630172308.GA14409@redhat.com \
    --to=snitzer@redhat.com \
    --cc=James.Bottomley@suse.de \
    --cc=axboe@kernel.dk \
    --cc=dm-devel@redhat.com \
    --cc=fujita.tomonori@lab.ntt.co.jp \
    --cc=hch@lst.de \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.