All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jean Delvare <khali@linux-fr.org>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] Driver for MAX6696 temperature sensor
Date: Thu, 01 Jul 2010 06:33:11 +0000	[thread overview]
Message-ID: <20100701083311.1bcf22d3@hyperion.delvare> (raw)
In-Reply-To: <20100701011831.GA6915@ericsson.com>

Hi Guenter,

On Wed, 30 Jun 2010 18:18:31 -0700, Guenter Roeck wrote:
> one of the hwmon drivers I'll have to write is for MAX6696. This chip is similar to lm90 / max6680,
> only it supports three temperature sensors instead of two. The two external sensors share one
> set of registers.

How does it work exactly?

> What is the better approach - write a new driver based on the lm90 driver,
> or modify the lm90 driver to support max6696 and thus optionally three channels ?
> Any thoughts ?

Both are acceptable. Best choice depends on how intrusive it is to add
support to the lm90 driver. I suspect there won't be too much to add? I
would recommend trying it, and if we finally decide it's too intrusive,
copy the lm90 driver to a new one and clean up them both.

-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

  reply	other threads:[~2010-07-01  6:33 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-01  1:18 [lm-sensors] Driver for MAX6696 temperature sensor Guenter Roeck
2010-07-01  6:33 ` Jean Delvare [this message]
2010-07-01 15:05 ` Jean Delvare
2010-07-02  7:52 ` Jean Delvare
2010-07-02  9:53 ` Jean Delvare
2010-07-02 14:14 ` Guenter Roeck
2010-07-02 14:59 ` Jean Delvare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100701083311.1bcf22d3@hyperion.delvare \
    --to=khali@linux-fr.org \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.