All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <guenter.roeck@ericsson.com>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] Driver for MAX6696 temperature sensor
Date: Fri, 02 Jul 2010 14:14:06 +0000	[thread overview]
Message-ID: <20100702141406.GB14032@ericsson.com> (raw)
In-Reply-To: <20100701011831.GA6915@ericsson.com>

On Fri, Jul 02, 2010 at 05:53:45AM -0400, Jean Delvare wrote:
> Hi Guenter,
> 
> On Fri, 2 Jul 2010 01:38:30 -0700, Guenter Roeck wrote:
> > On Fri, Jul 02, 2010 at 03:52:04AM -0400, Jean Delvare wrote:
> > > Hi Guenter,
> > > 
> > > On Thu, 1 Jul 2010 18:17:24 -0700, Guenter Roeck wrote:
> > > > On Thu, Jul 01, 2010 at 11:05:01AM -0400, Jean Delvare wrote:
> > > > > On Thu, 1 Jul 2010 07:52:44 -0700, Guenter Roeck wrote:
> > > > > > I implemented a prototype last night. It adds about 130 lines of code, and changes about 20.
> > > > > > A few things like chip detection are still missing, so it will probably end up adding
> > > > > > maybe 150 lines of code.
> > > > > 
> > > > > Seems reasonable. And maybe another pair of eyes who know the lm90
> > > > > driver well will have suggestions to make it even smaller :)
> > > > 
> > > > Agreed.
> > > > 
> > > > Followup question: The chip supports three limits per sensor - ALERT, OT1, and OT2.
> > > > Default settings are along the line of 70, 90, and 120 degrees C. OT2 typically causes
> > > > a board shutdown.
> > > > 
> > > > Current API only allows for two limits, so I am using ALERT for min/max, OT1 for crit,
> > > > and ignore OT2. Any idea if/how we could report OT2 as well ?
> > > 
> > > I have no objection adding another limit to the sysfs-interface. I seem
> > > to recall that a few other thermal sensors would benefit from it.
> > > 
> > > Could take the form of temp[1-*]_warn or temp[1-*]_crit2 (or any other
> > > suggestion you may have). The w83795 driver I'm currently working on
> > 
> > temp[1-*]_crit2 would probably be a better fit. "warn" doesn't seem right
> > for a temperature causing a board reset.
> 
> Of course it really depends on what each limit does. "warn" would
> probably be the lowest high limit, only warning the user / admin that
> some action will be taken later if the temperature keeps raising.
> 
> Maybe temp[1-*]_emergency would be better than temp[1-*]_crit2?
> 
Since it would be the highest limit, temp[1-*]_emergency sounds really good. 

Guenter

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

  parent reply	other threads:[~2010-07-02 14:14 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-01  1:18 [lm-sensors] Driver for MAX6696 temperature sensor Guenter Roeck
2010-07-01  6:33 ` Jean Delvare
2010-07-01 15:05 ` Jean Delvare
2010-07-02  7:52 ` Jean Delvare
2010-07-02  9:53 ` Jean Delvare
2010-07-02 14:14 ` Guenter Roeck [this message]
2010-07-02 14:59 ` Jean Delvare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100702141406.GB14032@ericsson.com \
    --to=guenter.roeck@ericsson.com \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.