From: Tony Lindgren <tony@atomide.com>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH 2/2] arm: Make VFPv3 usable on ARMv6
Date: Thu, 1 Jul 2010 15:42:53 +0300 [thread overview]
Message-ID: <20100701124252.GR2822@atomide.com> (raw)
In-Reply-To: <1277473838.13134.30.camel@e102109-lin.cambridge.arm.com>
* Catalin Marinas <catalin.marinas@arm.com> [100625 16:44]:
> On Wed, 2010-06-23 at 08:57 +0100, Tony Lindgren wrote:
> > MVFR0 and MVFR1 are only available starting with ARM1136 r1p0 release
> > according to "B.5 VFP changes" in DDI0211F_arm1136_r1p0_trm.pdf. This is
> > also when TLS register got added, so we can use HAS_TLS also to test for
> > MVFR0 and MVFR1.
> >
> > Otherwise VFPFMRX and VFPFMXR access fails and we get:
> >
> > Internal error: Oops - undefined instruction: 0 [#1]
> > PC is at no_old_VFP_process+0x8/0x3c
> > LR is at __und_svc+0x48/0x80
> > ...
> >
> > Signed-off-by: Tony Lindgren <tony@atomide.com>
>
> The new version looks fine to me.
>
> Acked-by: Catalin Marinas <catalin.marinas@arm.com>
Thanks. Added your ack and posted to Russell's patch system:
http://www.arm.linux.org.uk/developer/patches/viewpatch.php?id=6203/1
Regards,
Tony
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] arm: Make VFPv3 usable on ARMv6
Date: Thu, 1 Jul 2010 15:42:53 +0300 [thread overview]
Message-ID: <20100701124252.GR2822@atomide.com> (raw)
In-Reply-To: <1277473838.13134.30.camel@e102109-lin.cambridge.arm.com>
* Catalin Marinas <catalin.marinas@arm.com> [100625 16:44]:
> On Wed, 2010-06-23 at 08:57 +0100, Tony Lindgren wrote:
> > MVFR0 and MVFR1 are only available starting with ARM1136 r1p0 release
> > according to "B.5 VFP changes" in DDI0211F_arm1136_r1p0_trm.pdf. This is
> > also when TLS register got added, so we can use HAS_TLS also to test for
> > MVFR0 and MVFR1.
> >
> > Otherwise VFPFMRX and VFPFMXR access fails and we get:
> >
> > Internal error: Oops - undefined instruction: 0 [#1]
> > PC is at no_old_VFP_process+0x8/0x3c
> > LR is at __und_svc+0x48/0x80
> > ...
> >
> > Signed-off-by: Tony Lindgren <tony@atomide.com>
>
> The new version looks fine to me.
>
> Acked-by: Catalin Marinas <catalin.marinas@arm.com>
Thanks. Added your ack and posted to Russell's patch system:
http://www.arm.linux.org.uk/developer/patches/viewpatch.php?id=6203/1
Regards,
Tony
next prev parent reply other threads:[~2010-07-01 12:42 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-21 13:51 [PATCH 0/2] Make ARMv6 behave with TLS, VFPv3, and NEON Tony Lindgren
2010-06-21 13:51 ` Tony Lindgren
2010-06-21 13:51 ` [PATCH 1/2] arm: Replace CONFIG_HAS_TLS_REG with HWCAP_TLS and check for it on V6 Tony Lindgren
2010-06-21 13:51 ` Tony Lindgren
2010-06-22 9:28 ` Tony Lindgren
2010-06-22 9:28 ` Tony Lindgren
2010-06-22 17:00 ` Jamie Lokier
2010-06-22 17:00 ` Jamie Lokier
2010-06-23 7:39 ` Tony Lindgren
2010-06-23 7:39 ` Tony Lindgren
2010-06-23 8:12 ` Russell King - ARM Linux
2010-06-23 8:12 ` Russell King - ARM Linux
2010-06-23 9:28 ` Tony Lindgren
2010-06-23 9:28 ` Tony Lindgren
2010-06-23 9:32 ` Russell King - ARM Linux
2010-06-23 9:32 ` Russell King - ARM Linux
2010-06-23 13:28 ` Jamie Lokier
2010-06-23 13:28 ` Jamie Lokier
2010-06-23 13:36 ` Jamie Lokier
2010-06-23 13:36 ` Jamie Lokier
2010-06-23 14:19 ` Nicolas Pitre
2010-06-23 14:19 ` Nicolas Pitre
2010-06-24 0:28 ` Jamie Lokier
2010-06-24 0:28 ` Jamie Lokier
2010-06-29 14:18 ` Tony Lindgren
2010-06-29 14:18 ` Tony Lindgren
2010-06-29 19:20 ` Nicolas Pitre
2010-06-29 19:20 ` Nicolas Pitre
2010-06-30 11:08 ` Tony Lindgren
2010-06-30 11:08 ` Tony Lindgren
2010-06-30 13:17 ` Tony Lindgren
2010-06-30 13:17 ` Tony Lindgren
2010-06-30 14:42 ` Nicolas Pitre
2010-06-30 14:42 ` Nicolas Pitre
2010-07-01 9:25 ` Tony Lindgren
2010-07-01 9:25 ` Tony Lindgren
2010-07-01 17:40 ` Jamie Lokier
2010-07-01 17:40 ` Jamie Lokier
2010-07-02 2:37 ` Nicolas Pitre
2010-07-02 2:37 ` Nicolas Pitre
2010-07-02 10:37 ` Tony Lindgren
2010-07-02 10:37 ` Tony Lindgren
2010-07-05 13:55 ` Tony Lindgren
2010-07-05 13:55 ` Tony Lindgren
2011-04-08 3:39 ` Li Li
2011-04-08 3:39 ` Li Li
2011-04-08 13:19 ` Nicolas Pitre
2011-04-08 13:19 ` Nicolas Pitre
2011-04-08 13:35 ` Li Li
2011-04-08 13:35 ` Li Li
2011-04-08 14:35 ` Jamie Lokier
2011-04-08 14:35 ` Jamie Lokier
2011-04-08 14:40 ` Li Li
2011-04-08 14:40 ` Li Li
2010-06-21 13:51 ` [PATCH 2/2] arm: Make VFPv3 usable on ARMv6 Tony Lindgren
2010-06-21 13:51 ` Tony Lindgren
2010-06-22 12:59 ` Catalin Marinas
2010-06-22 12:59 ` Catalin Marinas
2010-06-22 13:20 ` Tony Lindgren
2010-06-22 13:20 ` Tony Lindgren
2010-06-23 7:57 ` Tony Lindgren
2010-06-23 7:57 ` Tony Lindgren
2010-06-25 13:50 ` Catalin Marinas
2010-06-25 13:50 ` Catalin Marinas
2010-07-01 12:42 ` Tony Lindgren [this message]
2010-07-01 12:42 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100701124252.GR2822@atomide.com \
--to=tony@atomide.com \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.