From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Raffaele Recalcati <lamiaposta71@gmail.com>
Cc: davinci-linux-open-source@linux.davincidsp.com,
Takashi Iwai <tiwai@suse.de>,
linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
Davide Bonfanti <davide.bonfanti@bticino.it>,
Raffaele Recalcati <raffaele.recalcati@bticino.it>,
Troy Kisky <troy.kisky@boundarydevices.com>,
Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH 1/3] ASoC: DaVinci: Added two clocking possibilities to McBSP (I2S)
Date: Thu, 1 Jul 2010 15:35:40 +0100 [thread overview]
Message-ID: <20100701143540.GC8742@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <1277905678-4695-2-git-send-email-lamiaposta71@gmail.com>
On Wed, Jun 30, 2010 at 03:47:56PM +0200, Raffaele Recalcati wrote:
> +static int davinci_i2s_dai_set_clkdiv(struct snd_soc_dai *cpu_dai,
> + int div_id, int div)
> +{
> + struct davinci_mcbsp_dev *dev = cpu_dai->private_data;
> + int srgr;
> +
> + dev->clk_div = div;
> + return 0;
> +}
As previously mentioned this should check the div_id argument.
> + switch (master) {
> + case SND_SOC_DAIFMT_CBS_CFS:
...
> + case SND_SOC_DAIFMT_CBM_CFS:
...
> + default:
> + /* Clock and frame sync given from external sources */
The two remaining options (_CBM_CFM and _CBS_CFM) are different, your
description matches _CBM_CFM.
> + if (master == SND_SOC_DAIFMT_CBS_CFS ||
> + master == SND_SOC_DAIFMT_CBS_CFM) {
Switch statement again.
> + if (master == SND_SOC_DAIFMT_CBS_CFS ||
> + master == SND_SOC_DAIFMT_CBS_CFM) {
> + rcr |= DAVINCI_MCBSP_RCR_RFRLEN1(0);
> + xcr |= DAVINCI_MCBSP_XCR_XFRLEN1(0);
> + } else {
...and another. Please fix all these.
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Raffaele Recalcati <lamiaposta71@gmail.com>
Cc: davinci-linux-open-source@linux.davincidsp.com,
Raffaele Recalcati <raffaele.recalcati@bticino.it>,
Davide Bonfanti <davide.bonfanti@bticino.it>,
Liam Girdwood <lrg@slimlogic.co.uk>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.de>,
Troy Kisky <troy.kisky@boundarydevices.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] ASoC: DaVinci: Added two clocking possibilities to McBSP (I2S)
Date: Thu, 1 Jul 2010 15:35:40 +0100 [thread overview]
Message-ID: <20100701143540.GC8742@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <1277905678-4695-2-git-send-email-lamiaposta71@gmail.com>
On Wed, Jun 30, 2010 at 03:47:56PM +0200, Raffaele Recalcati wrote:
> +static int davinci_i2s_dai_set_clkdiv(struct snd_soc_dai *cpu_dai,
> + int div_id, int div)
> +{
> + struct davinci_mcbsp_dev *dev = cpu_dai->private_data;
> + int srgr;
> +
> + dev->clk_div = div;
> + return 0;
> +}
As previously mentioned this should check the div_id argument.
> + switch (master) {
> + case SND_SOC_DAIFMT_CBS_CFS:
...
> + case SND_SOC_DAIFMT_CBM_CFS:
...
> + default:
> + /* Clock and frame sync given from external sources */
The two remaining options (_CBM_CFM and _CBS_CFM) are different, your
description matches _CBM_CFM.
> + if (master == SND_SOC_DAIFMT_CBS_CFS ||
> + master == SND_SOC_DAIFMT_CBS_CFM) {
Switch statement again.
> + if (master == SND_SOC_DAIFMT_CBS_CFS ||
> + master == SND_SOC_DAIFMT_CBS_CFM) {
> + rcr |= DAVINCI_MCBSP_RCR_RFRLEN1(0);
> + xcr |= DAVINCI_MCBSP_XCR_XFRLEN1(0);
> + } else {
...and another. Please fix all these.
next prev parent reply other threads:[~2010-07-01 14:35 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1277905678-4695-1-git-send-email-lamiaposta71@gmail.com>
2010-06-30 13:47 ` [PATCH 1/3] ASoC: DaVinci: Added two clocking possibilities to McBSP (I2S) Raffaele Recalcati
2010-07-01 14:35 ` Mark Brown [this message]
2010-07-01 14:35 ` Mark Brown
2010-06-30 13:47 ` [PATCH 2/3] ASoC: DaVinci: Added selection of clk input pin for McBSP Raffaele Recalcati
2010-06-30 13:47 ` Raffaele Recalcati
2010-07-01 14:36 ` Mark Brown
2010-07-01 14:36 ` Mark Brown
2010-07-01 14:36 ` Mark Brown
2010-06-30 13:47 ` [PATCH 3/3] ASoC: DaVinci: Added fast clock timing for McBSP (I2S) Raffaele Recalcati
2010-06-30 13:47 ` Raffaele Recalcati
2010-07-01 15:01 ` Mark Brown
2010-07-01 15:01 ` Mark Brown
2010-07-01 15:01 ` Mark Brown
2010-07-01 15:03 ` Mark Brown
2010-07-01 15:03 ` Mark Brown
2010-07-01 15:03 ` Mark Brown
[not found] <1278405544-3852-1-git-send-email-lamiaposta71@gmail.com>
2010-07-06 8:39 ` [PATCH 1/3] ASoC: DaVinci: Added two clocking possibilities to " Raffaele Recalcati
2010-07-06 9:45 ` Liam Girdwood
2010-07-06 9:45 ` Liam Girdwood
2010-07-06 11:30 ` Sudhakar Rajashekhara
2010-07-06 11:30 ` Sudhakar Rajashekhara
[not found] ` <003001cb1cfe$a043a610$e0caf230$@raj@ti.com>
2010-07-06 14:54 ` Mark Brown
2010-07-06 14:54 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100701143540.GC8742@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=davide.bonfanti@bticino.it \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=lamiaposta71@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=raffaele.recalcati@bticino.it \
--cc=tiwai@suse.de \
--cc=troy.kisky@boundarydevices.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.