From: Andrew Morton <akpm@linux-foundation.org>
To: InKi Dae <inki.dae@samsung.com>
Cc: kmpark@infradead.org, linux-fbdev-devel@lists.sourceforge.net,
Ben Dooks <ben-linux@fluff.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/3] FB: Add some members for CPU Interface.
Date: Thu, 1 Jul 2010 15:26:43 -0700 [thread overview]
Message-ID: <20100701152643.41834b17.akpm@linux-foundation.org> (raw)
In-Reply-To: <4C29CABE.9020208@samsung.com>
On Tue, 29 Jun 2010 19:28:14 +0900
InKi Dae <inki.dae@samsung.com> wrote:
>
> CPU interface needs cs, wr setup, wr act and hold delay.
> I added some members for them to common framework.
>
> Signed-off-by: InKi Dae <inki.dae@samsung.com <mailto:p.osciak@samsung.com>>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com
> <mailto:kyungmin.park@samsung.com>>
These email addresses are mangled.
> --- a/drivers/video/modedb.c
> +++ b/drivers/video/modedb.c
> ...
> --- a/include/linux/fb.h
> +++ b/include/linux/fb.h
The patch seems pretty specific to s3c-fb. Is it possible and sensible
to somhow avoid adding code to generic files? Can we push more (or
all) of these changes into s3c-fb.c or into the arch/arm support code?
WARNING: multiple messages have this Message-ID (diff)
From: akpm@linux-foundation.org (Andrew Morton)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] FB: Add some members for CPU Interface.
Date: Thu, 1 Jul 2010 15:26:43 -0700 [thread overview]
Message-ID: <20100701152643.41834b17.akpm@linux-foundation.org> (raw)
In-Reply-To: <4C29CABE.9020208@samsung.com>
On Tue, 29 Jun 2010 19:28:14 +0900
InKi Dae <inki.dae@samsung.com> wrote:
>
> CPU interface needs cs, wr setup, wr act and hold delay.
> I added some members for them to common framework.
>
> Signed-off-by: InKi Dae <inki.dae at samsung.com <mailto:p.osciak@samsung.com>>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com
> <mailto:kyungmin.park@samsung.com>>
These email addresses are mangled.
> --- a/drivers/video/modedb.c
> +++ b/drivers/video/modedb.c
> ...
> --- a/include/linux/fb.h
> +++ b/include/linux/fb.h
The patch seems pretty specific to s3c-fb. Is it possible and sensible
to somhow avoid adding code to generic files? Can we push more (or
all) of these changes into s3c-fb.c or into the arch/arm support code?
next prev parent reply other threads:[~2010-07-01 22:26 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-29 8:31 [PATCH 0/3] ARM: S5PV210: Add MIPI-DSI support InKi Dae
2010-06-29 8:31 ` InKi Dae
[not found] ` <4C29B1C1.2000209@samsung.com>
[not found] ` <4C29CABE.9020208@samsung.com>
2010-07-01 22:26 ` Andrew Morton [this message]
2010-07-01 22:26 ` [PATCH 1/3] FB: Add some members for CPU Interface Andrew Morton
2010-07-02 8:47 ` [PATCH 0/2] ARM: S5PV210: Add MIPI-DSI support InKi Dae
2010-07-02 8:47 ` InKi Dae
2010-07-03 8:33 ` [PATCH v1 " InKi Dae
2010-07-03 8:33 ` InKi Dae
[not found] ` <4C29B4BA.4090903@samsung.com>
2010-07-02 8:50 ` [PATCH 1/2] S5PV210: FB: Add MIPI-DSI and CPU Interface features InKi Dae
2010-07-02 8:50 ` InKi Dae
2010-07-03 8:35 ` [PATCH v1 " InKi Dae
2010-07-03 8:35 ` InKi Dae
[not found] ` <4C29C766.7010901@samsung.com>
2010-07-02 8:51 ` [PATCH 2/2] S5PV210: Add MIPI-DSI Driver InKi Dae
2010-07-02 8:51 ` InKi Dae
2010-07-02 14:03 ` Ben Dooks
2010-07-02 14:03 ` Ben Dooks
2010-07-02 18:08 ` InKi Dae
2010-07-02 18:08 ` InKi Dae
2010-07-03 1:44 ` Jaya Kumar
2010-07-03 1:44 ` Jaya Kumar
2010-07-03 5:21 ` InKi Dae
2010-07-03 5:21 ` InKi Dae
2010-07-03 7:20 ` InKi Dae
2010-07-03 7:20 ` InKi Dae
2010-07-03 8:42 ` [PATCH v1 " InKi Dae
2010-07-03 8:42 ` InKi Dae
2010-07-04 19:33 ` Guennadi Liakhovetski
2010-07-04 19:33 ` Guennadi Liakhovetski
2010-07-02 13:34 ` [PATCH 0/3] ARM: S5PV210: Add MIPI-DSI support Ben Dooks
2010-07-02 13:34 ` Ben Dooks
-- strict thread matches above, loose matches on Subject: below --
2010-06-29 10:49 [PATCH 1/3] FB: Add some members for CPU Interface InKi Dae
2010-06-29 10:49 ` InKi Dae
2010-06-30 0:02 ` Jaya Kumar
2010-06-30 0:02 ` Jaya Kumar
2010-06-30 4:36 ` InKi Dae
2010-06-30 4:36 ` InKi Dae
2010-07-01 23:47 ` Jaya Kumar
2010-07-01 23:47 ` Jaya Kumar
2010-07-02 7:30 ` Russell King - ARM Linux
2010-07-02 7:30 ` Russell King - ARM Linux
2010-07-06 15:30 ` James Simmons
2010-07-06 15:33 ` James Simmons
2010-07-06 15:35 ` James Simmons
2010-07-06 20:23 ` Geert Uytterhoeven
2010-07-07 11:37 ` James Simmons
2010-07-05 8:42 ` Pawel Osciak
2010-07-05 8:42 ` Pawel Osciak
2010-07-02 1:21 In-Ki Dae
2010-07-02 1:46 ` Andrew Morton
2010-07-02 1:46 ` Andrew Morton
2010-07-02 1:51 In-Ki Dae
2010-07-02 2:35 In-Ki Dae
2010-07-02 7:50 In-Ki Dae
2010-07-06 16:09 ` James Simmons
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100701152643.41834b17.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=ben-linux@fluff.org \
--cc=inki.dae@samsung.com \
--cc=kmpark@infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.