From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Jan Beulich <JBeulich@novell.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH] x86: fix an off-by-one pirq range check
Date: Thu, 1 Jul 2010 12:19:45 -0400 [thread overview]
Message-ID: <20100701161945.GB4089@phenom.dumpdata.com> (raw)
In-Reply-To: <4C2C5F7B0200007800008FE9@vpn.id2.novell.com>
On Thu, Jul 01, 2010 at 08:27:23AM +0100, Jan Beulich wrote:
> >>> On 30.06.10 at 18:16, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> wrote:
> > On Wed, Jun 30, 2010 at 07:37:26AM +0100, Jan Beulich wrote:
> >> Signed-off-by: Jan Beulich <jbeulich@novell.com>
> >
> > Won't that make PV guest with only one IRQ passed through unable to ACK it?
> > (and if the IRQ is not shared that is).
>
> Why would you think so? In such a case, nr_pirqs would be 1, and the
> only permitted pirq would be 0. All other places do the range checks
> correctly, just this one would let through an out of bounds number.
Excellent. Thanks for the answer.
prev parent reply other threads:[~2010-07-01 16:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-30 6:37 [PATCH] x86: fix an off-by-one pirq range check Jan Beulich
2010-06-30 16:16 ` Konrad Rzeszutek Wilk
2010-07-01 7:27 ` Jan Beulich
2010-07-01 16:19 ` Konrad Rzeszutek Wilk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100701161945.GB4089@phenom.dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=JBeulich@novell.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.