All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <guenter.roeck@ericsson.com>
To: Jean Delvare <khali@linux-fr.org>
Cc: Jim Cromie <jim.cromie@gmail.com>,
	H Hartley Sweeten <hsweeten@visionengravers.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Ethan Lawrence <e.law87@yahoo.com>,
	"lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"lars4910@hotmail.com" <lars4910@hotmail.com>,
	"birdie@permonline.ru" <birdie@permonline.ru>,
	"jadcock@cox.net" <jadcock@cox.net>
Subject: Re: [lm-sensors] [PATCH/RFC] hwmon: Add support for W83667HG-B
Date: Fri, 02 Jul 2010 16:15:21 +0000	[thread overview]
Message-ID: <20100702161521.GA14580@ericsson.com> (raw)
In-Reply-To: <20100702165903.3d9dcdab@hyperion.delvare>

On Fri, Jul 02, 2010 at 10:59:03AM -0400, Jean Delvare wrote:
> On Fri, 2 Jul 2010 07:09:44 -0700, Guenter Roeck wrote:
> > On Fri, Jul 02, 2010 at 05:51:23AM -0400, Jean Delvare wrote:
> > > On Fri, 2 Jul 2010 01:31:44 -0700, Guenter Roeck wrote:
> > > > On Fri, Jul 02, 2010 at 04:13:45AM -0400, Jean Delvare wrote:
> > > > > On Fri, 2 Jul 2010 01:07:04 -0700, Guenter Roeck wrote:
> > > > > > I'll also add a check for the HG-I.
> > > > > 
> > > > > Do you have a datasheet for that one too?
> > > > > 
> > > > No. However, since we have a tester, we will have test coverage,
> > > > so I figured it should be worth a try. If it doesn't work
> > > > I can still drop it from the final patch.
> > > 
> > > FYI, I have a datasheet, which unfortunately I am not allowed to share.
> > > Please let me know if you want me to look up something for you.
> > > 
> > How about the changed registers ? Would give us an idea if the chip is closer to 
> > 667 or to 667-B.
> 
> There is no summary of this available. The only way is to go through
> both datasheets and compare all registers in sequence. This takes time,
> which is exactly why I couldn't find the time to do it :(
> 
Yes, I noticed. Changes can be quite subtle, too. 

I'll remove the HG-I chip detection from the next patch rev
unless I manage to get a datasheet as well.

Guenter

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <guenter.roeck@ericsson.com>
To: Jean Delvare <khali@linux-fr.org>
Cc: Jim Cromie <jim.cromie@gmail.com>,
	H Hartley Sweeten <hsweeten@visionengravers.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Ethan Lawrence <e.law87@yahoo.com>,
	"lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"lars4910@hotmail.com" <lars4910@hotmail.com>,
	"birdie@permonline.ru" <birdie@permonline.ru>,
	"jadcock@cox.net" <jadcock@cox.net>
Subject: Re: [PATCH/RFC] hwmon: Add support for W83667HG-B
Date: Fri, 2 Jul 2010 09:15:21 -0700	[thread overview]
Message-ID: <20100702161521.GA14580@ericsson.com> (raw)
In-Reply-To: <20100702165903.3d9dcdab@hyperion.delvare>

On Fri, Jul 02, 2010 at 10:59:03AM -0400, Jean Delvare wrote:
> On Fri, 2 Jul 2010 07:09:44 -0700, Guenter Roeck wrote:
> > On Fri, Jul 02, 2010 at 05:51:23AM -0400, Jean Delvare wrote:
> > > On Fri, 2 Jul 2010 01:31:44 -0700, Guenter Roeck wrote:
> > > > On Fri, Jul 02, 2010 at 04:13:45AM -0400, Jean Delvare wrote:
> > > > > On Fri, 2 Jul 2010 01:07:04 -0700, Guenter Roeck wrote:
> > > > > > I'll also add a check for the HG-I.
> > > > > 
> > > > > Do you have a datasheet for that one too?
> > > > > 
> > > > No. However, since we have a tester, we will have test coverage,
> > > > so I figured it should be worth a try. If it doesn't work
> > > > I can still drop it from the final patch.
> > > 
> > > FYI, I have a datasheet, which unfortunately I am not allowed to share.
> > > Please let me know if you want me to look up something for you.
> > > 
> > How about the changed registers ? Would give us an idea if the chip is closer to 
> > 667 or to 667-B.
> 
> There is no summary of this available. The only way is to go through
> both datasheets and compare all registers in sequence. This takes time,
> which is exactly why I couldn't find the time to do it :(
> 
Yes, I noticed. Changes can be quite subtle, too. 

I'll remove the HG-I chip detection from the next patch rev
unless I manage to get a datasheet as well.

Guenter

  reply	other threads:[~2010-07-02 16:15 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-01 22:02 [lm-sensors] [PATCH/RFC] hwmon: Add support for W83667HG-B Guenter Roeck
2010-07-01 22:02 ` Guenter Roeck
2010-07-02  6:55 ` [lm-sensors] " 宾西蒙
2010-07-02  7:08 ` Jean Delvare
2010-07-02  7:20 ` Jean Delvare
2010-07-02  7:20   ` Jean Delvare
2010-07-02  8:07   ` Guenter Roeck
2010-07-02  8:13     ` [lm-sensors] " Jean Delvare
2010-07-02  8:13       ` Jean Delvare
2010-07-02  8:31       ` [lm-sensors] " Guenter Roeck
2010-07-02  8:31         ` Guenter Roeck
2010-07-02  9:51         ` [lm-sensors] " Jean Delvare
2010-07-02  9:51           ` Jean Delvare
2010-07-02 14:09           ` [lm-sensors] " Guenter Roeck
2010-07-02 14:09             ` Guenter Roeck
2010-07-02 14:59             ` [lm-sensors] " Jean Delvare
2010-07-02 14:59               ` Jean Delvare
2010-07-02 16:15               ` Guenter Roeck [this message]
2010-07-02 16:15                 ` Guenter Roeck
2010-07-03  7:39                 ` [lm-sensors] " Jean Delvare
2010-07-03  7:39                   ` Jean Delvare
2010-07-02  8:25   ` [lm-sensors] " Guenter Roeck
2010-07-02  8:25     ` Guenter Roeck
2010-07-02  9:49     ` [lm-sensors] " Jean Delvare
2010-07-02  9:49       ` Jean Delvare
2010-07-02 14:54       ` [lm-sensors] " Guenter Roeck
2010-07-02 14:54         ` Guenter Roeck
2010-07-03  8:09         ` [lm-sensors] " Jean Delvare
2010-07-03  8:09           ` Jean Delvare
2010-07-03 14:34           ` [lm-sensors] " Guenter Roeck
2010-07-03 14:34             ` Guenter Roeck
2010-07-02  8:11 ` [lm-sensors] " Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100702161521.GA14580@ericsson.com \
    --to=guenter.roeck@ericsson.com \
    --cc=akpm@linux-foundation.org \
    --cc=birdie@permonline.ru \
    --cc=e.law87@yahoo.com \
    --cc=hsweeten@visionengravers.com \
    --cc=jadcock@cox.net \
    --cc=jim.cromie@gmail.com \
    --cc=khali@linux-fr.org \
    --cc=lars4910@hotmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.