From: Jamie Lokier <jamie@shareable.org>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 05/12] s3c-fb: Add support for display panning
Date: Sun, 04 Jul 2010 13:50:10 +0000 [thread overview]
Message-ID: <20100704135010.GA1201@shareable.org> (raw)
In-Reply-To: <003e01cb19ea$969e0090$c3da01b0$%osciak@samsung.com>
Pawel Osciak wrote:
> >Ben Dooks <ben@simtec.co.uk> wrote:
> >On 28/06/10 09:08, Pawel Osciak wrote:
>
> >> diff --git a/arch/arm/plat-samsung/include/plat/regs-fb.h b/arch/arm/plat-
> >samsung/include/plat/regs-fb.h
> >> index ac10013..f454e32 100644
> >> --- a/arch/arm/plat-samsung/include/plat/regs-fb.h
> >> +++ b/arch/arm/plat-samsung/include/plat/regs-fb.h
> >> @@ -112,6 +112,11 @@
> >> #define VIDCON2_ORGYCbCr (1 << 8)
> >> #define VIDCON2_YUVORDCrCb (1 << 7)
> >>
> >> +/* PRTCON (S3C6410, S5PC100) */
> >
> >Not listed in my S3C6410 manual?
> >
>
> Not in my either. It is there in the S5PC100 docs though. This is not an
> "official statement", but I've been testing panning on my 6410 *very*
> intensively and experienced a lot of crashes without it. Not a single one
> with it though. So it's either almost impossible luck or it is there,
> undocumented. There is a hole at this address anyway, so this shouldn't
> hurt anything.
Probably a good idea to put that in a comment, for the person who
looks at it in 5 years time and wonders if the code is mistaken.
-- Jamie
WARNING: multiple messages have this Message-ID (diff)
From: Jamie Lokier <jamie@shareable.org>
To: Pawel Osciak <p.osciak@samsung.com>
Cc: 'Ben Dooks' <ben@simtec.co.uk>,
linux-fbdev@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
kyungmin.park@samsung.com, ben-linux@fluff.org,
linux-arm-kernel@lists.infradead.org,
Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH v3 05/12] s3c-fb: Add support for display panning
Date: Sun, 4 Jul 2010 14:50:10 +0100 [thread overview]
Message-ID: <20100704135010.GA1201@shareable.org> (raw)
In-Reply-To: <003e01cb19ea$969e0090$c3da01b0$%osciak@samsung.com>
Pawel Osciak wrote:
> >Ben Dooks <ben@simtec.co.uk> wrote:
> >On 28/06/10 09:08, Pawel Osciak wrote:
>
> >> diff --git a/arch/arm/plat-samsung/include/plat/regs-fb.h b/arch/arm/plat-
> >samsung/include/plat/regs-fb.h
> >> index ac10013..f454e32 100644
> >> --- a/arch/arm/plat-samsung/include/plat/regs-fb.h
> >> +++ b/arch/arm/plat-samsung/include/plat/regs-fb.h
> >> @@ -112,6 +112,11 @@
> >> #define VIDCON2_ORGYCbCr (1 << 8)
> >> #define VIDCON2_YUVORDCrCb (1 << 7)
> >>
> >> +/* PRTCON (S3C6410, S5PC100) */
> >
> >Not listed in my S3C6410 manual?
> >
>
> Not in my either. It is there in the S5PC100 docs though. This is not an
> "official statement", but I've been testing panning on my 6410 *very*
> intensively and experienced a lot of crashes without it. Not a single one
> with it though. So it's either almost impossible luck or it is there,
> undocumented. There is a hole at this address anyway, so this shouldn't
> hurt anything.
Probably a good idea to put that in a comment, for the person who
looks at it in 5 years time and wonders if the code is mistaken.
-- Jamie
WARNING: multiple messages have this Message-ID (diff)
From: jamie@shareable.org (Jamie Lokier)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 05/12] s3c-fb: Add support for display panning
Date: Sun, 4 Jul 2010 14:50:10 +0100 [thread overview]
Message-ID: <20100704135010.GA1201@shareable.org> (raw)
In-Reply-To: <003e01cb19ea$969e0090$c3da01b0$%osciak@samsung.com>
Pawel Osciak wrote:
> >Ben Dooks <ben@simtec.co.uk> wrote:
> >On 28/06/10 09:08, Pawel Osciak wrote:
>
> >> diff --git a/arch/arm/plat-samsung/include/plat/regs-fb.h b/arch/arm/plat-
> >samsung/include/plat/regs-fb.h
> >> index ac10013..f454e32 100644
> >> --- a/arch/arm/plat-samsung/include/plat/regs-fb.h
> >> +++ b/arch/arm/plat-samsung/include/plat/regs-fb.h
> >> @@ -112,6 +112,11 @@
> >> #define VIDCON2_ORGYCbCr (1 << 8)
> >> #define VIDCON2_YUVORDCrCb (1 << 7)
> >>
> >> +/* PRTCON (S3C6410, S5PC100) */
> >
> >Not listed in my S3C6410 manual?
> >
>
> Not in my either. It is there in the S5PC100 docs though. This is not an
> "official statement", but I've been testing panning on my 6410 *very*
> intensively and experienced a lot of crashes without it. Not a single one
> with it though. So it's either almost impossible luck or it is there,
> undocumented. There is a hole at this address anyway, so this shouldn't
> hurt anything.
Probably a good idea to put that in a comment, for the person who
looks at it in 5 years time and wonders if the code is mistaken.
-- Jamie
next prev parent reply other threads:[~2010-07-04 13:50 UTC|newest]
Thread overview: 99+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-28 8:08 [PATCH v3 0/12] Various s3c-fb updates Pawel Osciak
2010-06-28 8:08 ` Pawel Osciak
2010-06-28 8:08 ` Pawel Osciak
2010-06-28 8:08 ` [PATCH v3 01/12] s3c-fb: Fix various null references on framebuffer Pawel Osciak
2010-06-28 8:08 ` [PATCH v3 01/12] s3c-fb: Fix various null references on framebuffer memory alloc failure Pawel Osciak
2010-06-28 8:08 ` Pawel Osciak
2010-07-02 9:51 ` [PATCH v3 01/12] s3c-fb: Fix various null references on framebuffer Ben Dooks
2010-07-02 9:51 ` [PATCH v3 01/12] s3c-fb: Fix various null references on framebuffer memory alloc failure Ben Dooks
2010-07-02 9:51 ` Ben Dooks
2010-07-02 12:56 ` [PATCH v3 01/12] s3c-fb: Fix various null references on Pawel Osciak
2010-07-02 12:56 ` [PATCH v3 01/12] s3c-fb: Fix various null references on framebuffer memory alloc failure Pawel Osciak
2010-07-02 12:56 ` Pawel Osciak
2010-07-06 16:16 ` [PATCH v3 01/12] s3c-fb: Fix various null references on framebuffer James Simmons
2010-07-06 16:16 ` [PATCH v3 01/12] s3c-fb: Fix various null references on framebuffer memory alloc failure James Simmons
2010-07-06 16:16 ` James Simmons
2010-06-28 8:08 ` [PATCH v3 02/12] s3c-fb: Correct FRAMESEL1 bitfield defines for Pawel Osciak
2010-06-28 8:08 ` [PATCH v3 02/12] s3c-fb: Correct FRAMESEL1 bitfield defines for VIDINTCON0 register Pawel Osciak
2010-06-28 8:08 ` Pawel Osciak
2010-07-02 10:51 ` [PATCH v3 02/12] s3c-fb: Correct FRAMESEL1 bitfield defines for Ben Dooks
2010-07-02 10:51 ` [PATCH v3 02/12] s3c-fb: Correct FRAMESEL1 bitfield defines for VIDINTCON0 register Ben Dooks
2010-07-02 10:51 ` Ben Dooks
2010-06-28 8:08 ` [PATCH v3 03/12] s3c-fb: Separate S5PC100 and S5PV210 framebuffer Pawel Osciak
2010-06-28 8:08 ` [PATCH v3 03/12] s3c-fb: Separate S5PC100 and S5PV210 framebuffer driver data structures Pawel Osciak
2010-06-28 8:08 ` Pawel Osciak
2010-07-02 11:12 ` [PATCH v3 03/12] s3c-fb: Separate S5PC100 and S5PV210 framebuffer Ben Dooks
2010-07-02 11:12 ` [PATCH v3 03/12] s3c-fb: Separate S5PC100 and S5PV210 framebuffer driver data structures Ben Dooks
2010-07-02 11:12 ` Ben Dooks
2010-07-02 13:05 ` [PATCH v3 03/12] s3c-fb: Separate S5PC100 and S5PV210 framebuffer Pawel Osciak
2010-07-02 13:05 ` [PATCH v3 03/12] s3c-fb: Separate S5PC100 and S5PV210 framebuffer driver data structures Pawel Osciak
2010-07-02 13:05 ` Pawel Osciak
2010-06-28 8:08 ` [PATCH v3 04/12] s3c-fb: Add device name initialization Pawel Osciak
2010-06-28 8:08 ` Pawel Osciak
2010-06-28 8:08 ` Pawel Osciak
2010-07-02 11:13 ` Ben Dooks
2010-07-02 11:13 ` Ben Dooks
2010-07-02 11:13 ` Ben Dooks
2010-06-28 8:08 ` [PATCH v3 05/12] s3c-fb: Add support for display panning Pawel Osciak
2010-06-28 8:08 ` Pawel Osciak
2010-06-28 8:08 ` Pawel Osciak
2010-06-28 11:28 ` Maurus Cuelenaere
2010-06-28 11:28 ` Maurus Cuelenaere
2010-06-28 11:28 ` Maurus Cuelenaere
2010-07-02 11:25 ` Ben Dooks
2010-07-02 11:25 ` Ben Dooks
2010-07-02 11:25 ` Ben Dooks
2010-07-02 11:33 ` Maurus Cuelenaere
2010-07-02 11:33 ` Maurus Cuelenaere
2010-07-02 11:33 ` Maurus Cuelenaere
2010-07-02 11:52 ` Mark Brown
2010-07-02 11:52 ` Mark Brown
2010-07-02 11:52 ` Mark Brown
2010-07-02 11:24 ` Ben Dooks
2010-07-02 11:24 ` Ben Dooks
2010-07-02 11:24 ` Ben Dooks
2010-07-02 13:29 ` Pawel Osciak
2010-07-02 13:29 ` Pawel Osciak
2010-07-02 13:29 ` Pawel Osciak
2010-07-04 13:50 ` Jamie Lokier [this message]
2010-07-04 13:50 ` Jamie Lokier
2010-07-04 13:50 ` Jamie Lokier
2010-06-28 8:08 ` [PATCH v3 06/12] s3c-fb: Add wait for VSYNC ioctl Pawel Osciak
2010-06-28 8:08 ` Pawel Osciak
2010-06-28 8:08 ` Pawel Osciak
2010-07-02 11:37 ` Ben Dooks
2010-07-02 11:37 ` Ben Dooks
2010-07-02 11:37 ` Ben Dooks
2010-07-02 14:39 ` Pawel Osciak
2010-07-02 14:39 ` Pawel Osciak
2010-07-02 14:39 ` Pawel Osciak
2010-06-28 8:08 ` [PATCH v3 07/12] s3c-fb: window 3 of 64xx+ does not have an osd_d Pawel Osciak
2010-06-28 8:08 ` [PATCH v3 07/12] s3c-fb: window 3 of 64xx+ does not have an osd_d register Pawel Osciak
2010-06-28 8:08 ` Pawel Osciak
2010-06-28 8:08 ` [PATCH v3 08/12] s3c-fb: Add SHADOWCON shadow register locking support Pawel Osciak
2010-06-28 8:08 ` [PATCH v3 08/12] s3c-fb: Add SHADOWCON shadow register locking support for S5PV210 Pawel Osciak
2010-06-28 8:08 ` Pawel Osciak
2010-07-02 13:11 ` [PATCH v3 08/12] s3c-fb: Add SHADOWCON shadow register locking Ben Dooks
2010-07-02 13:11 ` [PATCH v3 08/12] s3c-fb: Add SHADOWCON shadow register locking support for S5PV210 Ben Dooks
2010-07-02 13:11 ` Ben Dooks
2010-07-02 14:45 ` [PATCH v3 08/12] s3c-fb: Add SHADOWCON shadow register locking Pawel Osciak
2010-07-02 14:45 ` [PATCH v3 08/12] s3c-fb: Add SHADOWCON shadow register locking support for S5PV210 Pawel Osciak
2010-07-02 14:45 ` Pawel Osciak
2010-06-28 8:08 ` [PATCH v3 09/12] s3c-fb: Correct window osd size and alpha register Pawel Osciak
2010-06-28 8:08 ` [PATCH v3 09/12] s3c-fb: Correct window osd size and alpha register handling Pawel Osciak
2010-06-28 8:08 ` Pawel Osciak
2010-07-02 13:16 ` [PATCH v3 09/12] s3c-fb: Correct window osd size and alpha register Ben Dooks
2010-07-02 13:16 ` [PATCH v3 09/12] s3c-fb: Correct window osd size and alpha register handling Ben Dooks
2010-07-02 13:16 ` Ben Dooks
2010-07-02 14:53 ` [PATCH v3 09/12] s3c-fb: Correct window osd size and alpha Pawel Osciak
2010-07-02 14:53 ` [PATCH v3 09/12] s3c-fb: Correct window osd size and alpha register handling Pawel Osciak
2010-07-02 14:53 ` Pawel Osciak
2010-06-28 8:08 ` [PATCH v3 10/12] s3c-fb: Protect window-specific registers during Pawel Osciak
2010-06-28 8:08 ` [PATCH v3 10/12] s3c-fb: Protect window-specific registers during updates Pawel Osciak
2010-06-28 8:08 ` Pawel Osciak
2010-06-28 8:08 ` [PATCH v3 11/12] s3c-fb: fix section mismatch Pawel Osciak
2010-06-28 8:08 ` Pawel Osciak
2010-06-28 8:08 ` Pawel Osciak
2010-06-28 8:08 ` [PATCH v3 12/12] s3c-fb: Add support for DMA channel control on S5PV210 Pawel Osciak
2010-06-28 8:08 ` Pawel Osciak
2010-06-28 8:08 ` Pawel Osciak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100704135010.GA1201@shareable.org \
--to=jamie@shareable.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.