All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
To: Ryusuke Konishi
	<konishi.ryusuke-Zyj7fXuS5i5L9jVzuh4AOg@public.gmane.org>
Cc: linux-nilfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Jan Blunck <jblunck-l3A5Bk7waGM@public.gmane.org>
Subject: Re: [PATCH] nilfs2: remove BKL uses
Date: Mon, 5 Jul 2010 16:50:23 +0200	[thread overview]
Message-ID: <201007051650.23761.arnd@arndb.de> (raw)
In-Reply-To: <1278220928-28121-1-git-send-email-konishi.ryusuke-Zyj7fXuS5i5L9jVzuh4AOg@public.gmane.org>

On Sunday 04 July 2010, Ryusuke Konishi wrote:
> Nilfs has BKL uses in its put_super and remount functions, but none of
> them are necessary, just came from earlier push downs.  This
> eliminates the BKL uses from nilfs.
> 
> Signed-off-by: Ryusuke Konishi <konishi.ryusuke-Zyj7fXuS5i5L9jVzuh4AOg@public.gmane.org>

This looks good, but there is a another patch series pushing the BKL
into the get_sb and fill_super operations, which should be the final
pushdown for file systems. I wonder if there is a way to find a
shortcut on this so we don't need to add it first just to have you
go through the effort of removing it again.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-nilfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>
Cc: linux-nilfs@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-fsdevel@vger.kernel.org, Jan Blunck <jblunck@suse.de>
Subject: Re: [PATCH] nilfs2: remove BKL uses
Date: Mon, 5 Jul 2010 16:50:23 +0200	[thread overview]
Message-ID: <201007051650.23761.arnd@arndb.de> (raw)
In-Reply-To: <1278220928-28121-1-git-send-email-konishi.ryusuke@lab.ntt.co.jp>

On Sunday 04 July 2010, Ryusuke Konishi wrote:
> Nilfs has BKL uses in its put_super and remount functions, but none of
> them are necessary, just came from earlier push downs.  This
> eliminates the BKL uses from nilfs.
> 
> Signed-off-by: Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>

This looks good, but there is a another patch series pushing the BKL
into the get_sb and fill_super operations, which should be the final
pushdown for file systems. I wonder if there is a way to find a
shortcut on this so we don't need to add it first just to have you
go through the effort of removing it again.

	Arnd

  parent reply	other threads:[~2010-07-05 14:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-04  5:22 [PATCH] nilfs2: remove BKL uses Ryusuke Konishi
2010-07-04  5:22 ` Ryusuke Konishi
     [not found] ` <1278220928-28121-1-git-send-email-konishi.ryusuke-Zyj7fXuS5i5L9jVzuh4AOg@public.gmane.org>
2010-07-05 14:50   ` Arnd Bergmann [this message]
2010-07-05 14:50     ` Arnd Bergmann
     [not found]     ` <201007051650.23761.arnd-r2nGTMty4D4@public.gmane.org>
2010-07-05 14:53       ` Frederic Weisbecker
2010-07-05 14:53         ` Frederic Weisbecker
2010-07-05 17:55         ` Ryusuke Konishi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201007051650.23761.arnd@arndb.de \
    --to=arnd-r2ngtmty4d4@public.gmane.org \
    --cc=jblunck-l3A5Bk7waGM@public.gmane.org \
    --cc=konishi.ryusuke-Zyj7fXuS5i5L9jVzuh4AOg@public.gmane.org \
    --cc=linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-nilfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.