[PATCH] e2fsprogs: Add missed ext2fs_close

[PATCH] e2fsprogs: Add missed ext2fs_close

[Dmitry Monakhov]

[-- Attachment #1: Type: text/plain, Size: 298 bytes --]

Today i've accidentally overwrote first GB of 400Gb ext4 filesystem with
zeroes :) . So journal, group descriptors, rootdir and etc was destroyed.
Surprisingly i've able to recover some of my data after long fsck
process. I've met only one trivial bug in initialization stage.
See patch attached.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-e2fsprogs-Add-missed-ext2fs_close.patch --]
[-- Type: text/x-diff, Size: 769 bytes --]

>From 57f41b37a08581f4be8e87c54d8da42d5cb62ddd Mon Sep 17 00:00:00 2001
From: root <root@ws-qual.sw.ru>
Date: Wed, 30 Jun 2010 15:06:36 +0400
Subject: [PATCH] e2fsprogs: Add missed ext2fs_close


Signed-off-by: Dmitry Monakhov <dmonakhov@openvz.org>
---
 e2fsck/unix.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/e2fsck/unix.c b/e2fsck/unix.c
index bae3b38..273dbef 100644
--- a/e2fsck/unix.c
+++ b/e2fsck/unix.c
@@ -1061,6 +1061,8 @@ restart:
 			orig_retval = retval;
 			retval = try_open_fs(ctx, flags, io_ptr, &fs);
 			if ((orig_retval == 0) && retval != 0) {
+				if (fs)
+					ext2fs_close(fs);
 				com_err(ctx->program_name, retval,
 					"when using the backup blocks");
 				printf(_("%s: going back to original "
-- 
1.6.5.2

Re: [PATCH] e2fsprogs: Add missed ext2fs_close

[tytso]

On Wed, Jun 30, 2010 at 03:24:48PM +0400, Dmitry Monakhov wrote:
> Today i've accidentally overwrote first GB of 400Gb ext4 filesystem with
> zeroes :) . So journal, group descriptors, rootdir and etc was destroyed.
> Surprisingly i've able to recover some of my data after long fsck
> process. I've met only one trivial bug in initialization stage.
> See patch attached.

Thanks for catching this.  I've applied the fix to my source tree.

       	   	    	   		    - Ted