[PATCH 0/2] MIPS vdso fixes.

[PATCH 0/2] MIPS vdso fixes.

[David Daney]

Here are a couple of vdso fixes.  They aren't major problems, but good
to have none the less, I think.

David Daney (2):
  MIPS: Get rid of useless 'init_vdso successfully' message.
  MIPS: Make init_vdso a subsys_initcall.

 arch/mips/kernel/vdso.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

[PATCH 1/2] MIPS: Get rid of useless 'init_vdso successfully' message.

[David Daney]

In addition to being useless, it was mis-spelled.

Signed-off-by: David Daney <ddaney@caviumnetworks.com>
---
 arch/mips/kernel/vdso.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/arch/mips/kernel/vdso.c b/arch/mips/kernel/vdso.c
index 0847279..891c117 100644
--- a/arch/mips/kernel/vdso.c
+++ b/arch/mips/kernel/vdso.c
@@ -61,8 +61,6 @@ static int __init init_vdso(void)
 
 	vunmap(vdso);
 
-	pr_notice("init_vdso successfull\n");
-
 	return 0;
 }
 device_initcall(init_vdso);
-- 
1.6.6.1

Re: [PATCH 1/2] MIPS: Get rid of useless 'init_vdso successfully' message.

[Ralf Baechle]

Applied.  Thanks!

  Ralf

[PATCH 2/2] MIPS: Make init_vdso a subsys_initcall.

[David Daney]

Quoting from Jiri Slaby's patch of a similar nature for x86:

    When initrd is in use and a driver does request_module() in its
    module_init (i.e. __initcall or device_initcall), a modprobe
    process is created with VDSO mapping. But VDSO is inited even in
    __initcall, i.e. on the same level (at the same time), so it may
    not be inited yet (link order matters).

Move init_vdso up to subsys_initcall to avoid the issue.

Signed-off-by: David Daney <ddaney@caviumnetworks.com>
Cc: Jiri Slaby <jslaby@suse.cz>
---
 arch/mips/kernel/vdso.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/mips/kernel/vdso.c b/arch/mips/kernel/vdso.c
index 891c117..7baa0b5 100644
--- a/arch/mips/kernel/vdso.c
+++ b/arch/mips/kernel/vdso.c
@@ -63,7 +63,7 @@ static int __init init_vdso(void)
 
 	return 0;
 }
-device_initcall(init_vdso);
+subsys_initcall(init_vdso);
 
 static unsigned long vdso_addr(unsigned long start)
 {
-- 
1.6.6.1

Re: [PATCH 2/2] MIPS: Make init_vdso a subsys_initcall.

[Ralf Baechle]

Thanks, applied.

  Ralf