From: Christoph Hellwig <hch@infradead.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Jens Axboe <axboe@kernel.dk>,
Christoph Hellwig <hch@infradead.org>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
John Kacur <jkacur@redhat.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH 4/6] block: remove BKL from BLKROSET and BLKFLSBUF
Date: Tue, 6 Jul 2010 21:52:32 -0400 [thread overview]
Message-ID: <20100707015232.GF2950@infradead.org> (raw)
In-Reply-To: <1278193640-24223-5-git-send-email-arnd@arndb.de>
On Sat, Jul 03, 2010 at 11:47:18PM +0200, Arnd Bergmann wrote:
> We only call the functions set_device_ro(),
> invalidate_bdev(), sync_filesystem() and sync_blockdev()
> while holding the BKL in these commands. All
> of these are also done in other code paths without
> the BKL, which leads me to the conclusion that
> the BKL is not needed here either.
>
> The reason we hold it here is that it was originally
> pushed down into the ioctl function from vfs_ioctl.
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2010-07-07 1:52 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-03 21:47 [PATCH 0/6] block: BKL removal, version 3 Arnd Bergmann
2010-07-03 21:47 ` [PATCH 1/6] block: push down BKL into .locked_ioctl Arnd Bergmann
2010-07-04 7:30 ` Sam Ravnborg
2010-07-04 20:59 ` Arnd Bergmann
2010-07-07 1:52 ` Christoph Hellwig
2010-07-07 13:28 ` Arnd Bergmann
2010-07-03 21:47 ` [PATCH 2/6] block: push down BKL into .open and .release Arnd Bergmann
2010-07-04 8:01 ` Sam Ravnborg
2010-07-04 17:33 ` Arjan van de Ven
2010-07-04 20:27 ` Geert Uytterhoeven
2010-07-04 21:09 ` Arnd Bergmann
2010-07-07 1:50 ` Christoph Hellwig
2010-07-07 14:04 ` Arnd Bergmann
2010-07-03 21:47 ` [PATCH 3/6] block: push BKL into blktrace ioctls Arnd Bergmann
2010-07-07 1:50 ` Christoph Hellwig
2010-07-07 13:46 ` Arnd Bergmann
2010-07-03 21:47 ` [PATCH 4/6] block: remove BKL from BLKROSET and BLKFLSBUF Arnd Bergmann
2010-07-07 1:52 ` Christoph Hellwig [this message]
2010-07-03 21:47 ` [PATCH 5/6] block: remove BKL from partition code Arnd Bergmann
2010-07-07 2:04 ` Christoph Hellwig
2010-07-03 21:47 ` [PATCH 6/6] scsi/sd: remove big kernel lock Arnd Bergmann
2010-07-07 2:06 ` Christoph Hellwig
2010-07-07 13:54 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100707015232.GF2950@infradead.org \
--to=hch@infradead.org \
--cc=arnd@arndb.de \
--cc=axboe@kernel.dk \
--cc=fweisbec@gmail.com \
--cc=jkacur@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.